From: Robin Murphy <robin.murphy@arm.com>
To: Thomas Meyer <thomas@m3y3r.de>,
catalin.marinas@arm.com, will.deacon@arm.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] arm64: Cocci spatch "vma_pages"
Date: Tue, 26 Sep 2017 12:57:15 +0100 [thread overview]
Message-ID: <8d4fa6de-f8e2-f073-cfc8-ce78947ad599@arm.com> (raw)
In-Reply-To: <1505946334393-397244072-2-diffsplit-thomas@m3y3r.de>
On 20/09/17 23:29, Thomas Meyer wrote:
> Use vma_pages function on vma object instead of explicit computation.
> Found by coccinelle spatch "api/vma_pages.cocci"
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
I guess this can be picked up independently of the other patches?
Robin.
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> ---
>
> diff -u -p a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c
> --- a/arch/arm64/mm/dma-mapping.c
> +++ b/arch/arm64/mm/dma-mapping.c
> @@ -303,8 +303,7 @@ static int __swiotlb_mmap_pfn(struct vm_
> unsigned long pfn, size_t size)
> {
> int ret = -ENXIO;
> - unsigned long nr_vma_pages = (vma->vm_end - vma->vm_start) >>
> - PAGE_SHIFT;
> + unsigned long nr_vma_pages = vma_pages(vma);
> unsigned long nr_pages = PAGE_ALIGN(size) >> PAGE_SHIFT;
> unsigned long off = vma->vm_pgoff;
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2017-09-26 11:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 22:29 [PATCH 0/7] Cocci spatch "vma_pages" - v4.14-rc1 Thomas Meyer
2017-09-20 22:29 ` [PATCH 1/7] ARM: dma-mapping: Cocci spatch "vma_pages" Thomas Meyer
2017-09-20 22:29 ` [PATCH 5/7] MIPS: " Thomas Meyer
2017-09-20 22:29 ` [PATCH 6/7] KVM: PPC: " Thomas Meyer
2017-10-19 3:46 ` Paul Mackerras
2017-09-20 22:29 ` [PATCH 2/7] arm64: " Thomas Meyer
2017-09-26 11:57 ` Robin Murphy [this message]
2017-09-20 22:29 ` [PATCH 4/7] microblaze: " Thomas Meyer
2017-09-25 13:37 ` Michal Simek
2017-09-20 22:29 ` [PATCH 7/7] drm/rockchip: " Thomas Meyer
2017-09-21 1:02 ` Mark yao
2017-09-26 5:12 ` Daniel Vetter
2017-09-26 6:33 ` Mark yao
2017-09-26 8:08 ` Daniel Vetter
2017-09-26 9:06 ` Mark yao
2017-09-20 22:29 ` [PATCH 3/7] metag: " Thomas Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d4fa6de-f8e2-f073-cfc8-ce78947ad599@arm.com \
--to=robin.murphy@arm.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@m3y3r.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®