From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from imap5.colo.codethink.co.uk (imap5.colo.codethink.co.uk [78.40.148.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EABB1F30BB for ; Thu, 18 Jun 2026 10:01:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.40.148.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781776864; cv=none; b=KXofnHT/l/oMUXXKNAYNFvy1Kddi7F5XPl0tfJilsN//iske0NBB5Sv4drhCRB7fYlKj6zEKUuDjfEK4hHZnFU6iB9/RTOb3eGo6v84WqpCW04xExULww570O8L/VtLDNUAGQqWt53bzgyIqvjNVI/Jy+tA/QpamarBtVvaQP9M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781776864; c=relaxed/simple; bh=dyxrYhCeRhXRWSVxsmf3ErLq2VlYXJbIRlSjZ7L2TDc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YTR98KbWCCvyt0u/D9mBw8LUvKBu5sDZALiPkQJINJs2645xGPUD5HKWoI383rUjx7A0DH5zKXCKP8HPCm9eqxgmOPaiqCnWlVP/3V+gjUcu5mgC0Eq90YzP9gwQ+c45vzohMNWoMmnHGPtVmyAX++EHfhJYvzomj77ADbHdb9U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=codethink.co.uk; spf=pass smtp.mailfrom=codethink.co.uk; dkim=pass (2048-bit key) header.d=codethink.co.uk header.i=@codethink.co.uk header.b=wtnf436f; arc=none smtp.client-ip=78.40.148.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=codethink.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codethink.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codethink.co.uk header.i=@codethink.co.uk header.b="wtnf436f" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codethink.co.uk; s=imap5-20230908; h=Sender:Content-Transfer-Encoding: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Reply-To; bh=cUIDQGjQbraB7GWk21Atx3vElnBKtXw52ZBnFB0BMCc=; b=wtnf436f4Sn7RMsa sB2CPLQkFjFuPiHJXcrTRnRPrdBNjLdXJKJzM5XgfAiV4rJvSXXG1qJT5JKC+s8pM8y1caTanvZt1 8yvt0KyMuBETtZFZfC6+vwC3EHkK9DlD/ntkFa9ZeKxIaPSWEq+hG0boWvNa4bkYyTJp+izQ0eOgv 58662RQ1hJ1+bn8SFPINfHqp6WxjmetKl7O123XLLnN2WKaQoOTwY4puyoY7rXJ1qfPe1FCxWmhFF GlW74o7R2KghPdgluqRXbm9HXbyspRAtXsUr4Dxx2ua9PJ1bNTp4Z42ZH+MXCvaMOLTYsMczIDeDY kieBlQ9lIyrMU2uEFQ==; Received: from [63.135.74.212] (helo=[192.168.1.241]) by imap5.colo.codethink.co.uk with esmtpsa (Exim 4.94.2 #2 (Debian)) id 1wa9YI-00FGcb-G7; Thu, 18 Jun 2026 11:00:50 +0100 Message-ID: <8d529389-41ac-4d44-ab70-15b52047c3e3@codethink.co.uk> Date: Thu, 18 Jun 2026 11:00:49 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/page_alloc: include for vm_numa_stat_key To: Zi Yan Cc: Andrew Morton , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260617132726.1086576-1-ben.dooks@codethink.co.uk> Content-Language: en-GB From: Ben Dooks Organization: Codethink Limited. In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: ben.dooks@codethink.co.uk On 17/06/2026 16:47, Zi Yan wrote: > On 17 Jun 2026, at 9:27, Ben Dooks wrote: > >> The vm_numa_stat_key is declared in but this is >> currently not included in mm/page_alloc.c so include it to fix >> the following sparse warning: >> >> mm/page_alloc.c:165:1: warning: symbol 'vm_numa_stat_key' was not declared. Should it be static? >> >> Signed-off-by: Ben Dooks >> --- >> mm/page_alloc.c | 1 + >> 1 file changed, 1 insertion(+) >> > vmstat.h is already included at line 37[1]. > > I wonder why sparse complains and why adding a duplicated one below fixes > it. Thanks for catching this, it turns out this warning is coming from the riscv64 build and I re-ran the arm64 thinking this had been fixed. The issue is actually riscv64 does not default CONFIG_NUMA which then does not define the 'vm_numa_stat_key' but mm/page_alloc.c creates in anyway. Will re-test by guarding 'vm_numa_stat_key' with CONFIG_NUMA -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html