Re: [PATCH v5 2/5] arm64: dts: qcom: sm8550-qrd: add SPMI ADC channels and thermal nodes

[Neil Armstrong <neil.armstrong@linaro.org>]

On 7/7/26 12:21, Konrad Dybcio wrote:
> On 7/2/26 11:48 AM, Neil Armstrong wrote:
>> Add the SPMI ADC channels on the PMK8550 SPMI5 ADC3 for the
>> other PMICS on the system.
>>
>> The thermal nodes are sorted by the sensor channel to be
>> coherent with the system thermal nodes ordering.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> Konrad
> 
> 
>> +	channel@749 {
>> +		reg = <ADC5_GEN3_AMUX6_THM_100K_PU(7)>;
>> +		label = "pm8550b_wls_therm";
>> +		qcom,ratiometric;
>> +		/* use the default settle time */
> 
> P.S. grumpy nit - I'd prefer if default was captured explicitly
> anyway

Ack will update,

Thanks,
Neil

> 
> Konrad