From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Matthias Proske <email@matthias-proske.de>,
Kalle Valo <kvalo@kernel.org>,
Norbert van Bolhuis <nvbolhuis@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Ondrej Jirman <megi@xff.cz>,
Erick Archer <erick.archer@outlook.com>,
Jacobe Zang <jacobe.zang@wesion.com>
Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
brcm80211-dev-list.pdl@broadcom.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: brcmfmac: keep power during suspend if board requires it
Date: Wed, 12 Feb 2025 21:07:10 +0100 [thread overview]
Message-ID: <8d5ae153-24fb-44bf-89a9-e366e0f205f3@broadcom.com> (raw)
In-Reply-To: <20250212185941.146958-2-email@matthias-proske.de>
On 2/12/2025 7:59 PM, Matthias Proske wrote:
> After commit 92cadedd9d5f ("brcmfmac: Avoid keeping power to SDIO card
> unless WOWL is used"), the wifi adapter by default is turned off on
> suspend and then re-probed on resume.
>
> This conflicts with some embedded boards that require to remain powered.
> They will fail on resume with:
>
> brcmfmac: brcmf_sdio_bus_rxctl: resumed on timeout
> ieee80211 phy1: brcmf_bus_started: failed: -110
> ieee80211 phy1: brcmf_attach: dongle is not responding: err=-110
> brcmfmac: brcmf_sdio_firmware_callback: brcmf_attach failed
>
> This commit checks for the Device Tree property 'cap-power-off-cards'.
> If this property is not set, it means that we do not have the capability
> to power off and should therefore remain powered.
Thanks! Looks good to me.
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Matthias Proske <email@matthias-proske.de>
> ---
> .../broadcom/brcm80211/brcmfmac/bcmsdh.c | 20 ++++++++++++-------
> 1 file changed, 13 insertions(+), 7 deletions(-)
prev parent reply other threads:[~2025-02-12 20:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 18:59 Matthias Proske
2025-02-12 20:07 ` Arend van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d5ae153-24fb-44bf-89a9-e366e0f205f3@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=email@matthias-proske.de \
--cc=erick.archer@outlook.com \
--cc=jacobe.zang@wesion.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=megi@xff.cz \
--cc=nvbolhuis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®