From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f170.google.com (mail-dy1-f170.google.com [74.125.82.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A00E1373 for ; Tue, 13 Jan 2026 00:00:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768262430; cv=none; b=O3hrvsYaK+QYPhvRtIafiLK8vkGRAwcZUtH2J3FUlTMBAIjzm5KFLu2VS4JRsF2NNcZiWzK8uWTytQQKhphRcNqGuM52u16kj0jQavQAdE1tx2Hm89D5MkOqY1KZx3WfhG8tc+n0atNxgrGlg1QzYy0eZjQVV9V3UhBIJ+GKAB8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768262430; c=relaxed/simple; bh=AB46dIc3yizScZvd1REalZDXMZ+TOT02GcTeNQrT7FM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QwSoNmi6X3Hk1N1Q77/RJTRKnr0skd+DW3LQp0NLMc+AhOrqasZm6cjxGhE7RxY1BMwoiz/ZMvf0rS1dHpQZRpudHx8FAYn4uTaqhZAy6egPxPrudg9tvTyTnfJg4pdvqd6SBB3z2beyyuvTIXcv4ufQas3XXOW4eO2n05FF3bs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cuHn/xHK; arc=none smtp.client-ip=74.125.82.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cuHn/xHK" Received: by mail-dy1-f170.google.com with SMTP id 5a478bee46e88-2ae53df0be7so11309346eec.1 for ; Mon, 12 Jan 2026 16:00:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768262428; x=1768867228; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=/Ca7ba810N8yfT2a0uOQiRTeHQwK7t+A9fpbfT6p0g0=; b=cuHn/xHKC4Fx4u8p+uokujrGx81NZV/+bb6pQWkWRSqwZAyALsS8kAvtzCG/OJGTmS F7NuYdac3rRaLWQP3KwQ/Lmrl7Q+lxvuvut+HTOkF+3c3GzGeCE+UYH7gOHE0ZArQmp9 6TT828npXw3pDvuUBQaMqV9TqNnyfC57kNQqNLzItNRO5uuX5mOk3dFc1RoQO5tQ5kNj 6L45SPIs3NkL9j6mH58JfwBWQXqm2FcBQPSKinuzhzzKqbiq3pQzAJxwbVNHnMM2bH9Y FeuNTEhRK0Z8by42PaQI656LKO78KFAJnePwyI/hl73URfPDyQnziyotrJ22iaAYbUhm 7zAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768262428; x=1768867228; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=/Ca7ba810N8yfT2a0uOQiRTeHQwK7t+A9fpbfT6p0g0=; b=wLtYRqf+ueLaA+M0z6P0eeSRK2g1vz4sObBqkJtTRz61xSpZrTsVi/YDGlMIx+WV2F OGSiLClCG/3YNh5ev/aPT0e5Jzw2fMb9TAifqWK+PsJIglmx6Eo5NBsRiM3ECQ5sB0me +epP85/6AJIvlvYUUg2jOo9PehVsGOphQmC2RuxnOw4fgu2EGIWN84xMIziM3xVtGJRy aGViFk/T7MZu/jNoHIYFHI9nukBwM4kG6BZuJtTUdaV6M6XmkoFMH9Y9gcwrpzfWT2zU rtMJf7c+BqISZc3IrklvFc1JzpzLZT0zeM6zIz0Yz+Uw/Q1fz2JKXGg0aKZoSisNNgUa 0OgQ== X-Forwarded-Encrypted: i=1; AJvYcCWBTmWO4VbL7bffiw4A+xF9PyA/Ng0ynD07cLWHguw5Y2FD3eMLiY3VnaFycR21TFu+30bZnIs6N4Z5Itc=@vger.kernel.org X-Gm-Message-State: AOJu0YwYy4OLeoVeqtla/tNPotzjd1y5HpsZWeszZstvBHEJHtt826pW kjOzHbYn7Axmg4Ai7Di8X4++0+ucxABwUN+OXYHT+S0lRtX79ZrBJBB0 X-Gm-Gg: AY/fxX5Peg/H/zZUaDXia6tHPhUEzv5iJKdRN9mvi7lR2+iBDYJklEgoDjiHQ49I7Pc cQwZL6jn/sP+dXRN/Qsq3ZIQGQmhN/AePYMonkxwv2gFfJm4dj3OkN4j8Q9kQZom/dr+92o/+ZG X4aK08BifjpaR8llqHx20zAqWgl88MIuntGUx46UQmCZP/uBOYuBXW2d1AKCFI5QqoEIdwibgh4 At7wi1aKDjSRe+YSTAFWaSTbL8Q8WojDH9Lm/O4XW5U2JLMebiFY2il4W4F12xuNsykp1Gr+A+I KgOdWFWYOB7y6MaCIonhxIJYz2EJsgjbvnLmmBkTJ1blmNfQhYF+c7X5xDHXpWBY5MQzxdkh74t 3DKG4YHe8L9rxsv4PDbjZQCn2mcp7dhooAn2ehN8Pl3Pzf3wwk+27ESoxdJMu1H3UMa0JNARn4m T7faJY4vzY+lvjOKONT9B4HhgN X-Google-Smtp-Source: AGHT+IE6yvQ2ddlvX9nyemFmo4N5T/S3GXfv8OCsJYg1pE6WW3PJHwa8O1dQ8ly5F9NmxtGXBloc6A== X-Received: by 2002:a05:7301:fd8b:b0:2ae:5b24:1cf6 with SMTP id 5a478bee46e88-2b17d30f886mr14686787eec.32.1768262427467; Mon, 12 Jan 2026 16:00:27 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b17078ccf4sm16958219eec.16.2026.01.12.16.00.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 16:00:27 -0800 (PST) Sender: Guenter Roeck Date: Mon, 12 Jan 2026 16:00:25 -0800 From: Guenter Roeck To: Andrew Jeffery Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: hwmon: Convert aspeed,ast2400-pwm-tacho to DT schema Message-ID: <8d63c13e-15d2-4555-a110-4d446f3db314@roeck-us.net> References: <20260109-dev-dt-warnings-hwmon-v1-1-f2a84cdb0e1b@codeconstruct.com.au> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260109-dev-dt-warnings-hwmon-v1-1-f2a84cdb0e1b@codeconstruct.com.au> On Fri, Jan 09, 2026 at 04:40:28PM +1030, Andrew Jeffery wrote: > From: "Rob Herring (Arm)" > > Convert the ASpeed fan controller binding to DT schema format. > > The '#size-cells' value is 0 rather 1. > > Some users define more that 8 fan nodes where 2 fans share a PWM. The > driver seems to let the 2nd fan just overwrite the 1st one. That also > creates some addressing errors in the DT (duplicate addresses and wrong > unit-addresses). > > Signed-off-by: Rob Herring (Arm) > Acked-by: Guenter Roeck > Signed-off-by: Andrew Jeffery > --- > Hello, > > This change has been on a bit of a journey[1][2] and was eventually > integrated into my RFC series tidying up the AST2600 EVB at [3]. Rob > did some further digging at [4] and I've now addressed his finding > there. > > Much of the series at [3] was merged so I'm splitting out what remains > and peeling off the RFC label after making necessary fixes. > > Guenter - I've included your A-b tag from [3], but as I'm sending this > to be applied through the hwmon tree, do with that as you please. > > Changes since the series at [3]: > - Update #cooling-cells to 2 based on Rob's observation at [4] > Applied. Thanks, Guenter