Hi, I created a pull request fix it on github. Best, Charles -----邮件原件----- 发件人: Ian Rogers 发送时间: 2025年1月24日 12:14 收件人: Charles Han(韩春超) ; Edward 抄送: peterz@infradead.org; mingo@redhat.com; acme@kernel.org; namhyung@kernel.org; mark.rutland@arm.com; alexander.shishkin@linux.intel.com; jolsa@kernel.org; adrian.hunter@intel.com; kan.liang@linux.intel.com; linux-perf-users@vger.kernel.org; linux-kernel@vger.kernel.org 主题: Re: [PATCH] perf vendor events: Fix double word in BriefDescription On Thu, Jan 23, 2025 at 7:55 PM Charles Han wrote: > > Remove the repeated word "for" in BriefDescription. > > Signed-off-by: Charles Han Hi, Thanks for the contribution and reporting the issue! These files are generated by the script here: https://github.com/intel/perfmon/blob/main/scripts/create_perf_json.py In the input json files I see the same error: https://github.com/intel/perfmon/blob/main/GNR/events/graniterapids_uncore_experimental.json#L7524 Ed could you address this or should Charles send a fix to github? Thanks, Ian > --- > .../graniterapids/uncore-interconnect.json | 36 +++++++++---------- > 1 file changed, 18 insertions(+), 18 deletions(-) > > diff --git > a/tools/perf/pmu-events/arch/x86/graniterapids/uncore-interconnect.jso > n > b/tools/perf/pmu-events/arch/x86/graniterapids/uncore-interconnect.jso > n index 856ee985ecd4..0f5332ad0b80 100644 > --- > a/tools/perf/pmu-events/arch/x86/graniterapids/uncore-interconnect.jso > n > +++ b/tools/perf/pmu-events/arch/x86/graniterapids/uncore-interconnect > +++ .json > @@ -1016,7 +1016,7 @@ > "Unit": "MDF" > }, > { > - "BriefDescription": "Egress bypasses for for AD_BNC", > + "BriefDescription": "Egress bypasses for AD_BNC", > "Counter": "0,1,2,3", > "EventCode": "0x1E", > "EventName": "UNC_MDF_TxR_BYPASS.AD_BNC", @@ -1026,7 +1026,7 > @@ > "Unit": "MDF" > }, > { > - "BriefDescription": "Egress bypasses for for AD_CRD", > + "BriefDescription": "Egress bypasses for AD_CRD", > "Counter": "0,1,2,3", > "EventCode": "0x1E", > "EventName": "UNC_MDF_TxR_BYPASS.AD_CRD", @@ -1036,7 +1036,7 > @@ > "Unit": "MDF" > }, > { > - "BriefDescription": "Egress bypasses for for AK", > + "BriefDescription": "Egress bypasses for AK", > "Counter": "0,1,2,3", > "EventCode": "0x1E", > "EventName": "UNC_MDF_TxR_BYPASS.AK", @@ -1046,7 +1046,7 @@ > "Unit": "MDF" > }, > { > - "BriefDescription": "Egress bypasses for for BL_BNC", > + "BriefDescription": "Egress bypasses for BL_BNC", > "Counter": "0,1,2,3", > "EventCode": "0x1E", > "EventName": "UNC_MDF_TxR_BYPASS.BL_BNC", @@ -1056,7 +1056,7 > @@ > "Unit": "MDF" > }, > { > - "BriefDescription": "Egress bypasses for for BL_CRD", > + "BriefDescription": "Egress bypasses for BL_CRD", > "Counter": "0,1,2,3", > "EventCode": "0x1E", > "EventName": "UNC_MDF_TxR_BYPASS.BL_CRD", @@ -1066,7 +1066,7 > @@ > "Unit": "MDF" > }, > { > - "BriefDescription": "Egress bypasses for for IV", > + "BriefDescription": "Egress bypasses for IV", > "Counter": "0,1,2,3", > "EventCode": "0x1E", > "EventName": "UNC_MDF_TxR_BYPASS.IV", @@ -1076,7 +1076,7 @@ > "Unit": "MDF" > }, > { > - "BriefDescription": "Number of egress inserts for for AD_BNC", > + "BriefDescription": "Number of egress inserts for AD_BNC", > "Counter": "0,1,2,3", > "EventCode": "0x1C", > "EventName": "UNC_MDF_TxR_INSERTS.AD_BNC", @@ -1086,7 +1086,7 > @@ > "Unit": "MDF" > }, > { > - "BriefDescription": "Number of egress inserts for for AD_CRD", > + "BriefDescription": "Number of egress inserts for AD_CRD", > "Counter": "0,1,2,3", > "EventCode": "0x1C", > "EventName": "UNC_MDF_TxR_INSERTS.AD_CRD", @@ -1096,7 +1096,7 > @@ > "Unit": "MDF" > }, > { > - "BriefDescription": "Number of egress inserts for for AK", > + "BriefDescription": "Number of egress inserts for AK", > "Counter": "0,1,2,3", > "EventCode": "0x1C", > "EventName": "UNC_MDF_TxR_INSERTS.AK", @@ -1106,7 +1106,7 @@ > "Unit": "MDF" > }, > { > - "BriefDescription": "Number of egress inserts for for BL_BNC", > + "BriefDescription": "Number of egress inserts for BL_BNC", > "Counter": "0,1,2,3", > "EventCode": "0x1C", > "EventName": "UNC_MDF_TxR_INSERTS.BL_BNC", @@ -1116,7 +1116,7 > @@ > "Unit": "MDF" > }, > { > - "BriefDescription": "Number of egress inserts for for BL_CRD", > + "BriefDescription": "Number of egress inserts for BL_CRD", > "Counter": "0,1,2,3", > "EventCode": "0x1C", > "EventName": "UNC_MDF_TxR_INSERTS.BL_CRD", @@ -1126,7 +1126,7 > @@ > "Unit": "MDF" > }, > { > - "BriefDescription": "Number of egress inserts for for IV", > + "BriefDescription": "Number of egress inserts for IV", > "Counter": "0,1,2,3", > "EventCode": "0x1C", > "EventName": "UNC_MDF_TxR_INSERTS.IV", @@ -1136,7 +1136,7 @@ > "Unit": "MDF" > }, > { > - "BriefDescription": "Egress occupancy for for AD_BNC", > + "BriefDescription": "Egress occupancy for AD_BNC", > "Counter": "0,1,2,3", > "EventCode": "0x1D", > "EventName": "UNC_MDF_TxR_OCCUPANCY.AD_BNC", @@ -1146,7 > +1146,7 @@ > "Unit": "MDF" > }, > { > - "BriefDescription": "Egress occupancy for for AD_CRD", > + "BriefDescription": "Egress occupancy for AD_CRD", > "Counter": "0,1,2,3", > "EventCode": "0x1D", > "EventName": "UNC_MDF_TxR_OCCUPANCY.AD_CRD", @@ -1156,7 > +1156,7 @@ > "Unit": "MDF" > }, > { > - "BriefDescription": "Egress occupancy for for AK", > + "BriefDescription": "Egress occupancy for AK", > "Counter": "0,1,2,3", > "EventCode": "0x1D", > "EventName": "UNC_MDF_TxR_OCCUPANCY.AK", @@ -1166,7 +1166,7 > @@ > "Unit": "MDF" > }, > { > - "BriefDescription": "Egress occupancy for for BL_BNC", > + "BriefDescription": "Egress occupancy for BL_BNC", > "Counter": "0,1,2,3", > "EventCode": "0x1D", > "EventName": "UNC_MDF_TxR_OCCUPANCY.BL_BNC", @@ -1176,7 > +1176,7 @@ > "Unit": "MDF" > }, > { > - "BriefDescription": "Egress occupancy for for BL_CRD", > + "BriefDescription": "Egress occupancy for BL_CRD", > "Counter": "0,1,2,3", > "EventCode": "0x1D", > "EventName": "UNC_MDF_TxR_OCCUPANCY.BL_CRD", @@ -1186,7 > +1186,7 @@ > "Unit": "MDF" > }, > { > - "BriefDescription": "Egress occupancy for for IV", > + "BriefDescription": "Egress occupancy for IV", > "Counter": "0,1,2,3", > "EventCode": "0x1D", > "EventName": "UNC_MDF_TxR_OCCUPANCY.IV", > -- > 2.31.1 >