mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com>
To: Bart Van Assche <bvanassche@acm.org>, <alim.akhtar@samsung.com>,
	<avri.altman@wdc.com>, <robh@kernel.org>, <krzk+dt@kernel.org>,
	<conor+dt@kernel.org>, <mani@kernel.org>,
	<James.Bottomley@HansenPartnership.com>,
	<martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH V3 1/4] ufs: dt-bindings: Document gear and rate limit properties
Date: Thu, 28 Aug 2025 22:15:10 +0530	[thread overview]
Message-ID: <8d705694-498a-4592-b93a-7df6a1dd5211@quicinc.com> (raw)
In-Reply-To: <9944c595-da68-43c0-8364-6a8665a0fc3f@acm.org>



On 26-Aug-25 9:05 PM, Bart Van Assche wrote:
> On 8/26/25 8:08 AM, Ram Kumar Dwivedi wrote:
>> +  limit-hs-gear:
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    minimum: 1
>> +    maximum: 5
>> +    default: 5
>> +    description:
>> +      Restricts the maximum HS gear used in both TX and RX directions,
>> +      typically for hardware or power constraints in automotive use cases.
> 
> The UFSHCI 5.0 spec will add gear 6 soon. So why to restrict the maximum
> gear to 5?
> 
>> +  limit-rate:
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    enum: [1, 2]
>> +    default: 2
>> +    description:
>> +      Restricts the UFS controller to Rate A (1) or Rate B (2) for both
>> +      TX and RX directions, often required in automotive environments due
>> +      to hardware limitations.
> 
> As far as I know no numeric values are associated with these rates in
> the UFSHCI 4.1 standard nor in any of the previous versions of this
> standard. Does the .yaml syntax support something like "enum: [A, B]"?
Hi Bart,

As per the MIPI UniPro spec:

In Section 5.7.12.3.2, the hs_series is defined as:
hs_series = Flags[3] + 1;

In Section 5.7.7.1, Flags[3] is described as:
Set to ‘0’ for Series A and ‘1’ for Series B (PA_HSSeries).

While issuing the DME command from the UFS driver to set the rate,
the values 1 and 2 are passed as arguments for Rate A and Rate B
respectively. Additionally, the hs_rate variable is of type u32.

Thanks,
Ram

> 
> Thanks,
> 
> Bart.


  parent reply	other threads:[~2025-08-28 16:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-26 15:08 [PATCH V3 0/4] Add DT-based gear and rate limiting support Ram Kumar Dwivedi
2025-08-26 15:08 ` [PATCH V3 1/4] ufs: dt-bindings: Document gear and rate limit properties Ram Kumar Dwivedi
2025-08-26 15:35   ` Bart Van Assche
2025-08-28 16:25     ` Ram Kumar Dwivedi
2025-08-28 17:41       ` Krzysztof Kozlowski
2025-08-28 16:45     ` Ram Kumar Dwivedi [this message]
2025-08-28 17:22       ` Bart Van Assche
2025-09-01  4:07         ` Manivannan Sadhasivam
2025-09-01 16:01           ` Ram Kumar Dwivedi
2025-08-28 17:41       ` Krzysztof Kozlowski
2025-08-28 17:40     ` Krzysztof Kozlowski
2025-08-28 18:27       ` Bart Van Assche
2025-08-26 15:08 ` [PATCH V3 2/4] ufs: ufs-qcom: Remove redundant re-assignment to hs_rate Ram Kumar Dwivedi
2025-08-26 15:08 ` [PATCH V3 3/4] ufs: pltfrm: Allow limiting HS gear and rate via DT Ram Kumar Dwivedi
2025-08-26 15:08 ` [PATCH V3 4/4] ufs: ufs-qcom: Add support for limiting HS gear and rate Ram Kumar Dwivedi
2025-08-26 15:37   ` Bart Van Assche
2025-08-28 16:28     ` Ram Kumar Dwivedi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8d705694-498a-4592-b93a-7df6a1dd5211@quicinc.com \
    --to=quic_rdwivedi@quicinc.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=bvanassche@acm.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®