From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751193AbdAXOwg (ORCPT ); Tue, 24 Jan 2017 09:52:36 -0500 Received: from mail-lf0-f68.google.com ([209.85.215.68]:36064 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751171AbdAXOwe (ORCPT ); Tue, 24 Jan 2017 09:52:34 -0500 Subject: Re: fs/jffs2/readinode.c:189: faulty logic ? To: David Binderman , "dwmw2@infradead.org" , "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" References: From: Marek Vasut Message-ID: <8d72adf5-097f-0c72-edfc-d23d4199e9d4@gmail.com> Date: Tue, 24 Jan 2017 15:52:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/24/2017 09:15 AM, David Binderman wrote: > Hello there, > > fs/jffs2/readinode.c:189]: (style) Condition 'tn.fn.ofs>=offset' is always true > > Source code is > > if (tn->fn->ofs < offset) > next = tn->rb.rb_right; > else if (tn->fn->ofs >= offset) > next = tn->rb.rb_left; > else > break; > > Maybe better code > > if (tn->fn->ofs < offset) > next = tn->rb.rb_right; > else if (tn->fn->ofs > offset) > next = tn->rb.rb_left; > else > break; This changes the logic of the code for equality case, please elaborate why this is OK. > Regards > > David Binderman > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/ > -- Best regards, Marek Vasut