From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FB7C2D8779 for ; Wed, 3 Dec 2025 10:52:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764759145; cv=none; b=hpU6S1/mAdziq3tX6rdNHgMp/vlz3mnzeB3xOwKXYsGuX8MV8HzfOLi6MmbjLETIa3rmDvx23FKFGlH7xFsa3lLEBmks+QgmWGXOB0dS46FEsrE5pgr4JKXU5Qbar4nCSBxzZuIvnVZIes+SroHuXacqTaQF8TSI+IqhFNCq4oE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764759145; c=relaxed/simple; bh=ztTdAKd1Kpr5YomVO8DRG2y5O30QjhJMIPeeeKWJX+I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=M3dSS8X6Gy6VRZolTweMrasU8KOM+liyGsSUxEi+3njRJyBaAko+nKOs5i0HFx68kxuEAALCdJ664glJbTTfgN62r1j661ppACJV5J0/xceKoCloQbt2fkOUXBYr1Y5X64QFrBSvxOJZ6G3teuU3MNeLpk+EmPr0VduS+HdBKIY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=peNi5Vc5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DyQhdCIz; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="peNi5Vc5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DyQhdCIz" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B39Nhw12113778 for ; Wed, 3 Dec 2025 10:52:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5vZ1VnRCXWcgnHJPtqVaYUCxuUng/cpM+q7cKSjAg/c=; b=peNi5Vc5bggo6gKA DfST/T/TqhUlTAs+tCcAEOr7UIjv+nKXP8d3roSYVB6yfJzpJqSnZuvTA1VV5QFS oqfUU0SEduGvZPP1ysSLTp249x02Y7gRwYF3zKwso3uBT/SAoTFrJgaFtEgHakEK Sa0d6LCW//Ua3Yqlt8nPSJudi4NoCY+MqLjB88JDi7hgy6KwVg5wDcXqGOQZi4Qm EXYXykqBYLY8RPI1sDffV6pioCaZCwh5ZPWSQT/50LxfVYoeaRgTwd6rUxGH/cbK xboiRYqJZXiE0pZwm/nuXPiMgs3u4bfUEje03EK9b3dulvp5657JQByPkF0LUaFg ICEUAw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4atjhpgcjm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 03 Dec 2025 10:52:21 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8b184fa3ffbso165020985a.3 for ; Wed, 03 Dec 2025 02:52:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764759141; x=1765363941; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5vZ1VnRCXWcgnHJPtqVaYUCxuUng/cpM+q7cKSjAg/c=; b=DyQhdCIzt/jL6g/UtzxdDLHRgTAIdZhT/FvvnhPdYRZUWMtYG9l5Z+WLtP77q9C9Ir p8z8uDeUTAWwTYhD2lf7lBWJbIraK/5x0Dj2lmy2fBWNthqPKCqHf3GmzIVoSiR9D3aZ RelAcFPXpB/UL5AAP9DrPhzsPpsVBOl96Oad9ALpbpKcn/jIzoqSKsdYl7KSI3dvwPkq DXJFM2uY0LqPpKDwvVCEamP41Sk0LjfO9NzVsotumDZJ2o96kSp9H49jg2Ts1RR8gFYj qgiX1R8sovgkH2KglE0AjZK90TnlvelhdzpfH4Crq1F4WZd3mFNk7ngcf0mUA7LJajj7 rR0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764759141; x=1765363941; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5vZ1VnRCXWcgnHJPtqVaYUCxuUng/cpM+q7cKSjAg/c=; b=ES+qOuL/3a3jhD0iqzmlmNiHVLf/ZHwEQ9JxoCy2eMU8uVF7z3VIe5vy37JSinCveC FX+hCnACuwoVxrgvuodV55xtyYGpIb0PEDssvc2+bBnxbubG/W7I1mV7Ewb2DQ9XNQK3 FopRYZxokyOMsbaJeltyt00HdhgWYNwD9dAteE1zpvBtp0icQpPoHq4mjLMvuSVuPI98 LD2Nqt0+J8GDSNTVlpKkh7Zec90qjRAuCD9HAXJmNmcU7a/VL5B4srwelNKj+28TyN5t hCYNrJYMWSyl5M/XTXHDe3Zf+RHeEMjHmS2Rh6z5mRcHDmYGUSeBc5CjhaKwfP/L2Z0z LrvA== X-Forwarded-Encrypted: i=1; AJvYcCWwr11UjhYoX+ykHfrl61UkMJAwO5vq5bDyQ/05m/nWxTkObQZlW2RuB8ObXT8hOo5CeWL5zStPyH56ooc=@vger.kernel.org X-Gm-Message-State: AOJu0YxSuAg6Gb1806qlb383m8kdT3+bsr153q40lJ/hXPS46ZlNd9OH GlraAk0z+cVlfq6C3IVFZ2vpSgOzj+hvxdzdmHXsdehX07yQP7gdCRo4VepAeOb5JzFvMsNaWVU z8cFEIy/HTSwnGMUE/UEm/wqNIY363GDhHpnVgGIo/S4a6rWwmmHq+rzOd7IXJvfC2G8= X-Gm-Gg: ASbGncuXv9t2Ds9HSyGKvZlli0k9O442Vd98BzvE82MBOzKj+BZBOh0lJse8o+BTGnm 3ozTuIDo++uo3IP1vAeN9R16Y5kapTwFdxJl5lCaugQlW4JhsQC/C9Ib5xeI+dL26BIgNH7PL4p M3AtUvDPEaQr9t2QtGo9gxZFtSOjAZpDtfWxBnpTTlplk+txRGrcTNqH1FUHwpUCw+XWpX1Kv5K CJy67K2NN8yaKPflssNmVMj6gEP1I/k7vFe9HEI1TgWxEeHC2Q4E8m3fwTLer/AnMc+e4mcQSL6 qeaXE+SNHyU/lsQFR6XyMme1CwC4x2OWoel6eJe28n/kuEIC3cHcc9xguH4uU6gWW7MzxcWJQjf jmf4GbNx6glwmdktJ1N/0rUKiB4onemXGSPKxHOcBIf6lJ9Pph2zlAvd2nIQGYu5Prw== X-Received: by 2002:ac8:5aca:0:b0:4ed:6862:cdd0 with SMTP id d75a77b69052e-4f01b3c6537mr7755981cf.10.1764759140850; Wed, 03 Dec 2025 02:52:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IEdWUGIoNIL31WiMD6DpVjL8veFOOnMngyL++n2fVxw+jql4LOvHqu1/kBYwXN7VlvemkiO8g== X-Received: by 2002:ac8:5aca:0:b0:4ed:6862:cdd0 with SMTP id d75a77b69052e-4f01b3c6537mr7755661cf.10.1764759140401; Wed, 03 Dec 2025 02:52:20 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f59e8612sm1706205766b.52.2025.12.03.02.52.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Dec 2025 02:52:19 -0800 (PST) Message-ID: <8d769fb3-cd2a-492c-8aa3-064ebbc5eee4@oss.qualcomm.com> Date: Wed, 3 Dec 2025 11:52:17 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Revert "clk: qcom: cpu-8996: simplify the cpu_clk_notifier_cb" To: Christopher Obbard , Bjorn Andersson , Michael Turquette , Stephen Boyd , Konrad Dybcio , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Dmitry Baryshkov References: <20251202-wip-obbardc-qcom-msm8096-clk-cpu-fix-downclock-v1-1-90208427e6b1@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251202-wip-obbardc-qcom-msm8096-clk-cpu-fix-downclock-v1-1-90208427e6b1@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=JJg2csKb c=1 sm=1 tr=0 ts=69301665 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=sfOm8-O8AAAA:8 a=WelLum9FaPyErNbxTGEA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=cvBusfyB2V15izCimMoJ:22 a=TvTJqdcANYtsRzA46cdi:22 X-Proofpoint-ORIG-GUID: gicojDXij0bJ38BP7IIAHN-BQfeuZkFN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjAzMDA4NiBTYWx0ZWRfX8oGWTxn9pW9f UxIfAP4mzxtcb3JFJwmnmVWKdNRiGY1dsx3wo2156ZvkTvd63UZR7cqocKZBTUKGPwd88IS5xz/ uaPL3ZIc2xEn0nH4V57SGrOPQCqEySY4ClawfMZ7izsFlJsRdxVjXXkD6Y34mpDMOL+bo4c/5r3 W8dGymohCmshkoCIlW7qt9F9FymJbcmpeWYvlZKxtadsrug3ysvq25DfGP8yalRj6t9vTvr08Q1 vTJ++Bm0RP82KPkT59pv82IlR+FcvQ5FPEAVWEg+e+w17Ksmx0RyYSkHK/ZNU6P23UkiiipqCj0 dNkNXunzHaNFShLwhZ7h2QeixdcRw6go3+wRozXYdSI4Sa3fpEKMfTJ7IDCo5l1Zj/u2RD0vNBp YLIGa5IqUk6t4jQ4z3bI91kXso8SyQ== X-Proofpoint-GUID: gicojDXij0bJ38BP7IIAHN-BQfeuZkFN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-02_01,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 phishscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 adultscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512030086 On 12/2/25 10:24 PM, Christopher Obbard wrote: > This reverts commit b3b274bc9d3d7307308aeaf75f70731765ac999a. > > On the DragonBoard 820c (which uses APQ8096/MSM8996) this change causes > the CPUs to downclock to roughly half speed under sustained load. The > regression is visible both during boot and when running CPU stress > workloads such as stress-ng: the CPUs initially ramp up to the expected > frequency, then drop to a lower OPP even though the system is clearly > CPU-bound. > > Bisecting points to this commit and reverting it restores the expected > behaviour on the DragonBoard 820c - the CPUs track the cpufreq policy > and run at full performance under load. > > The exact interaction with the ACD is not yet fully understood and we > would like to keep ACD in use to avoid possible SoC reliability issues. > Until we have a better fix that preserves ACD while avoiding this > performance regression, revert the bisected patch to restore the > previous behaviour. > > Fixes: b3b274bc9d3d ("clk: qcom: cpu-8996: simplify the cpu_clk_notifier_cb") > Cc: stable@vger.kernel.org # v6.3+ > Link: https://lore.kernel.org/linux-arm-msm/20230113120544.59320-8-dmitry.baryshkov@linaro.org/ > Cc: Dmitry Baryshkov > Signed-off-by: Christopher Obbard > --- It may be that your board really has a MSM/APQ8x96*SG* which is another name for the PRO SKU, which happens to have a 2 times wider divider, try `cat /sys/bus/soc/devices/soc0/soc_id` see: https://lore.kernel.org/linux-arm-msm/20251111-db820c-pro-v1-0-6eece16c5c23@oss.qualcomm.com/ https://lore.kernel.org/linux-arm-msm/kXrAkKv7RZct22X0wivLWqOAiLKpFuDCAY1KY_KSx649kn7BNmJ2IFFMrsYPAyDlcxIjbQCQ1PHb5KaNFawm9IGIXUbch-DI9OI_l73BAaM=@protonmail.com/ Konrad