From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 515023E0C4E for ; Tue, 14 Apr 2026 14:43:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776177785; cv=none; b=MhuXijMf4TQAcB4Gqy3lloRwALQ4p9uDRQFc4HTiej5woNEdVMSu8PQSfm8VDskukOtyzwsFSstJbrnoBS21RQdxRzl3s5mMPYItW3AWkVktN1aSzXodrIYD3QQA5Tkjl8lw8uxcIuXECRyXL2Lv9qQCZgWbuW7TYOXGtHxca/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776177785; c=relaxed/simple; bh=LNjvW+h2jdKLluyul8fqI8lMeQFzuK655oXnqkx4wcI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VBnYINz6YyyJ6NAXSn59NQ6qIYLNGTllbXEXvEtwrnjOps5qALnJsKpYr6yccnMgwiZhSv6IaSDt1HlLsajF42IG5n2VuAVe8JLSRUoruoRd8MV/ljswOaSFr5mt+d8s1AOWzgi6cBUxMTwRGiC+9n3w6ez6vv0Z9fPDF625rl4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ifvB9RoR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CfUidlRk; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ifvB9RoR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CfUidlRk" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63EBU9Ce1479154 for ; Tue, 14 Apr 2026 14:43:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= oPVV3v4VLtmByB3vAduvUEcC5XOVjKu7FaDLbHcwqQ4=; b=ifvB9RoRSHnIMU2I rK5FhIddHMU8buBnI91l/ls9FQjwVZvt0op5f2EGCvjkB2AHX6khDJimGZYHcCk4 GyaV3fKHa5awMMj0Hqk67g3rjA4D5IugE6jDfBOTPqBJqcAeFLeM8jbjMdEf4dzz /A6/HMKtmU+WoJjhuJsyv6zP0QW7hA0iLEu8CL7iKuChZjy80zgdICMYhppDi/Z+ RBNanF8gczNpB6C2GJS8uiGfmBxid64eIIfQ7CoCRq4vrMlSzsG+aH+ThRQ/aYUu xuMFEIKEr1a5049FGkyUdlGoiZ4aXiFZEehgx3YJBz6qJ985iW5gvoWCgOz7Qe87 Umkh4w== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dh87j35w8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 14 Apr 2026 14:43:03 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8aca4966fe6so9647756d6.2 for ; Tue, 14 Apr 2026 07:43:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776177782; x=1776782582; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oPVV3v4VLtmByB3vAduvUEcC5XOVjKu7FaDLbHcwqQ4=; b=CfUidlRk2M5tYJxRbRZxJV743YXNV6hsJ5+STNlKRwC+ePr/4e+iO6Xfj79WR+ChUv yTeT45gKLmQQW7jDinNKxO7poW0ce4N2UMHDqzRFLiNBGIVYbLWjOh3kLO1u8uaz/5ti cml3qnSdb3b296yT8/Tze8KMw7cQg26UVn0Qd1Ggh7mhRNI6vB69Umgc3Cz/3/DOO6Ru bl7+t1T31qnLAilSjFlo7RuiMPC8aH/7/8fIDly74HhA1xRvsxGz5w0fZBAhGnEnOL5v b/AY5mZ4EcByYBvIa0Iug9EpyEziyJPhHSAyC3dxC+Bl3HRkDXs8GU24/01FL0kfWjLw vxIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776177782; x=1776782582; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oPVV3v4VLtmByB3vAduvUEcC5XOVjKu7FaDLbHcwqQ4=; b=DT39zMVS59kEVpyvvN1o/ZlIkdk0/BwxykT2OpIiy4LzXKA2heP8rcKx4A+p7Iyog1 wcqOGh5jgB+by0tJjh/Xyee9Ivgks+we64bnUpOMwIqIrHFy3LkvuZNkAxLXoM2tSRao fmDzQveUzPnP+m0n/tjRbJzkC1nmqpXWG+1uAyQCnWX1yidtkzmm2RBt9A7EbfpPtZEt gquHfCSX6gUPPjn3Vjqj499nhc1zC9zFZI8WesDXLG2R0ZvM88jt9i4iL2jkQXkwmL8q GKv3YTr8o7+czkofUnGbnGNNXxdtFSIwnpvJ4YCcaj1g28WcJpepM9YaMJmXdUCQFWA4 iUmw== X-Forwarded-Encrypted: i=1; AFNElJ/Ax3qVi39hwlbtOBKXKSZa/WvEGCwoVNMjzykW7Aj6tdth3ECGN9+p9RWiDGpb/yhIu6eV7Lvn3WpFcWM=@vger.kernel.org X-Gm-Message-State: AOJu0YwH7BBNGdV/8NO0r6C0F9HPVKLgFiWyr9b2Ymmswk8pRvwo5J2u NjF3SACQ75L99QfdroO1pUHYuhx8EE5VWI4S4ibOzHqM3abUMhzlXNOL+Er4u7IuzuuOaAnBcM7 MY8+ttHAC9tc7nUPutfwVO+2QCpg4qafZsYnfvqE8q90kkqF3GuTab8vkBEEfWsBeneU= X-Gm-Gg: AeBDietDPodwNYdQ+xI0Pq9NFQ3aKFVs9WMmZpnev8keJEpapeEebY5GNjxHEAbSODd 2xShL2iNGfHu38bJtBLGeGaoksVjARS9+4hOu25YAU0zDQPqe2Je0KXfo8Gr9mfk26sheYWk9V1 FxJzEYaKcYdZXOKbjPfIVBkYndkQHX6oi3IOTPDGNQ1GaeMbUYCsrjMmJgqxcTvuEwA5S47Cx/y /Gs9Uu/dtSYMQRwmxD4R7nwvbEay4km/hm6xP4ccD0A9aabH89wu+yp3R6ntqSgtAnDLUr7pb6W Hu/NpTMijo/+k3Icj5Km2nYj3pZY8qNqQ5n1QmN98ZpXuOU6nlkHe6mUKud8fUEO4avWJXhieFL uPVCXP/jOiv6bkbXASEY3PUkYQciEDOzRGU7x9JELdK6908ArybLDFoPO/f+nmdm9Ady5UbUIs5 p3SioAeUGWFAsnAw== X-Received: by 2002:ad4:5cae:0:b0:8ac:a797:ba39 with SMTP id 6a1803df08f44-8aca797bff7mr104569106d6.2.1776177782496; Tue, 14 Apr 2026 07:43:02 -0700 (PDT) X-Received: by 2002:ad4:5cae:0:b0:8ac:a797:ba39 with SMTP id 6a1803df08f44-8aca797bff7mr104568256d6.2.1776177781912; Tue, 14 Apr 2026 07:43:01 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9d6e5c54d5sm413465566b.41.2026.04.14.07.42.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Apr 2026 07:43:01 -0700 (PDT) Message-ID: <8d7baebc-db38-403e-b724-d4b214b5a51a@oss.qualcomm.com> Date: Tue, 14 Apr 2026 16:42:57 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/6] clk: qcom: common: ensure runtime PM suspend completes on probe To: Taniya Das , Bjorn Andersson , Michael Turquette , Stephen Boyd , Abel Vesa , Rob Clark , Sean Paul , Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter Cc: Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org References: <20260407-gfx-clk-fixes-v1-0-4bb5583a5054@oss.qualcomm.com> <20260407-gfx-clk-fixes-v1-3-4bb5583a5054@oss.qualcomm.com> <38aa8c0b-fb29-44c9-a346-363220264c7c@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <38aa8c0b-fb29-44c9-a346-363220264c7c@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: 4ae1raUN4xvbxPrqmhMxGBrlLw6B5FH9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE0MDEzOCBTYWx0ZWRfX1kXMiwePdUHu 3mrxru8hmg9bqMmqBRfFreb+bN7CKu/k7p1TRvdeNPLL9GogI/gayvonO1zlisMu2O9Se295gwB Yf6YMTXSwz93WXHYHK59kpJnsynPGrwv8io8SwlBwmqFDVad8YKxrH4s5QrG4M+KP7x/NVw6JYG MYOx15uDWEHS2GCXAtdRzdkgFXwJ5G+D43mvEpB4OlANLFt44o5YLwjS1kgxCdPNr4lIb3Qp+O5 9ea6l+eVBPaJjI0ie4SB5QZhm7QnJ3V9otjXP8EYGUJuUjeUxBZ/bZVyA2IXzZh18HAV9DWyP5p QeCA9VviWvcxsMlpg5HGPtroCRvO+kBNd/VTBSrn1Lc/GZbISC9Xv3lD3vsYB8WH0MvqiD2p9vN 8UH/e/xFehqY+7vCvUVM+U/WmtHVJcTRPmKuiWHMFsIicYAF5vsRPyHVAPZAdLFYCEDwjOzs+kw Aaw0GFoImJua/Fk8Ndw== X-Proofpoint-ORIG-GUID: 4ae1raUN4xvbxPrqmhMxGBrlLw6B5FH9 X-Authority-Analysis: v=2.4 cv=DrpmPm/+ c=1 sm=1 tr=0 ts=69de5277 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=sSUgItNeZYVuX0SKOHkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-14_03,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 adultscore=0 spamscore=0 bulkscore=0 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604140138 On 4/8/26 9:26 AM, Taniya Das wrote: > > > On 4/7/2026 4:28 PM, Konrad Dybcio wrote: >> On 4/7/26 11:30 AM, Taniya Das wrote: >>> When the clock controller is probed with 'use_rpm' enabled, the >>> runtime PM reference is currently released using pm_runtime_put(), >>> which may return before the runtime suspend has completed. This >>> can leave the power domain transition in progress while the probe >>> path continues or returns. >>> >>> Use pm_runtime_put_sync() instead to ensure the runtime PM “put” >>> completes synchronously during probe, guaranteeing the device is >>> fully runtime‑suspended before returning. >> >> It's not immediately obvious why that's an issue, is there an >> observable problem when the transition doesn't complete in time? >> >> Konrad > > > Calling pm_runtime_disable() immediately after pm_runtime_put() prevents > the runtime suspend from completing, leaving the clock controller active > and the HW rails in the ON state. Please mention that you want to do it on a clock controller device registered through this function, because currently it doesn't seem to have a functional impact on the existing paths Konrad