From: Joe Perches <joe@perches.com>
To: Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>
Cc: Andy Whitcroft <apw@canonical.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] checkpatch.pl: Allow '+' in compatible strings
Date: Tue, 14 Jul 2020 10:12:00 -0700 [thread overview]
Message-ID: <8d7ebe02cfbff19f31f6ac1ce098f98d8ba1850a.camel@perches.com> (raw)
In-Reply-To: <CAL_Jsq+c5+QFpdiNK4K=ROPAhxp=SMYS6iRFuJKooin=NbCiXw@mail.gmail.com>
On Tue, 2020-07-14 at 10:21 -0600, Rob Herring wrote:
> On Tue, Jul 14, 2020 at 3:41 AM Thierry Reding <thierry.reding@gmail.com> wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > The current checks will interpret a '+' character as special because
> > they use regular expression matching. Escape the '+' character if it
> > appears in a compatible string.
>
> Ugg, looks like c6x really liked using '+'. Might need to be added in
> schema checks, too. Not sure offhand.
These are the non alphanumeric characters used in .dts and .dtsi files
with 'compatible=' strings
- 44115
, 32035
. 1131
_ 259
+ 46
/ 18
) 5
( 5
So it looks like
"("
")"
need to be added and escaped too
?
next prev parent reply other threads:[~2020-07-14 17:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 9:41 Thierry Reding
2020-07-14 11:14 ` Joe Perches
2020-07-14 13:12 ` Thierry Reding
2020-07-14 16:21 ` Rob Herring
2020-07-14 17:12 ` Joe Perches [this message]
2020-07-14 17:42 ` Rob Herring
2020-07-15 7:22 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d7ebe02cfbff19f31f6ac1ce098f98d8ba1850a.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®