From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADABB217F5C for ; Thu, 9 Jan 2025 12:56:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736427368; cv=none; b=EBMW2acj1CXdAHO8KhJ6NkYDOzRxcZ2bM+5rDs1h+QpJvR1ciVtMYFhWc2eqc0n7kfW2ZJGSdWP6gAvvBAXvFpeAaxDPjsGQ3TVtjhmI/hAkgBfcAuFFyksoKk84M92vpbfMm3I4fSeHpp/0KTYi9UWb7lEYcKVzQ5MBg3bwCbI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736427368; c=relaxed/simple; bh=c5hC9+VtTz6kwof7J7yZQkbUh7fYmSvFsE5LwuukxFc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=d8bLUUcmmjtKppyydubUqwX4zDECNbTNbLglpTR3ka/+q0ERKmeX5+9B9699IpEMhfKQBvSNRWwg6MfGhqkvKzLPUfBGh0FkCWqL6xdw/Be5gf3KEQ/96f7YvuWLjfzv+PzKN+qC5iU64eZEj8G7PwIl2wYe2QIzrG1zqf+ocXk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ursulin.net; spf=none smtp.mailfrom=ursulin.net; dkim=pass (2048-bit key) header.d=ursulin-net.20230601.gappssmtp.com header.i=@ursulin-net.20230601.gappssmtp.com header.b=suEKhKmY; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ursulin.net Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ursulin.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ursulin-net.20230601.gappssmtp.com header.i=@ursulin-net.20230601.gappssmtp.com header.b="suEKhKmY" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4368a293339so10914295e9.3 for ; Thu, 09 Jan 2025 04:56:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ursulin-net.20230601.gappssmtp.com; s=20230601; t=1736427365; x=1737032165; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9WqY/h/bcn1twZ5Fg6im9L2+kr0LiyIHsmlOD7PpqUU=; b=suEKhKmYzHN9iUHdRguBfZQDJLmbTE4MJKp2ylAXgvegIe+RRGY/D2rQb02pRYKveL QqZ4Xrd+EVoCHzlLTIC9XJKOVSUjDs0BTiScFtONlviVd5qvlyJOsnnwcBSyWbmosDQ3 Jfge404Lyzq9LlYVfM2GNP2r3NjH0J2PhS4MRtCeOaGR1F9bjq8VZ9kSxrhdmZjNyYaG 0UZ8y4V1Pp9rN5pJrpKckgyeXLo4fAfKIXOt35jE4Ox1rTbHE+OB4iHqMOUvmi1sd63M uZ4V/26Y7K07AFS4Rksocysjbe5d/rHCgSEe0VKk8u9Nk4xHs8diH1zcevfCrhUSKihg gbaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736427365; x=1737032165; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9WqY/h/bcn1twZ5Fg6im9L2+kr0LiyIHsmlOD7PpqUU=; b=cekRbv3cvlthm3lAEaJe3XKdy1QOt+nwj+uuap+geLrL82pLmtmFb3Qsu9BJkiF/Eg enVHBTaFswAbu+wzi6T9CITmbp1Jay0c1jr2LD9R+vBIMM1/RVCApCPBwphPx+GAMrvM puAWsPdCA80tcACu0IOGaEe3kdOhNI3LEJfgyNumvy4C4rMEju91Hx9PGlcrQKFb1kHX hihCA3vjhdEJp+VrNP+3MBQJG5SfStsQpqPgTylbf5NCOLr6AQHO7XzDfg4Fyq3/Sa2q rP30+EoeieUyErg90/PEiAshzbvJ2Xk+naeMQtsaQOSv8JEw7mUSY7Gl9fq6FT71uEeQ TpYg== X-Forwarded-Encrypted: i=1; AJvYcCXgXjzvUIHaeKGJUnLNzYfJ4dS39tBF1zHpJfe+Rc52mVv5uQc5pyqNQLSlAyXEMh1MpqfSWN+E42gDjhw=@vger.kernel.org X-Gm-Message-State: AOJu0YzuG09xkrk9G9IBpKP1S1s4gzAwZQL4sRwVF3kWRJ8EN74J6RYu 0SlEkYp3THl30rGC1bbf8sh+wX4DJYOKJmRN4IDb6GCa4TvP/BArkKoCK8KeI3c= X-Gm-Gg: ASbGncuCZYScv7YCdjwrK9jj6dMu7y1l7sGU44IirIBhexgDQ/KnJpq3Ln6IYpXghZ/ REJOmrDXab1mwirbrkpojt0caVJXsq5/7SatSjqLveJagwG9/+QaJUMFIi06OMP4DEw1jBzRr2L aggZHzdy5KalYPR5zy2eRtleS1GCm8EEJTqdovnt7fP5oh4Wkak6zvoQMCSGHvh9v3sOKZyUkab 4c6GmFBELUYqXrp3b66rApfSWU0fGa2VBzYSq+FrANP2rsXCkcORpBP1KQhje8ca9wigjJs X-Google-Smtp-Source: AGHT+IHdDqdu12f2GBL1HlTu2c/FxLg9hn9Q8O0SNbAfDWrZrZZD5lDtD/M12rK8SmBmODPlL0KScg== X-Received: by 2002:a05:600c:3152:b0:434:f9e1:5cf8 with SMTP id 5b1f17b1804b1-436e271d3a2mr68776305e9.31.1736427364919; Thu, 09 Jan 2025 04:56:04 -0800 (PST) Received: from [192.168.0.101] ([90.241.98.187]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e2e89f29sm54397995e9.28.2025.01.09.04.56.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jan 2025 04:56:04 -0800 (PST) Message-ID: <8d856a0e-9226-405d-857a-35c2807e35fe@ursulin.net> Date: Thu, 9 Jan 2025 12:56:03 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/4] Documentation/gpu: Clarify format of driver-specific fidnfo keys To: =?UTF-8?Q?Adri=C3=A1n_Larumbe?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250108210259.647030-1-adrian.larumbe@collabora.com> <20250108210259.647030-2-adrian.larumbe@collabora.com> Content-Language: en-GB From: Tvrtko Ursulin In-Reply-To: <20250108210259.647030-2-adrian.larumbe@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 08/01/2025 21:02, Adrián Larumbe wrote: > This change reflects de facto usage by amdgpu, as exemplified by commit > d6530c33a978 ("drm/amdgpu: expose more memory stats in fdinfo"). > > Signed-off-by: Adrián Larumbe > Cc: Tvrtko Ursulin > --- > Documentation/gpu/drm-usage-stats.rst | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/gpu/drm-usage-stats.rst b/Documentation/gpu/drm-usage-stats.rst > index 2717cb2a597e..2b5393ed7692 100644 > --- a/Documentation/gpu/drm-usage-stats.rst > +++ b/Documentation/gpu/drm-usage-stats.rst > @@ -21,7 +21,10 @@ File format specification > > - File shall contain one key value pair per one line of text. > - Colon character (`:`) must be used to delimit keys and values. > -- All keys shall be prefixed with `drm-`. > +- All standardised keys shall be prefixed with `drm-`. > +- Driver-specific keys shall be prefixed with `driver_name-`, where > + driver_name should ideally be the same as the `name` field in > + `struct drm_driver`, although this is not mandatory. > - Whitespace between the delimiter and first non-whitespace character shall be > ignored when parsing. > - Keys are not allowed to contain whitespace characters. LGTM, thanks for documenting it! Acked-by: Tvrtko Ursulin Native english speaker maybe could clarify if s/Driver-specific/Driver specific/ would be more correct. Regards, Tvrtko