From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932326AbdAAQl3 (ORCPT ); Sun, 1 Jan 2017 11:41:29 -0500 Received: from mout.web.de ([212.227.15.4]:60709 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932079AbdAAQl2 (ORCPT ); Sun, 1 Jan 2017 11:41:28 -0500 Subject: [PATCH 5/5] staging/lustre/obdclass: Use seq_puts() in three functions To: devel@driverdev.osuosl.org, lustre-devel@lists.lustre.org, Andreas Dilger , Ben Evans , Bobi Jam , Emoly Liu , Fan Yong , Greg Kroah-Hartman , Gregoire Pichon , Henri Doreau , James Simmons , Jinshan Xiong , "John L. Hammond" , "Kirill A. Shutemov" , Lai Siyao , Oleg Drokin , Sebastien Buisson , Stephen Champion , wang di References: <45ae8939-a775-865b-ade0-9e38a7ff2b5d@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: <8d8a448c-4648-2b52-ab88-d3145f6be804@users.sourceforge.net> Date: Sun, 1 Jan 2017 17:40:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <45ae8939-a775-865b-ade0-9e38a7ff2b5d@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:JGcmj+vANwycoGsBYOCSpULlw5qaB+bLb2+3cIulpJnUopFM1oy YPMPIOgx9v94bD80JGSaTfFRTshbfSp9+DLRcmr7Qq4SxGP5k8vMX0rfREk74aV7tHI+BzL tLB0CE/pcX1JSjBbiFP/vKG8je0/FmrVXynSZW7DO1z7IZu8xXJegQ5dfDCRuMvtgBkyWI7 JcJA+9nQHoVpnqo77pZFg== X-UI-Out-Filterresults: notjunk:1;V01:K0:DJNTbW1Y+Ik=:DJLYGPgDG6oVFc3ROFh4/M CnlpFzMjuVCj7SpnjIygEkXjJoImtG5uR6BOhIB+3QuHK8449fzBlfbMnpz8rYNGGG0xqhvXB hzROqHrhgaRFcCSBhSOTBxZqy4oH0g40TTaYwbkJRAhZKpX7fP8ghp5i4EW4kRh5pszoDwEGP YnbXa6HkuulgnKiBJsNslYdiHLqC5+5Z9dgTsXfniZrBbXzIVJqsr/Kb/ZQ3Go2IaIAE0e3Gk NsnyhQALE96y64dtMH/kc3CYJ+mewZRkNSbtMFeKubuSYSVrxTVdOGIlWrGBqSlK/vDhF87my AG48nQPhVVse4EFuT9eM7jc8CfCYD/EzbhZqFCvSJzIBAVEdIsQYv0ppChI99ufQvj0xWXGRD P+cIxg2Js4RODriET2H9wopCIZwl5fQDTRcvymotCzclO7VqCIw+MK8suBqxQwOPrfu4cQz90 KfzHUXBFFSqU0b2VGcwPKgpISDuzTNyP5RJNmuf+a1k00NpHAJ36wiqweFVGAOxti84XelCI8 l7g86l3dIGAWkCnsqQfe+1Pg6nAglzV4higAIUwyeFBno/hNoTGoJEn7mHsn8W1Xw2ehSVsIb 1tPBo+ITwXmMD2MzsbK4tzIaVKRS4QuiQ4ML7vG17bujUYKV+TzSShnyYIaIJHnrSqmH9d/kL WjlO5PXuG2M27qfOLRYorqQ4X4R1xOJ3EmtxagQugw7iWiNZtBZqFqdTl6WKexj1jUC378lVZ 0NcWQruB2xsXf6ckQggdaQumnU4TzdydqFuOm8aEVFGl4mYNbgdMq4bcwFywvrXNa1h7TdCRk D+4Aq3a Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 1 Jan 2017 16:45:32 +0100 A string which did not contain a data format specification should be put into a sequence. Thus use the corresponding function "seq_puts" so that the data output will be a bit more efficient in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/staging/lustre/lustre/obdclass/cl_object.c | 4 ++-- drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 15 +++++++-------- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/cl_object.c b/drivers/staging/lustre/lustre/obdclass/cl_object.c index 277908d66a89..3e00aa4747b8 100644 --- a/drivers/staging/lustre/lustre/obdclass/cl_object.c +++ b/drivers/staging/lustre/lustre/obdclass/cl_object.c @@ -510,11 +510,11 @@ locks: ...... ...... ...... ...... ...... [...... ...... ...... ...... ......] */ lu_site_stats_print(&site->cs_lu, m); cache_stats_print(&site->cs_pages, m, 1); - seq_printf(m, " ["); + seq_puts(m, " ["); for (i = 0; i < ARRAY_SIZE(site->cs_pages_state); ++i) seq_printf(m, "%s: %u ", pstate[i], atomic_read(&site->cs_pages_state[i])); - seq_printf(m, "]\n"); + seq_puts(m, "]\n"); cache_stats_print(&cl_env_stats, m, 0); seq_putc(m, '\n'); return 0; diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c index a167cbe8a50e..3ce590cdd957 100644 --- a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c +++ b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c @@ -649,7 +649,7 @@ static int obd_import_flags2str(struct obd_import *imp, struct seq_file *m) bool first = true; if (imp->imp_obd->obd_no_recov) { - seq_printf(m, "no_recov"); + seq_puts(m, "no_recov"); first = false; } @@ -715,15 +715,14 @@ int lprocfs_rd_import(struct seq_file *m, void *data) imp->imp_connect_data.ocd_instance); obd_connect_seq_flags2str(m, imp->imp_connect_data.ocd_connect_flags, ", "); - seq_printf(m, " ]\n"); + seq_puts(m, " ]\n"); obd_connect_data_seqprint(m, ocd); - seq_printf(m, " import_flags: [ "); + seq_puts(m, " import_flags: [ "); obd_import_flags2str(imp, m); - - seq_printf(m, - " ]\n" - " connection:\n" - " failover_nids: [ "); + seq_puts(m, + " ]\n" + " connection:\n" + " failover_nids: [ "); spin_lock(&imp->imp_lock); j = 0; list_for_each_entry(conn, &imp->imp_conn_list, oic_item) { -- 2.11.0