From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932712AbdEVCac (ORCPT ); Sun, 21 May 2017 22:30:32 -0400 Received: from regular1.263xmail.com ([211.150.99.130]:42508 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756695AbdEVCa3 (ORCPT ); Sun, 21 May 2017 22:30:29 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: frank.wang@rock-chips.com X-FST-TO: wmc@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: frank.wang@rock-chips.com X-UNIQUE-TAG: <9008506fc7e1d9725bf6a838e7f4eb28> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 From: Frank Wang Subject: Re: [PATCH v2 3/4] arm: dts: rk3229: add a new cpu opp table To: Heiko Stuebner Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, mturquette@baylibre.com, sboyd@codeaurora.org, rjw@rjwysocki.net, viresh.kumar@linaro.org, rui.zhang@intel.com, edubezval@gmail.com, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, charles.chen@rock-chips.com, cody.xie@rock-chips.com, kevan.lan@rock-chips.com, huangtao@rock-chips.com, rocky.hao@rock-chips.com, finley.xiao@rock-chips.com, zhangqing@rock-chips.com, wmc@rock-chips.com References: <1495016177-2413-1-git-send-email-frank.wang@rock-chips.com> <1495016177-2413-4-git-send-email-frank.wang@rock-chips.com> <3157044.sksXPZM55k@phil> Message-ID: <8d8af44c-353a-5415-ed15-ccc68db81159@rock-chips.com> Date: Mon, 22 May 2017 10:29:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <3157044.sksXPZM55k@phil> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko, On 2017/5/20 5:46, Heiko Stuebner wrote: > Hi Frank, > > Am Mittwoch, 17. Mai 2017, 18:16:16 CEST schrieb Frank Wang: >> From: Finley Xiao >> >> This patch adds some new frequencies for rk3229 board. >> >> Signed-off-by: Finley Xiao >> Signed-off-by: Frank Wang >> Acked-by: Viresh Kumar >> --- >> arch/arm/boot/dts/rk3229-cpu-opp.dtsi | 85 +++++++++++++++++++++++++++++++++++ > I'm not yet sure if I like that approach. The other option I'm considering > and also tend to prefer at the moment would be to have this in a > rk3229.dtsi, creating a chain of > rk322x.dtsi > \- rk3228-evb.dts > \- rk3229.dtsi > \- rk3229-evb.dts > > similar to what we do with the rk3xxx.dtsi -> rk3188.dtsi. > > If I remember correctly, there are some other tiny differences between the > rk3228 and rk3229, so having the rk3229.dtsi already would make it > easier to place needed stuff into it later on. That makes sense, I will amend that based on your comments. BR. Frank > Heiko > >> 1 file changed, 85 insertions(+) >> create mode 100644 arch/arm/boot/dts/rk3229-cpu-opp.dtsi >> >> diff --git a/arch/arm/boot/dts/rk3229-cpu-opp.dtsi b/arch/arm/boot/dts/rk3229-cpu-opp.dtsi >> new file mode 100644 >> index 0000000..89e8413 >> --- /dev/null >> +++ b/arch/arm/boot/dts/rk3229-cpu-opp.dtsi >> @@ -0,0 +1,85 @@ >> +/* >> + * Copyright (c) 2017 Fuzhou Rockchip Electronics Co., Ltd >> + * >> + * This file is dual-licensed: you can use it either under the terms >> + * of the GPL or the X11 license, at your option. Note that this dual >> + * licensing only applies to this file, and not this project as a >> + * whole. >> + * >> + * a) This library is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU General Public License as >> + * published by the Free Software Foundation; either version 2 of the >> + * License, or (at your option) any later version. >> + * >> + * This library is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * Or, alternatively, >> + * >> + * b) Permission is hereby granted, free of charge, to any person >> + * obtaining a copy of this software and associated documentation >> + * files (the "Software"), to deal in the Software without >> + * restriction, including without limitation the rights to use, >> + * copy, modify, merge, publish, distribute, sublicense, and/or >> + * sell copies of the Software, and to permit persons to whom the >> + * Software is furnished to do so, subject to the following >> + * conditions: >> + * >> + * The above copyright notice and this permission notice shall be >> + * included in all copies or substantial portions of the Software. >> + * >> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, >> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES >> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND >> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT >> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, >> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING >> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR >> + * OTHER DEALINGS IN THE SOFTWARE. >> + */ >> + >> +/ { >> + /delete-node/ opp-table0; >> + >> + cpu0_opp_table: opp_table0 { >> + compatible = "operating-points-v2"; >> + opp-shared; >> + >> + opp-408000000 { >> + opp-hz = /bits/ 64 <408000000>; >> + opp-microvolt = <950000>; >> + clock-latency-ns = <40000>; >> + opp-suspend; >> + }; >> + opp-600000000 { >> + opp-hz = /bits/ 64 <600000000>; >> + opp-microvolt = <975000>; >> + }; >> + opp-816000000 { >> + opp-hz = /bits/ 64 <816000000>; >> + opp-microvolt = <1000000>; >> + }; >> + opp-1008000000 { >> + opp-hz = /bits/ 64 <1008000000>; >> + opp-microvolt = <1175000>; >> + }; >> + opp-1200000000 { >> + opp-hz = /bits/ 64 <1200000000>; >> + opp-microvolt = <1275000>; >> + }; >> + opp-1296000000 { >> + opp-hz = /bits/ 64 <1296000000>; >> + opp-microvolt = <1325000>; >> + }; >> + opp-1392000000 { >> + opp-hz = /bits/ 64 <1392000000>; >> + opp-microvolt = <1375000>; >> + }; >> + opp-1464000000 { >> + opp-hz = /bits/ 64 <1464000000>; >> + opp-microvolt = <1400000>; >> + }; >> + }; >> +}; >> > > >