From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89E6CC64EB8 for ; Tue, 9 Oct 2018 17:14:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4FC15214DA for ; Tue, 9 Oct 2018 17:14:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="ebfBDfF7"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="QT56NczK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4FC15214DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727056AbeJJAcq (ORCPT ); Tue, 9 Oct 2018 20:32:46 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:37992 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726393AbeJJAcp (ORCPT ); Tue, 9 Oct 2018 20:32:45 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id E1E9660BFA; Tue, 9 Oct 2018 17:14:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1539105287; bh=7k4SU6nX56XaFWFWgYQR4sHzhozy9/N9GTlKc6Gi0ns=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=ebfBDfF722vVlsAfh7ew2bMqdS/aisBC4zz44qiHsZVyoWDAQH3JRYWSr7Cx5X8/C 4HHDm3AEGOfeOYbv/hiYg8FH96PJDqvI258cByUMxNqB1DIa19OtuapEjnP9fWi9+5 ZRy+Z/aSmQ7V5L7Ic0aqa0ebp5lThCGKdxGy+ynI= Received: from [10.226.60.81] (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jhugo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 137D36083C; Tue, 9 Oct 2018 17:14:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1539105286; bh=7k4SU6nX56XaFWFWgYQR4sHzhozy9/N9GTlKc6Gi0ns=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=QT56NczKjg7nWc4KoiBRmm3v++/ec3+jk1jiskn6/yCwIKEkdoBdm5eK/00Sm9xTD 5GkAhR8tlahaAEifmx3I49f9on5No/UTX+hfj2P8hXQ+WrjcS3PWJ6uAYWD0IUJXky 93mblU42SL653/S0ugV6MQf3i1lp9QmnsLWofMKY= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 137D36083C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=jhugo@codeaurora.org Subject: Re: [PATCH v5 3/3] gpiolib: Show correct direction from the beginning To: Timur Tabi Cc: Ricardo Ribalda Delgado , Linus , Stephen Boyd , linux-gpio , lkml References: <20181005065300.22882-1-ricardo.ribalda@gmail.com> <20181005065300.22882-3-ricardo.ribalda@gmail.com> <8d10f9b4-7ea9-7d27-478a-39982ba49587@codeaurora.org> From: Jeffrey Hugo Message-ID: <8d8c1aca-c194-c473-3906-c0e7d4a0d0c8@codeaurora.org> Date: Tue, 9 Oct 2018 11:14:44 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/5/2018 10:54 AM, Timur Tabi wrote: > On 10/05/2018 11:17 AM, Jeffrey Hugo wrote:> >> Looks like the driver is initing just fine to me. Is setting up the >> jumpers and running gpio-test warranted? > > Well, that test only makes sure that input/output is actually working > on the hardware level, but it also makes sure that the GPIOs are > numbered correctly. > > If you want, just put a printk(... offset) in msm_gpio_get() and read > from a GPIO that you know you have access to, and make sure the > 'offset' is correct. > > Then try reading from a GPIO that you don't have access to, and make > sure you get a failure before msm_gpio_get() is called. > Done. For the series: Tested-by: Jeffrey Hugo -- Jeffrey Hugo Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.