From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3591C433E3 for ; Mon, 22 Mar 2021 21:03:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7330C619A4 for ; Mon, 22 Mar 2021 21:03:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230295AbhCVVCp (ORCPT ); Mon, 22 Mar 2021 17:02:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230205AbhCVVCZ (ORCPT ); Mon, 22 Mar 2021 17:02:25 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57393C061574 for ; Mon, 22 Mar 2021 14:02:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=bTj1fQ9fYW66hAFvO+t7qXJwHkz88wxrOfFnQIj+YSI=; b=aH4hRdFYJq5dTGzzvV43YXHLGo paRm4PI4M9qZv2r64b7TcvyvOrO9uvENJyGdjjxBBV+H2kaJBLf+NC3O5UgbEILnLqiecVjY3G7Ly ofUbNdML1xcuhxsIQ+Jz004pqGdUBokr/B7IgQTrccvzXELA+dC0kRQ8KX7nOsjxXqN6CsWB4jvIc qSFrk2UODgFPhs7RiNpOPZv3l1DxR6RNgta3TJMfj4vknorkBan8Vmdy/kBx2KD5RyL0JwxI0hMh+ 1TlX/DCD9OfiStDHNPtY15jjPQcvkQ13vC4oj6CI1iGTY0UuQ/050dko5rv4abv68EsgovsH0bl3g rZrST0kA==; Received: from [2601:1c0:6280:3f0::3ba4] by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lORgf-0094q3-D7; Mon, 22 Mar 2021 21:02:10 +0000 Subject: Re: [PATCH] mm: Fix typos in comments To: Ingo Molnar Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Rik van Riel References: <20210322025152.GA1922846@gmail.com> <1c098463-9db9-372f-82ba-48a12849707f@infradead.org> <20210322205016.GA1959563@gmail.com> From: Randy Dunlap Message-ID: <8d8dbd68-e53d-9043-17b7-af0d44ab0075@infradead.org> Date: Mon, 22 Mar 2021 14:02:06 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210322205016.GA1959563@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/22/21 1:50 PM, Ingo Molnar wrote: > > * Randy Dunlap wrote: > >> On 3/21/21 7:51 PM, Ingo Molnar wrote: >>> >>> Fix ~93 single-word typos in locking code comments, plus a few very >>> obvious grammar mistakes. >>> >>> Signed-off-by: Ingo Molnar >>> Cc: Andrew Morton >>> Cc: Rik van Riel >>> Cc: linux-mm@kvack.org >>> Cc: linux-kernel@vger.kernel.org >>> --- >>> include/linux/mm.h | 2 +- >>> include/linux/vmalloc.h | 4 ++-- >>> mm/balloon_compaction.c | 4 ++-- >>> mm/compaction.c | 2 +- >>> mm/filemap.c | 2 +- >>> mm/gup.c | 2 +- >>> mm/highmem.c | 2 +- >>> mm/huge_memory.c | 4 ++-- >>> mm/hugetlb.c | 4 ++-- >>> mm/internal.h | 2 +- >>> mm/kasan/kasan.h | 8 ++++---- >>> mm/kasan/quarantine.c | 4 ++-- >>> mm/kasan/shadow.c | 4 ++-- >>> mm/kfence/report.c | 2 +- >>> mm/khugepaged.c | 2 +- >>> mm/kmemleak.c | 2 +- >>> mm/ksm.c | 4 ++-- >>> mm/madvise.c | 4 ++-- >>> mm/memcontrol.c | 18 +++++++++--------- >>> mm/memory-failure.c | 2 +- >>> mm/memory.c | 12 ++++++------ >>> mm/mempolicy.c | 4 ++-- >>> mm/migrate.c | 8 ++++---- >>> mm/mmap.c | 4 ++-- >>> mm/mprotect.c | 2 +- >>> mm/mremap.c | 2 +- >>> mm/oom_kill.c | 2 +- >>> mm/page-writeback.c | 4 ++-- >>> mm/page_alloc.c | 14 +++++++------- >>> mm/page_owner.c | 2 +- >>> mm/page_reporting.c | 2 +- >>> mm/percpu-internal.h | 2 +- >>> mm/percpu.c | 2 +- >>> mm/pgalloc-track.h | 6 +++--- >>> mm/slab.c | 8 ++++---- >>> mm/slub.c | 10 +++++----- >>> mm/swap_slots.c | 2 +- >>> mm/swap_state.c | 2 +- >>> mm/swapfile.c | 4 ++-- >>> mm/util.c | 2 +- >>> mm/vmalloc.c | 8 ++++---- >>> mm/vmstat.c | 2 +- >>> mm/zpool.c | 2 +- >>> mm/zsmalloc.c | 2 +- >>> 44 files changed, 93 insertions(+), 93 deletions(-) >> >>> diff --git a/mm/compaction.c b/mm/compaction.c >>> index e04f4476e68e..048686fba230 100644 >>> --- a/mm/compaction.c >>> +++ b/mm/compaction.c >>> @@ -1977,7 +1977,7 @@ static unsigned int fragmentation_score_wmark(pg_data_t *pgdat, bool low) >>> unsigned int wmark_low; >>> >>> /* >>> - * Cap the low watermak to avoid excessive compaction >>> + * Cap the low watermark to avoid excessive compaction >>> * activity in case a user sets the proactivess tunable >> >> proactiveness >> ? > > Yeah, agreed that it's probably the intent there. Fixed. > >>> * @flags: the fault flags. >>> * @ret: the fault retcode. >>> * >>> - * This will take care of most of the page fault accountings. Meanwhile, it >>> + * This will take care of most of the page fault accounting. Meanwhile, it >>> * will also include the PERF_COUNT_SW_PAGE_FAULTS_[MAJ|MIN] perf counter >>> * updates. However note that the handling of PERF_COUNT_SW_PAGE_FAULTS should >> >> However, > > Fixed. > >>> * still be in per-arch page fault handlers at the entry of page fault. >>> diff --git a/mm/page_reporting.c b/mm/page_reporting.c >>> index c50d93ffa252..8b9197074632 100644 >>> --- a/mm/page_reporting.c >>> +++ b/mm/page_reporting.c >>> @@ -86,7 +86,7 @@ page_reporting_drain(struct page_reporting_dev_info *prdev, >>> continue; >>> >>> /* >>> - * If page was not comingled with another page we can >>> + * If page was not commingled with another page we can >> >> Either spelling seems to be acceptable. > > Indeed! I've reverted this. > >>> * to local caches without needing to acquire swap_info >>> * lock. We do not reuse the returned slots directly but >>> * move them back to the global pool in a batch. This >>> - * allows the slots to coaellesce and reduce fragmentation. >>> + * allows the slots to coalescence and reduce fragmentation. >> >> to coalesce > > erm, yes. Fixed. > >>> * >>> * The swap entry allocated is marked with SWAP_HAS_CACHE >>> * flag in map_count that prevents it from being allocated >> >> >> Mostly looks like a good, big cleanup. Thanks. > > New version attached. Can I add your Reviewed-by? Sure. Reviewed-by: Randy Dunlap Thanks. > Thanks, > > Ingo > > ===================================> > From: Ingo Molnar > Date: Mon, 22 Mar 2021 03:40:12 +0100 > Subject: [PATCH] mm: Fix typos in comments > > Fix ~94 single-word typos in locking code comments, plus a few > very obvious grammar mistakes. > > Signed-off-by: Ingo Molnar > Reviewed-by: Matthew Wilcox (Oracle) > Cc: Linus Torvalds > Cc: Andrew Morton > Cc: Rik van Riel > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > --- > include/linux/mm.h | 2 +- > include/linux/vmalloc.h | 4 ++-- > mm/balloon_compaction.c | 4 ++-- > mm/compaction.c | 4 ++-- > mm/filemap.c | 2 +- > mm/gup.c | 2 +- > mm/highmem.c | 2 +- > mm/huge_memory.c | 6 +++--- > mm/hugetlb.c | 6 +++--- > mm/internal.h | 2 +- > mm/kasan/kasan.h | 8 ++++---- > mm/kasan/quarantine.c | 4 ++-- > mm/kasan/shadow.c | 4 ++-- > mm/kfence/report.c | 2 +- > mm/khugepaged.c | 2 +- > mm/kmemleak.c | 2 +- > mm/ksm.c | 4 ++-- > mm/madvise.c | 4 ++-- > mm/memcontrol.c | 18 +++++++++--------- > mm/memory-failure.c | 2 +- > mm/memory.c | 14 +++++++------- > mm/mempolicy.c | 4 ++-- > mm/migrate.c | 8 ++++---- > mm/mmap.c | 4 ++-- > mm/mprotect.c | 2 +- > mm/mremap.c | 2 +- > mm/oom_kill.c | 2 +- > mm/page-writeback.c | 4 ++-- > mm/page_alloc.c | 14 +++++++------- > mm/page_owner.c | 2 +- > mm/percpu-internal.h | 2 +- > mm/percpu.c | 2 +- > mm/pgalloc-track.h | 6 +++--- > mm/slab.c | 8 ++++---- > mm/slub.c | 10 +++++----- > mm/swap_slots.c | 2 +- > mm/swap_state.c | 2 +- > mm/util.c | 2 +- > mm/vmalloc.c | 8 ++++---- > mm/vmstat.c | 2 +- > mm/zpool.c | 2 +- > mm/zsmalloc.c | 2 +- > 42 files changed, 94 insertions(+), 94 deletions(-) -- ~Randy