From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E80ED230264 for ; Sun, 25 Jan 2026 09:09:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769332165; cv=none; b=r3zhuG+yB0On0jRThMfNxThD4ORdsjQS+hzvtdvna1BptS974hsZx7Z8wDl0ioIToaYmPQMB0Sc+dsQHj4wnzbaMCI5H9h2f+2ID3d7Idr2zOKGv2/ROjSPe8QM7ccJBSGrA9IjnaGTkfpW0GNUhabkwjow5oJXxVMAmrP+DEds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769332165; c=relaxed/simple; bh=vs6rIBpxHNi/kQTJxSvAM2ZIW80NOb5n5z14ZKbf/qk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=a+MIilop4yAgXAGrXupLvd5b3f2vZJnAxswRGw7Sb0gK0SD3oekQljFwFkUDEUUaLpUZU25M5OFGgCupFblLpZfDWxYifC584XbBWtwLj/2Y4cn0D2vW1gaEfC1baop8HXE7nvAInJD5sjdZgc4aIG+ziBi5bJML8UDHXE+GzJk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CQU7EdRD; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CQU7EdRD" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-47ee974e230so31869695e9.2 for ; Sun, 25 Jan 2026 01:09:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769332162; x=1769936962; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=31O2eYXcVuLapO5Zw/zgNNvFpdLcpA1gw2dP7RI+fXE=; b=CQU7EdRDMGDxAvOi6LyCZF7BADxvMnujevFAfgxTsmtP19lYDjNxSdEjDDI90ORCdV G1EJH6s5AML9NGiCU7JXAOT0+bobJF0DjCxgKDr0YDblmXh0YXOkmPmm73kuBi39ANTO b4jvlN2rGGT4IMBuusMDSUjXomM14moa5s59tLSUPBWmpru2q8khAhQYqjVE/0gFAaFt inUA/AgU4bVUKp3iyguSP0IwUhc2/n2g3oT8lUhViSlx3MOcpFefaYUDdn8ZxV8KMkSL lSN1nX1GbdrKh/8M6zFiA3I+/1FXgG/qkfNcJ1/9kQDec6oalH23Y3dSuVqJqmEMU9Gr T/ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769332162; x=1769936962; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=31O2eYXcVuLapO5Zw/zgNNvFpdLcpA1gw2dP7RI+fXE=; b=Erxc0OPRZQ8+XTlP5TE4xX9eK5iFrG1aRM0xdFmIcIZTNd8n02sBkrsX0cb102SHuh o+gDtLUhtyJI9EouPYe55MWLQNJVRtSqLdjtSJBx0c3NnlreU2VOiZeEaqGnpMLCU9Hu PqwD43m5qpraDnh7NvAXICC3k4+W29Ywg48+5/8H4Crsy6m9NKq1raFCTwFTpxIlMdpm H1HZIg4lViDVhfPsY9sqdDs5XDNjk09Dr5Hq4fyDaAU+awUK4wlFFQnVchVs+ON/F/j3 3Xpu6oIsY2m16qb8a2VAUJrJP84n6A907y6vU9wJDW3gIrGuY+vk3013PYa8ADuAvhc/ awJw== X-Forwarded-Encrypted: i=1; AJvYcCVOI4e6AYROm63DPin/gSiOL0DAzxzQ6ads5JDxAf9OtsgJ3cGQ2yGYPYwfxU8Fg4sz53jSrOrt342l9mY=@vger.kernel.org X-Gm-Message-State: AOJu0YzP0zAK62qfL3Gmfc6LTl1TtffkJ+NZhkhgW8hEpwzdQh31yIDI dvnd6s6ZAPK923Ys4XSEKfjFYEfMyVymm/L8FPui6JNHMER51oWFONuz X-Gm-Gg: AZuq6aI/QEXx5H1uIXkofEMK518GZJlWOzZjvU3BX0GRUAQdgiDZdyOjn//MweShZNm UZFo6ZMzKd5GCSIJTQ5o6WIdStHwGrpckK8mIH7/nyxHqeRyxFx01ofA3F1D/v3CFIckD+8Qr63 0WAx7fQ75vnUGKcGgfdMXOpUsAafV/4sNCTFFXgLSHTSizY/VwOnaMR1vKadYBmOVPmbdJa3IB7 gW/zGEByGRk295MNef+zKAGhxW0pFxQVdTSG6a8nwaAFs+gcCXfSqHzRAGBm/6HfCaXZWG+73XT eJGd8uv5zuaWoRr1IOQ1m24kOF9mtLpczHunLPp0oKmqIjE4bxb9hQWDFIBWqk8nJBBl9YmppEZ gLdJ9qPxHGTYThaxFMtmpb/5JT4fGOsTlmkvgpxxsrz/1RYc7DiBaAZRsp3XQprZG8WdEsdKkLN XNLVgwtw21D6sVRFgBlxHcaE4D5N/zriR302kbHOczXnsGoA70//hW0sTaXtRpWsdqrtXMjc4SO SJLOiJDRuV+DywBQFuiTs7/POGOh0dCmVJj9lIoaf0= X-Received: by 2002:a05:600c:c04b:10b0:46e:4e6d:79f4 with SMTP id 5b1f17b1804b1-4805dd3722bmr10472735e9.15.1769332162004; Sun, 25 Jan 2026 01:09:22 -0800 (PST) Received: from ?IPV6:2003:df:bf2d:e300:e4b8:a0ef:f9fc:d01? (p200300dfbf2de300e4b8a0eff9fc0d01.dip0.t-ipconnect.de. [2003:df:bf2d:e300:e4b8:a0ef:f9fc:d01]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48046fba46dsm263939945e9.0.2026.01.25.01.09.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Jan 2026 01:09:21 -0800 (PST) Message-ID: <8d930ac7-11b1-437b-be18-7a785f20a72f@gmail.com> Date: Sun, 25 Jan 2026 10:09:19 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/5] gpu: nova-core: use checked arithmetic in FWSEC firmware parsing To: Joel Fernandes , linux-kernel@vger.kernel.org, Danilo Krummrich , Alexandre Courbot , Alice Ryhl , David Airlie , Simona Vetter Cc: John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , Zhi Wang , Bjorn Helgaas , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org References: <20260124231830.3088323-1-joelagnelf@nvidia.com> <20260124231830.3088323-2-joelagnelf@nvidia.com> Content-Language: de-AT-frami, en-US From: Dirk Behme In-Reply-To: <20260124231830.3088323-2-joelagnelf@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Joel, On 25.01.26 00:18, Joel Fernandes wrote: > Use checked_add() and checked_mul() when computing offsets from > firmware-provided values in new_fwsec(). > > Without checked arithmetic, corrupt firmware could cause integer overflow. The > danger is not just wrapping to a huge value, but potentially wrapping to a > small plausible offset that passes validation yet accesses entirely wrong data, > causing silent corruption or security issues. > > Signed-off-by: Joel Fernandes > --- > drivers/gpu/nova-core/firmware/fwsec.rs | 60 ++++++++++++++----------- > 1 file changed, 35 insertions(+), 25 deletions(-) > > diff --git a/drivers/gpu/nova-core/firmware/fwsec.rs b/drivers/gpu/nova-core/firmware/fwsec.rs > index a8ec08a500ac..1a91bbbce3d5 100644 > --- a/drivers/gpu/nova-core/firmware/fwsec.rs > +++ b/drivers/gpu/nova-core/firmware/fwsec.rs > @@ -46,10 +46,7 @@ ... > @@ -356,8 +362,12 @@ pub(crate) fn new( > // Patch signature if needed. > let desc = bios.fwsec_image().header()?; > let ucode_signed = if desc.signature_count() != 0 { > - let sig_base_img = > - usize::from_safe_cast(desc.imem_load_size() + desc.pkc_data_offset()); > + // Compute sig_base_img = desc.imem_load_size + desc.pkc_data_offset. Nit: Drop `desc.` to make it consistent with the other comments. Best regards Dirk