From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B020305971 for ; Tue, 18 Nov 2025 07:35:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763451340; cv=none; b=CbzCC2CQfoAK2anqgBv0dP0/mKVWe4UtdXMa9JZkbQTl46edtStzuTwR24YIAcGMVzqYhxopNX93VjLby+JI8WOWxjuisKQ/6neUbXWhPEHmIKitCqefcV7IeZJPFTtOL5AUKQsYHZbdEKW0ZC8VL8XzL0SK8t5e8GrHFPwO4QA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763451340; c=relaxed/simple; bh=Od+8mqK9gUz5h8V4K8u0Dd8wlB1sQmBPXJ0pymplXS4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hSeN6e+QKSHjykvYb3clQE1xZ3SUCeYw8lnuCXtz9mLDYq5ggtPqH+iy3865VbMOYcz0I8qvmEwfky5esUTpcuvMkS0/DH1dEpaWUvcXKghfT+MZ6BrTSi5NTTXiNhuVIK8kjowCCnm1es/f0GjkTnrHfvf/r/jz7HkPp3fSa2Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QYIWN+iU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MH/2qQUw; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QYIWN+iU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MH/2qQUw" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AI1OaOR4168202 for ; Tue, 18 Nov 2025 07:35:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2Yq8woC8pgbQ3SOPgqnbBsipou8bq9JW5nKurx51oso=; b=QYIWN+iUuJNGbqN4 oatlEUbyw73N9pN68K47xoblc8nwtDTSX8bptoCYdafw8L0dHJ4yeWaswlW+FVGX ZFe8vVMBHNjmxydQhbctYLoOSoU8IjuStEkoAEFhD19veTeXWNmdJWLQmgI0rmHA RxOyvjJzr6PJLtEp9c9/bMNAX3dDn3jOGPhU2VmoK+Ku/Q7jCIjiKLnsDAVXfx2Q cMA5bYpcv1gTxdg842Bjjm79Hw9y191RxUlROYp6BaAZSeeLASnL7GTflNE7/aHx 9f7u2ndwnom2hienlImWeX3c7atKuiN30qcZvDDOlPN77iFfISstadrs8WFKWmb8 fse3pw== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ag593tn9g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 18 Nov 2025 07:35:36 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-345b4f2a8e8so243341a91.1 for ; Mon, 17 Nov 2025 23:35:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763451336; x=1764056136; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2Yq8woC8pgbQ3SOPgqnbBsipou8bq9JW5nKurx51oso=; b=MH/2qQUwZ942KKCtM/IJdJHLR8JvDWGcraU4r1hb+G5HaIl7rvbczYI5qzd/qzJpJB H048uA1FrX0M29Lxn53nDVEpm7jf4ysue4NN7lkl6KVRQgSEZQhr8kSm2EisrQRMRMXK 0upFVQadTMWkWu2PRLCusEjj++lplkhOcBZ/lOW2g2POa89AGWq8qtQdRi9WpKK+q/Y1 UtKpFKPRHGrm7UpagAfTA462jGi9L2jBnZccjC+wnhEDmAIP+1WAOMvofj6xHhGx829/ hcO0oOCv5IFLmr1eDWHRyyOkAyKCQhowXGIGD1upW+4E//m7ov2GdIs1H0Lfw/d3SAwz Nvgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763451336; x=1764056136; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2Yq8woC8pgbQ3SOPgqnbBsipou8bq9JW5nKurx51oso=; b=jr+fjv7aFhsqP4361EavD1yKqJoaPN9Cq5YZimotV8BPL9st5gFmxXHPAdH/66p0vz OF8nxoFOfzfGfzy81KHtrj9PHM46MH/wQgztSK1R/KfuanS22gkBvTtAQMLFdfXdbrOY HPgJNMnW2p918MMDy9Aqh4W9Bc/USrdVRlGDxNlEU4muUqJi3yWxAeasQMN9pYWH7JFT g+F3IBCX8eGR1WfdE/yV7JgO1XnbLNkIrdP0I+yMCNtoyFru71p8a73o45j5vgjG142W x4Pn7x/ZLNSLpTx8MqekTcOrZFx37yYpbLsgFZ7pdEgjug/f8wKpYJX6CrB7uQ9oDKv3 CHOw== X-Forwarded-Encrypted: i=1; AJvYcCWybcRcEcLh9lnvDq+0rlIzvozkOI/vRcmfXlu8KfIn/ZP35RnteRDK8ts3vAGKuKd76imGJMqWQu9Pzec=@vger.kernel.org X-Gm-Message-State: AOJu0YxCebFZnztF4Hd7nlOkCEaoTEjyR2QeWHhYhaS/TqU7ZXwwb1vl VuuKPVxMWuDRObz+bf6OlI1Z8wQZiWoHI63vqHzCbwATktCujCe61POnuMGdg0ERseUHy35N+Dn 8sNU89PlYfpUe4t5R3iagZZDAND5EnSNHgLiaW8thJl6PFZ5xxcs3FAgPH9+x8vTczh0= X-Gm-Gg: ASbGncu1hMvDU5jipaA86qhCOIpdD0DrH7QvCxTbZ+ht5avU3gt3YwlTN4+lIfeQeCZ haLw5rWb3uOamBOnuVZuNLj6NTrbf65n1XxyrsdKyhUAgPRzfR8a8ijrZArxQ+ra1CJU8rcFqkx tPO5hMrhmZ4H9iyqwWkBbiw1yM5O+KHYf+WysdVLsQ9ja+YV3tt423ZepjEHJWqDIv9kSEAiPx/ YJ/NZzhmY7i61b6uYnBRPjSUDvW+Fb5AGBhZFz0Hmhzt2+06Sn7sMN0gEKOkR2qYPnfxvAikjUy P8UiO3rYNCFKpRK3Rl1NgXeek6lE2yws1HMwJPB8hKkpoy/NhQlECurPqrLvIfM4XyOi0RSMQSW myPJymZEsQQ/czFdSREsF14KULRye/J69y9txr0L2hkBROWEBV+S7h7P7SAI+ X-Received: by 2002:a17:90b:5405:b0:340:a961:80c9 with SMTP id 98e67ed59e1d1-343fa74b8a5mr16652642a91.30.1763451336265; Mon, 17 Nov 2025 23:35:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IFBoN0HzW8pQq/whBUvfkVN5aiUXblrVdghEnXtwzRxzuYGPyg1BqfuJZkOol16XFTb66lVSg== X-Received: by 2002:a17:90b:5405:b0:340:a961:80c9 with SMTP id 98e67ed59e1d1-343fa74b8a5mr16652601a91.30.1763451335790; Mon, 17 Nov 2025 23:35:35 -0800 (PST) Received: from ?IPV6:2401:4900:1cb4:7658:a83f:a091:98a7:4ddd? ([2401:4900:1cb4:7658:a83f:a091:98a7:4ddd]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3456518b32bsm11932558a91.16.2025.11.17.23.35.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Nov 2025 23:35:35 -0800 (PST) Message-ID: <8d94324f-80e0-4952-b344-23740d1dbf54@oss.qualcomm.com> Date: Tue, 18 Nov 2025 13:05:29 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/msm: adreno: fix deferencing ifpc_reglist when not declared To: Neil Armstrong Cc: Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20251117-topic-sm8x50-fix-a6xx-non-ifpc-v1-1-e4473cbf5903@linaro.org> Content-Language: en-US From: Akhil P Oommen In-Reply-To: <20251117-topic-sm8x50-fix-a6xx-non-ifpc-v1-1-e4473cbf5903@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=AKSYvs3t c=1 sm=1 tr=0 ts=691c21c9 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=LXHpuTL_QG3F6QEsHmwA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE4MDA1OSBTYWx0ZWRfX+tKfiVb2dxH5 f/fbuC6d7SHqRxn2lZyHxa+S1qqF1lk8RRcNbg4chyb0gvNtNPzAkPzSuJDD8+v/4DSYxenyuli RYXlTxHgIaucDkp1fUogl1w2MbyEcPJLiAtIkTzv2HKT5G4yY+o39IVGR+NVeibl4JAoYh+nk77 qYO37Jb2f4XIOaWE7Hp699P/N4Cme1OsbURrKcY8efUbLw3bQynJ3Of7FZ3KRT+qstkEfqSFDE7 x9woYQ0nDME/G5xzOIHGm3TuYmGFUTa0/JlXKvpzs+DV3qMquY+rGT8Kgb1yUf2WJsTk/d8Wtc7 K8coyjv65baBLjlHCyKxO1EHp0kY3SZUWYpVWu5S6vLIY6irrgvdJ2qQYxER2txLHKBFUmKYFZl Co2Ij7HCH6YBlM9ZvDcpPwOqQslZyg== X-Proofpoint-ORIG-GUID: iPU2vCUeX0z8Yu8xqXWcjoymjJ_-egTB X-Proofpoint-GUID: iPU2vCUeX0z8Yu8xqXWcjoymjJ_-egTB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-17_04,2025-11-13_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 bulkscore=0 spamscore=0 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511180059 On 11/17/2025 8:21 PM, Neil Armstrong wrote: > On plaforms with an a7xx GPU not supporting IFPC, the ifpc_reglist > if still deferenced in a7xx_patch_pwrup_reglist() which causes > a kernel crash: > Unable to handle kernel NULL pointer dereference at virtual address 0000000000000008 > ... > pc : a6xx_hw_init+0x155c/0x1e4c [msm] > lr : a6xx_hw_init+0x9a8/0x1e4c [msm] > ... > Call trace: > a6xx_hw_init+0x155c/0x1e4c [msm] (P) > msm_gpu_hw_init+0x58/0x88 [msm] > adreno_load_gpu+0x94/0x1fc [msm] > msm_open+0xe4/0xf4 [msm] > drm_file_alloc+0x1a0/0x2e4 [drm] > drm_client_init+0x7c/0x104 [drm] > drm_fbdev_client_setup+0x94/0xcf0 [drm_client_lib] > drm_client_setup+0xb4/0xd8 [drm_client_lib] > msm_drm_kms_post_init+0x2c/0x3c [msm] > msm_drm_init+0x1a4/0x228 [msm] > msm_drm_bind+0x30/0x3c [msm] > ... > > Check the validity of ifpc_reglist before deferencing the table > to setup the register values. > > Fixes: a6a0157cc68e ("drm/msm/a6xx: Enable IFPC on Adreno X1-85") > Signed-off-by: Neil Armstrong Reviewed-by: Akhil P Oommen Thanks for fixing this. Chia reported this issue a couple of weeks back. Probably, we can add his S-b tag. https://lore.kernel.org/lkml/CAPaKu7QvBZmx0b8SDBY1H3u-Em+0py0BrGkmrfGUXkx1uQrg3A@mail.gmail.com/ -Akhil