From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AA1B34D4FA for ; Mon, 23 Feb 2026 09:09:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771837756; cv=none; b=sadmoA4WAxvLBUCxHWYzpbshfEljjcqDURmH1jdy3k0CdyUmE5vZaWCmmapIGYnCSNGHMHn/RkOVzUoEin/PFSePYKwndCESEzSrX+RAWp+P3r5PsW0d3wDj68ux6iliLyGw5//w8n5CUFvKYVa7HEFSnbdPVR3HA72ycp97v/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771837756; c=relaxed/simple; bh=KlM4Wei2v8Ak9Fx3stfKNDE+6tYQJ7Pja4dRQpoaA+8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Fsu4pCshF41A5rZyTv1PE0IABalNlEB/zhoMHHuZI/SOcPIEqf9VseyhfyqUoXHwMQUeNUiCqIcVXhSeES4qvQZVaQN1SLsA7vBk6ABwp1kYgNACQqVP0NPz+bPPBxMWVckgy1wEfIcQjR5yxjA7jAe4EvXORBEU0ZdCDFx3L24= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PgPei3rs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jVx78ExR; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PgPei3rs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jVx78ExR" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61MMkwq21483271 for ; Mon, 23 Feb 2026 09:09:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= eN7Ug5P4IulUD8R6oc/tr1H69BNlQK6QUos9s3IP/G0=; b=PgPei3rsOIhtAWo5 5Z029DFPbn4BtObtDnE8yAdRIE5N0DRD1e14GABAvMIBoj0Rl5YSMmMgYcLSprb0 VXe7mfdSSEa16caVx+2raxup1eQrvMlNNi6bFjk5WVkC47Xdl9UcrTkUJw8IP/gU +l1gxNrKf6uY7X6VJqwEy6YSou9jMbYpeX2IMjCxV/7BiF+/7Ey26dCudFnak2ed QMfDVHs3CkDbLWqteEuTveie6wbUKI5e/GlMmxakyIYiOh/fCgUhHyd1yBldKbMg lUae9KQOoKkAKH7X3XDsZfPbaT9Cuv8uYEWEtfE0MX4FU60AbAY9Ls/9iJ2+eP1x CQrSyA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cf5x7v44g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Feb 2026 09:09:14 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2a7d7b87977so44484285ad.0 for ; Mon, 23 Feb 2026 01:09:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771837753; x=1772442553; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eN7Ug5P4IulUD8R6oc/tr1H69BNlQK6QUos9s3IP/G0=; b=jVx78ExRfeKslpMrIYPiJlGebqc6apfkRT+5VXoS8uJqzJteMJEf6tvmYQDRHg0W1x pHQiqeRU4o/GbXH9AQ3ZvtTMGFGJnXZ+XlNASNMw7Op1VheDyUc9YTyK0l2rFoK+ji/x yMla88MWB1+JwnrIkeFEzWXCXEfr4pIp7v4iKazRgCfiEgVG9SoXLHA2xkl81QenPwMw g2reb3rfATy0qQJ2IVI0J0UuJGHq20wokL9LYEyzBf3ZTRQYvwb3Hze6687PUgeV9mcG WLnCOiWtPANZwW+DqxpDmPKe4T8rQIb+xwdWd73KFXPpLyIBKalx3HAzzZ4cT+9UWx7D s1pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771837753; x=1772442553; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eN7Ug5P4IulUD8R6oc/tr1H69BNlQK6QUos9s3IP/G0=; b=XmOGQhKN5vorNmlP6zlibqRTVt3ehdCHtmd+zdxOHxhnjHhMAcnZuicxxtoI8lbdSH 7q2rRCcexqd5i79QJgyFbzqE3aFBwkHE1a+hV9jUMjzO0ntHufcEqNhoQqBHsmCfGUt4 fXFrSiJ3TAWYbSGFkN1EQTnOdQeOrq9xARBX2jNDJvOckuu9l81Pj29GFvskt2Lxh3Su /nDD8CfDTZxuuAiAHvvv7JAgALLLHtXVkFQR3aGL93OwzZA7/4PVzh9B5u1W+tZJlDfW UF8Jd7pn98ZcCtHvIK9S2tk2DjmnDbXcCpjlN/Fd5504KTR7dUWy2U9aMHnYdjzzGkoW d69w== X-Forwarded-Encrypted: i=1; AJvYcCUGMS5YoSICtfvm6IyFUBRU8BdAiav4oSIRl5xX+OOWecO+v5WoMlJMJbkkp+5ZfUK+ODvFJf/vN/Fd0kE=@vger.kernel.org X-Gm-Message-State: AOJu0YzcwjuaPpx4f4iZM97zQD8f/EfqzsHmzrU+1OOCMbujZBVhYOla V5dU/bBAcT1NDCzyqrO/SQccNspTQFUDmLoPovHop7HbUrg6LDB6IkSbtCSC7hwtQ8yjyHo2IpX ywonTB3K7Pjd0DJqU4JUbAp2BqgNA1t6BpujySD8OaFXfGQJWO4ec7b4nNL1bzsjFKVg= X-Gm-Gg: ATEYQzxjj+uNSeHT8VGezt8M+wsoSF6whHicoKzlQJA82fZtDgOs0jJN1EYGYlzxrny mf++xE64xJL7QTixgkuXoGufqaRJhuSNmHtukngVqX97/LfRn6DfBvtTYiQNoIzCVo6+ZbXMgaD Dj/y5cU0NcPDt2HfHu86zSGj8KbPWmZZ+ggZzyPNpQDh2W0Q2obNGFO0Epq44dImebLFjZNzqlK NoSKsRejQiAf7cjSlSELb9ryGR7yOHSbsc5XLniTbzYG70sL66AWA6FGYqsdJ6L1RTKEIpm0M/V FA3as4EE8rmynnTJclo1Y4m4iaVQNfKUSzlE1ZK52ujlp6fkgfxiIqsg0aG6NImd1ZkdCIRgYuL YGb5r4vpAsSqs3Df3nyqQumdGLxetQcehXwYH9vkhLkF3P24Otia+opH9B2FRb6H2ArwBF/LYbs fSCEVE72tI49zYLB6efk95VieRm7cDgF9Ur8BXGz0= X-Received: by 2002:a17:903:1b26:b0:2aa:d333:ce84 with SMTP id d9443c01a7336-2ad743e37b3mr80704305ad.11.1771837753409; Mon, 23 Feb 2026 01:09:13 -0800 (PST) X-Received: by 2002:a17:903:1b26:b0:2aa:d333:ce84 with SMTP id d9443c01a7336-2ad743e37b3mr80704045ad.11.1771837752910; Mon, 23 Feb 2026 01:09:12 -0800 (PST) Received: from [10.190.200.237] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad80907b4csm34202505ad.78.2026.02.23.01.09.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Feb 2026 01:09:12 -0800 (PST) Message-ID: <8d96ebc8-67e2-424d-adbc-0948dd3641a0@oss.qualcomm.com> Date: Mon, 23 Feb 2026 14:39:06 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 5/5] arm64: dts: qcom: glymur-crd: Enable ADSP and CDSP To: Dmitry Baryshkov , Konrad Dybcio Cc: robh@kernel.org, srini@kernel.org, amahesh@qti.qualcomm.com, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, mathieu.poirier@linaro.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org References: <20260129001358.770053-1-sibi.sankar@oss.qualcomm.com> <20260129001358.770053-6-sibi.sankar@oss.qualcomm.com> <24973bc9-a082-42ec-89f4-12758ddca136@oss.qualcomm.com> Content-Language: en-US From: Sibi Sankar In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDA4MSBTYWx0ZWRfX9ya2E47L9MSo cDN955+4baOvj/L0X8SQAF8vXedttU/Wivz+OvJIw6LSG99LiYGZUek9YtWp7sZhcotvXT9qlxr GdPQ1aOuuS5glTeD9/EoFva90gdKIw+NTRwVm1Nw0gb393fHfz92QqePAhtW0zi1FRnlsVV0FXU vvWf7C/wlFfwomdSyE3NYFYPz0KF86qE9kcO91NfBJYNru+PPm9G+3aVP2/A3Pt8vZMdJqFg29j e770dLVsutfL+K2eebfmOYLjL3JX6H43WWBKWLZOu95JcZH6mfDo3gcN51RdoeK7dFh+GBSbT78 DKcrNoZ0jVsAWJYQ0D9t5zXPwE0BeUwlx3KSCW2hdHKwcQUckdghAbno9kgIKP70mpH8r3AYxlS v471TRQo8lvk4Es4EFdjUj/TlSJOWdMD4bPMEuJKce30j5X3oAUOh+6bOQgQsj11oC1EvgBrc6S CK+reo/qIGmQUJvz/ww== X-Proofpoint-GUID: bCoP9TZdRn8wYjyFrxrO6NRpo3XVWq5x X-Authority-Analysis: v=2.4 cv=X71f6WTe c=1 sm=1 tr=0 ts=699c193a cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=GmUvsNMoEockHelqzZ0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: bCoP9TZdRn8wYjyFrxrO6NRpo3XVWq5x X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_01,2026-02-20_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 priorityscore=1501 adultscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230081 On 2/3/2026 6:09 PM, Dmitry Baryshkov wrote: > On Mon, Feb 02, 2026 at 11:16:19AM +0100, Konrad Dybcio wrote: >> On 1/31/26 8:54 AM, Dmitry Baryshkov wrote: >>> On Fri, Jan 30, 2026 at 10:55:24AM +0100, Konrad Dybcio wrote: >>>> On 1/29/26 1:13 AM, Sibi Sankar wrote: >>>>> Enable ADSP and CDSP on Glymur CRD board. >>>>> >>>>> Signed-off-by: Sibi Sankar >>>>> --- >>>>> arch/arm64/boot/dts/qcom/glymur-crd.dts | 14 ++++++++++++++ >>>>> 1 file changed, 14 insertions(+) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dts b/arch/arm64/boot/dts/qcom/glymur-crd.dts >>>>> index 0899214465ac..0eed4faa8b07 100644 >>>>> --- a/arch/arm64/boot/dts/qcom/glymur-crd.dts >>>>> +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dts >>>>> @@ -487,6 +487,20 @@ &pon_resin { >>>>> status = "okay"; >>>>> }; >>>>> >>>>> +&remoteproc_adsp { >>>>> + firmware-name = "qcom/glymur/adsp.mbn", >>>>> + "qcom/glymur/adsp_dtb.mbn"; >>>>> + >>>>> + status = "okay"; >>>>> +}; >>>>> + >>>>> +&remoteproc_cdsp { >>>>> + firmware-name = "qcom/glymur/cdsp.mbn", >>>>> + "qcom/glymur/cdsp_dtb.mbn"; >>>>> + >>>>> + status = "okay"; >>>>> +}; >>>> Please make sure it gets to L-F (only Kaanapali is there right now) >>>> >>>> Reviewed-by: Konrad Dybcio >>> Hmm, looking at x1e80100-crd which references qcom/x1e80100/adsp.mbn, >>> but the firmware in linux-firmware is (now) targeting IoT devices, >>> should we use WoA-like names for firmware on Glymur CRD instead >>> (qcadsp-something.mbn). It would match what was done for the SC8280XP >>> CRD. >> I think it's simply time to stop pretending the firmware is generic >> (some fw simply isn't and some fw may come from different/incompatible >> branchpoints) and include a board name in the path > Well... CDSP is usually generic, except for WP vs non-WP. Hey Dmitry/Konrad, Thanks for taking time to review the series :) The ADSP/CDSP firmware that got upstreamed to linux-firmware got their functionality tested on Glymur WP CRD devices.  Given that the firmware has already landed, can I continue to use the same name as the patch and have a different name for other boards if something specific has to be pushed for IOT? -Sibi