From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59157318BB5 for ; Thu, 20 Aug 2026 09:28:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.21 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787218094; cv=fail; b=kSSpdz3hziJy4syz+eIM0qcdfy83kjGHW2cyivyAZQJ0DvtFScbRoiAVzk66Tj9vXaLe8y0UdS5np0zOlDWyTSh1NuNIQWaeFfq0KtGAMyrQ5ugKlqmzVkMJJfPMpZ2qS4aiWvEREhNZ7lrrYzc9lJultnzpb42Lt5Z3bTfY/rQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787218094; c=relaxed/simple; bh=AXKJJOLaFzMwBSdqypH0CIufMHE91esZ5hREoGFpuJg=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=Ip2tM3L3ZqUEb9+TU4bCRD5U8vmveFC9C89jO3noFEuNm+zdbvDmZWQeemytkk1DpVAvKkxShnfgyu13EfZrFrahed325eN+J2M6HqhktAHwoxoYmYW6nXAg1NqFJlpDyBOu9Z493xH3sUsCt5NXeBv0uE2bJNMXRueYpefFyXo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=iRZSz12l; arc=fail smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="iRZSz12l" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1787218092; x=1818754092; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=AXKJJOLaFzMwBSdqypH0CIufMHE91esZ5hREoGFpuJg=; b=iRZSz12lFa1BcUbPbHmOXWpHwi605U58BLWzgy1rYVW9mqpTBYEjJDZG bPwgOz3wSDN6jOgfnuqcBSjsdBA8tHCemdP01dB2GrbzdxW5FeKfbCgsc oOKeQuooeaNUBkCV1+AjuKS0m60u8jni7E1Bz7oedPY2tGonpuiu+3KtM v1hAvesW04OX7MDAZVMKRxapt1M5ADadXL4K+6kTgkeABwveo6hoexmeB MV3lSQulkljKM6HziJfbDYVq8ywqxpSU/eLPmYY1GRaVYdniHzU4LVpYH DBjRn1PPFQlDlucR8liKgbgh3c1t0Hn/8sX7x2QSjUBjswlp1+VrIIwfD w==; X-CSE-ConnectionGUID: ywfO36mSQ06413aaTGn/wQ== X-CSE-MsgGUID: UCnCLUDiRAWOp/6SfuxEnw== X-IronPort-AV: E=McAfee;i="6800,10657,11880"; a="87605452" X-IronPort-AV: E=Sophos;i="6.25,232,1779174000"; d="scan'208";a="87605452" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2026 02:28:12 -0700 X-CSE-ConnectionGUID: bjpOK1G5THigiKp7nCR4cQ== X-CSE-MsgGUID: U8/Q42f9R2O82TTAOMaFFw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,232,1779174000"; d="scan'208";a="264166933" Received: from fmsmsx901.amr.corp.intel.com ([10.18.126.90]) by orviesa006.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2026 02:28:11 -0700 Received: from FMSMSX903.amr.corp.intel.com (10.18.126.92) by fmsmsx901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 20 Aug 2026 02:28:10 -0700 Received: from fmsedg903.ED.cps.intel.com (10.1.192.145) by FMSMSX903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 20 Aug 2026 02:28:10 -0700 Received: from BL0PR03CU003.outbound.protection.outlook.com (52.101.53.14) by edgegateway.intel.com (192.55.55.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 20 Aug 2026 02:28:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yaois9CseCJHM26fhWMlW2QjmMa2N+KkQ1RPMmt09wxUxUyfcMqNo+qdVzr2I8tZskDAfix2k70BvDdNTeIXPj6zKv/JOOFcfJXrN9X0giR32otsNKtKMztLpzwq0jh/AZX3AVPUgKFgbWAkA4Sn4XKLWrriSJaOrD7uHshSZku2pXsRt0Gcc6V80/T923RzwkhEF5uoSoaQpDDU/ZaMZfIRmIFiXG0m6yKC8Yz1BIJslqHBRxMnQxQYyRacd+CxproteemdZMHZkApMVbnrdpl5yhIw5UnjsaUuQ+FIdox5fiVTjHk9gQizTj18W9ebRK6V9+02sb/Bd6tDPglWwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oK/FK7LN55xFJWyVfxv0h7QknUeyod06sASSO56Xs7k=; b=Kh7VmaWvmXaNmts9Pt4r+rpmrAsg3VyVJxtbx+CkwrVLl3UDhJML4njY0dX8Sdu/xx+QD+D7RT4AQjORdn/wKQil2bxPdCY1pSgVRtw9prjfsJE9WL4w0pklRHU4tgbb58BR7bvAkn3WlZ7mPbVWu78JOPpJ6w+d5USCWyxOZ5edgJAQekKOPO/Qs1t/eghd1WvubVxbyXqWIiJyips8Tv9HPg5jvOpJQeYwrJNMHsdmSuypIudz4qUHNdkoCWju4YzQVaAP2RQIfCNVQoJ/coYR5z1Oofbz0C67/DckDM1f5RdKZlmgDa/8TTn4wgK3dP3ChDI93R/slsySnkmMeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from LV3PR11MB8508.namprd11.prod.outlook.com (2603:10b6:408:1b4::8) by PH7PR11MB6356.namprd11.prod.outlook.com (2603:10b6:510:1fc::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.8; Thu, 20 Aug 2026 09:28:06 +0000 Received: from LV3PR11MB8508.namprd11.prod.outlook.com ([fe80::a1e8:1786:e5d1:8e51]) by LV3PR11MB8508.namprd11.prod.outlook.com ([fe80::a1e8:1786:e5d1:8e51%5]) with mapi id 15.21.0339.007; Thu, 20 Aug 2026 09:28:06 +0000 Message-ID: <8d9e1c37-5ad9-4a55-8198-4c1d2139a87b@intel.com> Date: Thu, 20 Aug 2026 11:30:19 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/6] ice: use string choice helpers To: Dmitry Antipov , Andy Shevchenko , Tony Nguyen CC: Kees Cook , Julia Lawall , "Nicolas Palix" , David Rhodes , Richard Fitzgerald , Adrian Hunter , Ulf Hansson , Edward Cree , References: <20260820061113.4176623-1-dmantipov@yandex.ru> <20260820061113.4176623-4-dmantipov@yandex.ru> From: Przemek Kitszel Content-Language: en-US In-Reply-To: <20260820061113.4176623-4-dmantipov@yandex.ru> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS4P192CA0018.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:5e1::7) To LV3PR11MB8508.namprd11.prod.outlook.com (2603:10b6:408:1b4::8) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV3PR11MB8508:EE_|PH7PR11MB6356:EE_ X-MS-Office365-Filtering-Correlation-Id: b78ef111-30f2-4129-4c2a-08defe9d5771 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|23010399003|366016|7416014|376014|10067099003|56012099006|11063799006|4143699003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: mQfcltKG5FKMEdgKVRwDx/CxOOz9Ye64q/JI0ouYD7w2U1VV6DIukRFrUkUEn72hQyzS9oZFx91uAkEXS/9tUjRK5J0/VzCp76nDpaLBGFG967aMRc8FljAhK1i9O7bA1yyY8VySa4IxxxpSoZ9qXZB8fZYj9U3bfvuT50ZRKSblbt+3W2cic5gyARIdhUCRq8CW/Y2UbNioqXPBJTKoRyooJlBYMwS/YzZ/bT0/FD/4iGWmaUE2lzoGIxCK7eAYJfBFZ+eSfI5W5+ZHtNyXqgL1mkNMsO0IuIdxokAiGBwaxWjc1XoQSC8Jaj6rboefuAwqEwFFI2adO8tQ4kwM5djs1MqgHOgdK4d5Py+iJ2RfspSZhbC0nCjw2AMGNgFxqyfkSx16KSwmgUVINCf69n4B/xU7Z23R5LqVkmaCWUZVcGMQrXiauOCb/CY+8q+PkDC4dJw1TU/LzKgSBVztIFFsR7voTRDVdWEdrrfw6XD9mQ2uYUFOYYSre8jmEdb7mTJwDEIGcr+0Lv7wEqvQiKcZxg6xBFfAHk9idh4JkX8am+R9TaFaTYrfUZk9pHZgFaN+HRoruA/yAgd3nIOaxO4uA1LnddBJCxbdxULXpORemPV8bzbzbmS7S5fBTcgz X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV3PR11MB8508.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(23010399003)(366016)(7416014)(376014)(10067099003)(56012099006)(11063799006)(4143699003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VS82VkdLNlpWcFNEREhaT3NhKzhHT0hnU0FPMHFQTS9qWEo0T2psdnllYlAr?= =?utf-8?B?T0RlUU44UWV4SWd1YVZ1V2xBNFFMd2R2b1lSSkQrMjVDTmVqcVEvcXRnejJ0?= =?utf-8?B?V2pCNUhuVzJVbGFLQWRNRWZ4T1dBdCtOYXdUczhmMEIwbUx6OU41YlVubnd6?= =?utf-8?B?SWg1dmRJUHhsSnBCR3lrVHgxZTlPcTRYNXprdWttN0FOeUZYQkI0bURPZkhQ?= =?utf-8?B?bmg1c2lyWldWdjJaVmdZcUVVSDFpTDNjUDdudzBXTzdoamhTTHZVd1hFdXQv?= =?utf-8?B?akdUTCt1amxTMGpObHZHNGcxUEZJSTRVQzZFaDNTSEMxMThaaUlKSWZLMnAz?= =?utf-8?B?TlRMVlErbEsvcnRCVk9sbFVNTGlEY3JmQ1ZkWTdIdjk2RHB6R2x1amMzb2Vy?= =?utf-8?B?NFlFa0greXZCQXF1OWNSYURxTFphZmZoYnYrYU5yYzM5UjNEa0pGVTZ3dkp1?= =?utf-8?B?L2dJa1JDRXhPalZrd04vOXZsV0JnQncyMTNZbCtwdkRuVk5vbGlRbGRoTHdT?= =?utf-8?B?SDZDd2h0bzFyaFlxS0ZjRWdDVXEvRklwL3Yxc2lWL0NncmRPdVVaMnk2S0ZT?= =?utf-8?B?bFdZNTR4VEFmOUtwa3Vsa3pRbVVQTmdvNENMVDYwRVYrU3I2V2Q1NWRiUDA4?= =?utf-8?B?SUh2R1VwLytuOUlZTEtMbmxuK0E0bXVtWERzOWNDVk5lS25VNW5XZDRLelI2?= =?utf-8?B?TnBKZlIrVGxDcUovK1hTQkZLVkcwdUlmbEdTc1lSOW9IRkY1Z0NuSUhGYUtw?= =?utf-8?B?b1BxUnFydnhQMTJ4dUxyTi92T3dvUGExbC9rOVNHYXVpdWRoc1M5S2R6Umow?= =?utf-8?B?b3A3OUFVOTluY1FFSHlGK1BzSHdsMkExcWxFRWEwMVN1MXJsRnNvMFQwOUc5?= =?utf-8?B?M0FVYWJFcDdvcnRpKzBhRURFelNDWjF5TjB0WHFDakdqcmM3STd6dzNhNHpQ?= =?utf-8?B?UGRhQkV1VWhNeklsSmtpRFl2OEpVWUI0ZTdUeEZWTXNXeXpOc2NaNElZd3gx?= =?utf-8?B?Z1dRSm05VERJZXdaKzdvQ01WTVVYRjZ0SElhNFlZMEpac2ZmQ2hialpkY0JH?= =?utf-8?B?UHdaUXA0a3RGMUk2blk2ZFcybEljbVZ6QXYwWG5ZQ1hSN2QxUWtoSGNaeEJm?= =?utf-8?B?dER5UHFhVi85cyt2K0hNY1JnNm1hdU1SaHJlbno4SzM4TTZjN2ZUVVVrSGUv?= =?utf-8?B?QlB6QnZOTWVraGpNUy9EbmpFajJMSGJXV0NTTzZNYmxIUzNHY3NkQjU3UDhF?= =?utf-8?B?VE54TU9GcXRYN3RhTWw4YkcxQWIvN2dXdFBSTDhBTkZOWnkzamVaU0tZdU1O?= =?utf-8?B?K1JnN0JsaVhOTTQ1Zklzdmtia2N2cHNVMURDb3BJWElFbTlPMjd0SzJ3V0VH?= =?utf-8?B?RUFSTTJKWE9MTnppVGo3ZjdZa3dVa1JCb2lGaTA3NjJUN2NRV2tzZk5YeWNp?= =?utf-8?B?UVNTSGptMGdQK3RyeUJlaElyK21Pam9NRjI3RlVFMWFWWWJ1ZjJURGFyQXRP?= =?utf-8?B?RkpCajBVWlprc3FvejNUMURNdDhXKzJ3MnUyYjg3YU5IamVIaDk4OFRsNjNr?= =?utf-8?B?Y0p1d3NBUlBGZjRwUFVNaWNpUzUvOTVNYXJsT3gzQnhlaFRUZyt0OVhTcXdq?= =?utf-8?B?cW5YSmhIeVZ1eWZjRzlyTStlcmRFWWovaG1OYnpUaHc0bXQ4ZXNDekhGeFFM?= =?utf-8?B?emhqbGgvYVJjOTRNQ1JCVjV6OCtjLzJQclArSmRGTTQ0cE8xbnRvc2h6TlR6?= =?utf-8?B?S0VmbVU1MjQwaFhjMzFQRDlXUUNRR01EZXJoNlpXRmdVSktnM2lxS1Fscmo0?= =?utf-8?B?MEVrM1RkWFg0YUxjTUU2WEx6b3o5aHZBNVU4M3BnZ2xqbVl1ZWdORVhRam95?= =?utf-8?B?SVFqdHlMYng3UVV5VjVWNzlJbTVRZDRjYlg4YjJjN0hzbHhOQi9weEFtR0ox?= =?utf-8?B?akVhcThQbGswaEplbjA3RVVmYTV6NisvUGFKcG1hRTZwNXFBMzM3TnJFRzBX?= =?utf-8?B?QlduZTR2T3VHQjQ1MzZKU1VSOHJ4QVZ5ZnhJNFdOa0FvcGJXR2NrcFZXZHE4?= =?utf-8?B?SWpySDBtcGtUbmREb3FyR0h6OUh0SzVPc0JJU3RtTDRpUzZDU2NRTXplRDlh?= =?utf-8?B?QkhNUUVmcGc3RTkrSWl5TXI3WUZSdzZuelczcVJSUVlkV0lNOUxXSUpiOXpK?= =?utf-8?B?UFpsQ1p0N1FWYmpIaVc2OENpNHc0akVWNDYva21LaFRXUUhPNy9uZFhNenFi?= =?utf-8?B?blhGRGtrZEFlYlpkQlpkdmo5OEZJVVRxY3ZPTHRLdHF2enZFOWRvWDlPdlJQ?= =?utf-8?B?WUFTWFNjRjErVmZrVWhYUGx0Uk1tbDRFcHJXYTZSdnd4b1A0RExjODZ6UmZO?= =?utf-8?Q?lFxSvRmwtHDzpJqk=3D?= X-Exchange-RoutingPolicyChecked: XKRMVDG4JRjpbAfJxAkZoo0ziBzWzlcvzHuIJfV8TXaTeF8pqMBiSuy+7O8fl1XKf+c9vqrfXsxCOtZtYf7k3MgnYnuqzEEZ9eONBcPlrY09pWwYVJLbAqzkA19J/u22KM1sDxHjEU4eWnGru3xYiLmeQ3VQQ94CmIO3Y0Gw4WE/NBof4OEArgJ+ZvUamCdHaXsqAv8SFDy3Im3sDWD9LhNsqODgTqH3vPaV/NQkVEueTY94VTiDuROYYAXqZItob07xTvClAgmVggm9HheeiKOcEOsnSArKXLDDV7DfKULIrvYDGvbVGul8YK073CwkN73cRvz0i06uhVAZ8tm5LQ== X-MS-Exchange-CrossTenant-Network-Message-Id: b78ef111-30f2-4129-4c2a-08defe9d5771 X-MS-Exchange-CrossTenant-AuthSource: LV3PR11MB8508.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2026 09:28:06.6249 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: agir66effU8P4A8ug/Y/0564rOpn1QMOVtH3hG23lnfjfqG3cXhumHAiKFTGhFqpce4TUIY+oOPmVSxO/njwkoGLhJoeVNMkMgjR6eUq3V8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6356 X-OriginatorOrg: intel.com On 8/20/26 08:11, Dmitry Antipov wrote: > Prefer 'str_locked_unlocked()', 'str_on_off()' and 'str_true_false()' > string choice helpers over hardcoded strings where appropriate. > > Signed-off-by: Dmitry Antipov > --- > drivers/net/ethernet/intel/ice/ice.h | 1 + > drivers/net/ethernet/intel/ice/ice_sriov.c | 6 ++---- > drivers/net/ethernet/intel/ice/ice_switch.c | 2 +- > drivers/net/ethernet/intel/ice/ice_tspll.c | 2 +- > drivers/net/ethernet/intel/ice/ice_vlan_mode.c | 2 +- > 5 files changed, 6 insertions(+), 7 deletions(-) for net we prefer to not merge such refactors, given it's not related to any bigger "net" work https://docs.kernel.org/process/maintainer-netdev.html#clean-up-patches