From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C74154084E for ; Wed, 31 Jul 2024 20:03:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722456204; cv=none; b=gq0FmdAUctsaguGo5GtCguUJpNaGsZnmiLG1goNHZ/k8gtgxf3JvCH57Efh5ykj7UiTtmJVhKpNSGwixA54yCB8711sUyHaFJQi5QydPGCZeoEUB0T6U4lpT10FAMLlyG7Qf8JtsXiscxs1SMxVK1o/SGwaZGgSMrP5ZW154Cxc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722456204; c=relaxed/simple; bh=ALLryGFl6MDYaFUXnyF92rskMoQ1mK0GIOJ/exNKv4o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ISKYviCjO70EROfOKIiwmrOah4n3G1FMle5sNYOsnt+1sT6Y8Kx9FQGgW/6toOtYMCJM3RyVaB2DPLAIFTUaHLRkKa1EsyS7Ig7z8rxMT7hsyDP3zLTV1aicFUfqCxp4kFfD+fiDbsp7eqx2agP+segWRXdurEQrWa0YNLjt5oQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=dkf4OSL+; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="dkf4OSL+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1722456200; bh=ALLryGFl6MDYaFUXnyF92rskMoQ1mK0GIOJ/exNKv4o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dkf4OSL+3IQSqZdT7jfZQZiphOWNvh3Ty1GvlrwpE6e6lUZSVizLBr0UHrPXyd7cC D5Geb5S8nwtEXJcI76dVv7mUqbH6QieyhmmJLAqb1V2p67461QpcXur3LMykxhJ4kv sv8aAGOOQ0yAM/M8FCJpFQ9jEao5ycVu/qYTGttmmz15DgAeGETriGmobExipaIWDD AZTfaOIyuLj+ksy6BmchJ+f8HKWrfttCkKohfTzLbVnUCvxJ1MHt5QP30KpAFxjlnI d2gJQ0y6FVjnICY1YU8ZOj2JXAZkHoneJ1n+Xm6Sx3GHoqrqWE9DfsouhV7+6NmBWD Xv9CDfGPnKSzQ== Received: from [100.115.223.179] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madrid.collaboradmins.com (Postfix) with ESMTPSA id E4E2E3782201; Wed, 31 Jul 2024 20:03:19 +0000 (UTC) Message-ID: <8d9e8947-5d13-40eb-a887-06a809174fc6@collabora.com> Date: Wed, 31 Jul 2024 23:03:19 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/bridge-connector: Fix double free in error handling paths To: Robert Foss , Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Dmitry Baryshkov Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20240711-bridge-connector-fix-dbl-free-v1-1-d558b2d0eb93@collabora.com> <172130413876.532897.864210015976659933.b4-ty@kernel.org> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: <172130413876.532897.864210015976659933.b4-ty@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Robert, On 7/18/24 3:02 PM, Robert Foss wrote: > On Thu, 11 Jul 2024 14:26:55 +0300, Cristian Ciocaltea wrote: >> The recent switch to drmm allocation in drm_bridge_connector_init() may >> cause double free on bridge_connector in some of the error handling >> paths. >> >> Drop the explicit kfree() calls on bridge_connector. >> >> >> [...] > > Applied, thanks! > > [1/1] drm/bridge-connector: Fix double free in error handling paths > https://cgit.freedesktop.org/drm/drm-misc/commit/?id=ca5442ed8f53 The fix is supposed to reach v6.11 tree, hence wondering if this fall through the cracks as it haven't shown up in -rc1, neither in linux-next - should have been applied to drm-misc-fixes instead of drm-misc?! Sorry for the noise if this already follows the regular DRM workflow and just needs more time to get picked into the target branches. Thanks, Cristian