From: Krzysztof Kozlowski <krzk@kernel.org>
To: Umang Jain <umang.jain@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
"Paul J. Murphy" <paul.j.murphy@intel.com>,
Daniele Alessandrelli <daniele.alessandrelli@intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Martina Krasteva <martinax.krasteva@intel.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: media: imx335: Add reset-gpios to the DT example
Date: Wed, 31 Jul 2024 09:32:13 +0200 [thread overview]
Message-ID: <8da6c3bf-05a5-41a9-8f3d-0b8c6495bef1@kernel.org> (raw)
In-Reply-To: <20240731-imx335-gpio-v3-1-443bfa6ce864@ideasonboard.com>
On 31/07/2024 09:02, Umang Jain wrote:
> It's easy to get the polarity of GPIOs in the device tree wrong, as
> shown by a recently fixed bug in the imx335 driver. To lower the chance
> of future mistakes, especially in new bindings that would take the
> imx335 binding as a starting point, add the reset-gpios property to the
> DT example. This showcases the correct polarity of the XCLR signal for
> Sony sensors in the most common case of the signal not being inverted on
> the board.
>
Just one sentence like - make the example complete by adding reset-gpios
with proper polarity - would be enough. Concise, yet still informative,
commit msgs are preferred, usually.
This device is not different than 1000 others which use GPIOs and for
every device you must use proper polarity. Commit msg suggests that here
we should explain something more.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-31 7:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 7:02 [PATCH v3 0/2] media: imx335: Fix reset-gpio handling Umang Jain
2024-07-31 7:02 ` [PATCH v3 1/2] dt-bindings: media: imx335: Add reset-gpios to the DT example Umang Jain
2024-07-31 7:32 ` Krzysztof Kozlowski [this message]
2024-07-31 7:02 ` [PATCH v3 2/2] media: imx335: Fix reset-gpio handling Umang Jain
2024-07-31 7:29 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8da6c3bf-05a5-41a9-8f3d-0b8c6495bef1@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniele.alessandrelli@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=kieran.bingham@ideasonboard.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=martinax.krasteva@intel.com \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab@kernel.org \
--cc=paul.j.murphy@intel.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnguo@kernel.org \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®