From: Wyes Karny <wyes.karny@amd.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, Perry.Yuan@amd.com
Cc: Jonathan Corbet <corbet@lwn.net>, Huang Rui <ray.huang@amd.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Mario.Limonciello@amd.com,
Ananth Narayan <ananth.narayan@amd.com>,
gautham.shenoy@amd.com
Subject: Re: [PATCH 2/4] Documentation: amd_pstate: Move amd_pstate param to alphabetical order
Date: Fri, 9 Dec 2022 12:13:45 +0530 [thread overview]
Message-ID: <8da7cbbc-0a03-32e5-cc92-56931365782a@amd.com> (raw)
In-Reply-To: <Y5FPBNawZgvk7GBe@debian.me>
Hi Bagas Sanjaya,
On 12/8/2022 8:12 AM, Bagas Sanjaya wrote:
> On Wed, Dec 07, 2022 at 03:46:46PM +0000, Wyes Karny wrote:
>> + amd_pstate= [X86]
>> + disable
>> + Do not enable amd_pstate as the default
>> + scaling driver for the supported processors
>> + passive
>> + Use amd_pstate as a scaling driver, driver requests a
>> + desired performance on this abstract scale and the power
>> + management firmware translates the requests into actual
>> + hardware states (core frequency, data fabric and memory
>> + clocks etc.)
>
> Device drivers request certain performance level?
What about the below wording?
""
passive
Use amd_pstate with passive mode as a scaling driver.
In this mode autonomous selection is disabled.
Driver requests a desired performance level and PMFW
tires to match the same performance level (if it is
satisfied by guaranteed performance level).
""
Perry, let me know if it looks fine to you?
>
>> + guided
>> + Activate guided autonomous mode. Driver requests minimum
>> + performance and maximum performance and the PMFW autonomously
>> + selects frequencies in this range.
>
> Same here.
I'll rewrite this as:
guided
Activate guided autonomous mode. Driver requests minimum and
maximum performance level and the PMFW autonomously
selects a performance level in this range and appropriate
to the current workload.
>
> Thanks.
>
--
Thanks & Regards,
Wyes
next prev parent reply other threads:[~2022-12-09 6:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 15:46 [PATCH 0/4] amd_pstate: Add guided autonomous mode support Wyes Karny
2022-12-07 15:46 ` [PATCH 1/4] cpufreq: amd_pstate: Add guided autonomous mode Wyes Karny
2022-12-09 7:43 ` Huang Rui
2022-12-09 10:04 ` Wyes Karny
2022-12-07 15:46 ` [PATCH 2/4] Documentation: amd_pstate: Move amd_pstate param to alphabetical order Wyes Karny
2022-12-08 2:42 ` Bagas Sanjaya
2022-12-09 6:43 ` Wyes Karny [this message]
2022-12-07 15:46 ` [PATCH 3/4] cpufreq: amd_pstate: Expose sysfs interface to control state Wyes Karny
2022-12-07 15:46 ` [PATCH 4/4] Documentation: amd_pstate: Add amd_pstate state sysfs file Wyes Karny
2022-12-08 2:59 ` Bagas Sanjaya
2022-12-09 9:01 ` Wyes Karny
2022-12-08 11:48 ` [PATCH 0/4] amd_pstate: Add guided autonomous mode support Rafael J. Wysocki
2022-12-09 14:44 ` Wyes Karny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8da7cbbc-0a03-32e5-cc92-56931365782a@amd.com \
--to=wyes.karny@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Perry.Yuan@amd.com \
--cc=ananth.narayan@amd.com \
--cc=bagasdotme@gmail.com \
--cc=corbet@lwn.net \
--cc=gautham.shenoy@amd.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=ray.huang@amd.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®