From: Khairul Anuar Romli <karom.9560@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>, dmaengine@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
Vinod Koul <vkoul@kernel.org>
Subject: Re: [PATCH v3 1/3] dmaengine: dw-axi-dmac: fix Alignment should match open parenthesis
Date: Sat, 24 Jan 2026 20:32:49 +0800 [thread overview]
Message-ID: <8da8dc4a-1e5c-402d-8631-7acd61d21a65@gmail.com> (raw)
In-Reply-To: <40ad7d60-f3c3-459a-a8c0-5c65476c3cca@web.de>
On 24/1/2026 5:05 pm, Markus Elfring wrote:
>> Check warning is throws when run scripts/checkpatch.pl --strict:
>> drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:345
>
> Please improve such a change description another bit.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc6#n45
>
> You might not need to mention all affected source code positions here.
>
I will improve the change description and omit mentioning all the
affected source code in the next revision.
>
> …
>> ---
>> Changes in v3:
>> - Split the patch into smaller patches according type
>> of warning.
> …
>
> * I find this hint relevant also for a better commit message.
>
> * You do not need to repeat patch version descriptions here
> after you provided them in the cover letter already.
>
Noted. Will keep to the cover letter and avoid repeating the same
description in every single patch.
>
> Regards,
> Markus
next prev parent reply other threads:[~2026-01-24 12:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-24 2:45 [PATCH v3 0/3] dmaengine: dw-axi-dmac: Coding style cleanups Khairul Anuar Romli
2026-01-24 2:45 ` [PATCH v3 1/3] dmaengine: dw-axi-dmac: fix Alignment should match open parenthesis Khairul Anuar Romli
2026-01-24 9:05 ` Markus Elfring
2026-01-24 12:32 ` Khairul Anuar Romli [this message]
2026-01-24 2:45 ` [PATCH v3 2/3] dmaengine: dw-axi-dmac: Add blank line after function Khairul Anuar Romli
2026-01-24 2:45 ` [PATCH v3 3/3] dmaengine: dw-axi-dmac: Remove not useful void return function statements Khairul Anuar Romli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8da8dc4a-1e5c-402d-8631-7acd61d21a65@gmail.com \
--to=karom.9560@gmail.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=Markus.Elfring@web.de \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®