mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Marc MERLIN <marc@merlins.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
	ilw@linux.intel.com, "Paul E. McKenney" <paulmck@kernel.org>
Subject: Re: Thinkpad P17 keep hanging in ipv6_addrconf addrconf_verify_work / netlink in 6.4 and 6.6
Date: Mon, 04 Dec 2023 19:34:49 +0100	[thread overview]
Message-ID: <8db5b21fee0f0e547d89b2797b0f4cc40062339b.camel@sipsolutions.net> (raw)
In-Reply-To: <20231204165239.GB9208@merlins.org>

On Mon, 2023-12-04 at 08:52 -0800, Marc MERLIN wrote:
> > 
> > So looks like bug in the 'igc' driver wrt. runtime PM locking.
> 
> Thank you for the analysis Johannes, I appreciate it. I'm at a spot
> where I have to return this laptop very soon if I can't get it working
> (or will get stuck with it, it's a temp one until I get my original P73
> fixed, and from the little I've seen the 3 year newer P17 with I 11th
> gen (10nm) instead of I 9th gen (14nm), there isn't a huge difference
> between the 2, especially as my I9 had 8 cores and the I11 only 6 cores.
> So I may go back to the P73 as soon as I can get it fixed).
> 
> In the meantime, anything I can try to get around that bug and confirm
> that assumption? I assume that driver isn't something I can turn off
> since everything depends on it, correct?
> 

Well I assume your ethernet connectivity depends on it :) If you don't
need that, I guess you can just blacklist it.

You could probably remove the runtime PM ops:

--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -7321,8 +7321,6 @@ static const struct pci_error_handlers igc_err_handler = {
 #ifdef CONFIG_PM
 static const struct dev_pm_ops igc_pm_ops = {
 	SET_SYSTEM_SLEEP_PM_OPS(igc_suspend, igc_resume)
-	SET_RUNTIME_PM_OPS(igc_runtime_suspend, igc_runtime_resume,
-			   igc_runtime_idle)
 };
 #endif
 

But I really have no idea about this driver, this is purely from reading
the stack dump and code.

johannes

      reply	other threads:[~2023-12-04 18:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-02 17:13 Thinkpad P17 gen 2 kernel 6.4 and 6.6 lack of support for nvidia GA104GLM [RTX A5000 Mobile] and missing module firmware Marc MERLIN
2023-12-02 18:08 ` [Nouveau] " Timur Tabi
2023-12-02 22:14 ` Marc MERLIN
2023-12-04  0:40 ` Thinkpad P17 keep hanging in ipv6_addrconf addrconf_verify_work / netlink in 6.4 and 6.6 Marc MERLIN
2023-12-04  7:35   ` Marc MERLIN
2023-12-04 10:57     ` Johannes Berg
2023-12-04 16:52       ` Marc MERLIN
2023-12-04 18:34         ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8db5b21fee0f0e547d89b2797b0f4cc40062339b.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ilw@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marc@merlins.org \
    --cc=netdev@vger.kernel.org \
    --cc=paulmck@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®