From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E76E339719 for ; Tue, 21 Jul 2026 13:07:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784639256; cv=none; b=oOBDGhRm8F76+0yxmnbgUgF9NztbPmjYMgY64TxBwxmxGPilioBpU11gbwCCQvTmoUzb9L0hlcbFyzzNr60MUbxZ1t5ccaZMOD3d3wEKycqImN+eBlv0WcHPlIXUXdK9+kSzB3FAfxmaUCJ6NY/U21aZKfFGNs/LnzQDDb1N2RE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784639256; c=relaxed/simple; bh=3x3lP7j380kE9CvaSYhuk+2zEHK1fZOBVU1/W0OHSZI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SLuTjk6pBrF8Edcihs+4Aev2Lr4on/UxYoW+zBloiV/VtSbNVCAe6XGt1JZGbehI2uQaaI8yQaOuFF+AdTs+pZ45HrbDMgLPXqXQ/Q4ZcVxa4eyss3pRuB7+e8rDRZS4zQNJCTmDfrjIXPNNaWLDvdNi8Y27ICT3IMJNfeFrH60= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h175J60H; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h175J60H" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-38e3efab7e0so3542957a91.0 for ; Tue, 21 Jul 2026 06:07:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784639254; x=1785244054; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8kuHno4FgLnOovX3FCD/y2WILch1zVn2CLj5cIw9pdk=; b=h175J60HmLwPBb2GrqVBrqVthyoEIWzfHFsU490pIExvEk9sS0nu3fEQ2ZjfHwRoKC s530oZ+7ltWPirDaJJiEQvTaHi2h/ywgXcEtYLru1tpj8zZlBHzGpaVA/mc1C4EuPkKo KyQMEWjPnDw6jCuZDFq/itbT+HB8XLK05gHMre6QfbaoImBTk+T/LPC1osgQvi3fp3JZ kPF4HyuKpo/PJjej5tZ3o3HA6pmrpP5964IXt0cIEt4v0qBkySicyjN1lK8DVLpl0Mu+ AMg5sxjXrnEQXJNCK+rfFm9fewaO1zMQbXkV9ZoATuAhKiUmlXJm0S56epOm8WPCWsau 1QkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784639254; x=1785244054; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8kuHno4FgLnOovX3FCD/y2WILch1zVn2CLj5cIw9pdk=; b=OkImzZCAXWyJz5QwGixz7IEJocFcDF8SoIy6fCM+86iymU4DD0dN7bIexGVsPkdVVB 7jNThZx3EICNbpsoO6xCREMbDuRd187XdmWomET4DUjm8wVMWOFJ9u7GsY8NmsFaGvre rZjc2dxLtjCCpvJjtF0630LY3VTkX12Rz8+lWAtFUwVf0BHBGvlM/fJkmgk3clZp8Gws 9DGPcPS5G3G4oblVlKa00khZJ+JtHm3cWyYyjYk/ndCKzwGEmeDyuGZJsGCi0uBrI7Rq kj0HX3GTLMxjc3CLhOHewmg9mvfakdsRMvi1eFgTSV3Hn6Dzz4P1SUrZqA+WtwgMZYPF c1cg== X-Forwarded-Encrypted: i=1; AHgh+RpcXY4YUIOzECQtt1plL4+cAu6bI92dGr59w6GNezoh9iPKX3Y5sYCn7Ib5muwJyNz0rzTVumqtcKDuXxA=@vger.kernel.org X-Gm-Message-State: AOJu0YzfHaNm2UZZs4ZbaO9fbCU5Q0ZgZmpk5P0YnX5mC/jeUNrR5hVk 1W6vXC9GkxsqNIrW05+u5m+7rW/czbXDGt/ZazxrZYNaDhp+/EcxeGw= X-Gm-Gg: AR+sD10zAn5ZpT6VeIBeTTa63pb3KleZF9PCs9pnvzFjwGQ8D3PKRxFHTHRNF7SKMNA 3HHVO46AbS1vwDeRzzvzSKt6Q2ZV4eT/ZNRPUhgwy+Ju8TkdXjRYDJuqdeJlaCPbfWvv4cEPHOG lIN6p5xH2d0OHl5Pf+h4Q1eMBTnL2OzonMrTh8WgwBqprFeYxoyIRY3TltrUArCCyejcuL92pue c+x22FfH7t0oWx2KM9Cemq0TMkwftc7txtlIjMMjMqK4M8ZumK0L6yOWjxYR65dtbK8DXQlJtUg t1u4YL/rDhCjwcA4rLor4tdw92ZWTGpkRhcWH7gTDL5FwRey1Mnbv0NQ+PyulwTh1u0GsSgWMkJ 8lcrELN5U/9+ot8nDDEf0JwRZre14BdOfeLnJ6DX6jiMNt5adzhGz2GrnnZ/bAyNZO+XSLzlJtY PQMq8/jubqDAOG4Ou+mw1xlzO089YjanAZpyA5HsRR8Uhkkmw= X-Received: by 2002:a17:90b:5644:b0:387:d5bd:622e with SMTP id 98e67ed59e1d1-38e4b6828cdmr14956327a91.17.1784639254313; Tue, 21 Jul 2026 06:07:34 -0700 (PDT) Received: from [192.168.1.45] ([101.0.62.129]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e923741fbsm1521109a91.13.2026.07.21.06.07.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jul 2026 06:07:33 -0700 (PDT) Message-ID: <8db678fd-ba0c-4e1c-a401-205b40f07c4a@gmail.com> Date: Tue, 21 Jul 2026 18:37:29 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/3] iio: light: gp2ap002: Fix unbalanced runtime PM on repeated event writes To: Andy Shevchenko Cc: Jonathan Cameron , Linus Walleij , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260720193911.74919-1-nikhilgtr@gmail.com> <20260720193911.74919-2-nikhilgtr@gmail.com> Content-Language: en-US From: Nikhil Gautam In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21-07-2026 01:19 am, Andy Shevchenko wrote: > On Tue, Jul 21, 2026 at 01:09:09AM +0530, Nikhil Gautam wrote: >> The IIO core does not filter duplicate writes to the event enable >> attribute, so writing the same value twice invokes >> write_event_config() twice. Enabling twice leaks a runtime PM >> reference, preventing the device from ever suspending again; >> disabling twice underflows the usage count and triggers a >> "Runtime PM usage count underflow" warning. >> >> Bail out early when the requested state matches the current state. >> While at it, switch to pm_runtime_resume_and_get() so a failed >> resume is propagated to userspace instead of silently marking the >> event enabled. >> Fixes: 97d642e23037c ("iio: light: Add a driver for Sharp GP2AP002x00F") >> >> Signed-off-by: Nikhil Gautam > No blank lines in the tag block. ACK, Will update in v2 > ... > >> } else { >> pm_runtime_mark_last_busy(gp2ap002->dev); > At some point consider dropping this dup call. ACK, Will update in v2 >> pm_runtime_put_autosuspend(gp2ap002->dev); >> - gp2ap002->enabled = false; >> }