From: Vikash Garodia <quic_vgarodia@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
Cc: Dikshita Agarwal <quic_dikshita@quicinc.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <linux-media@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: dt-bindings: qcom,sm8550-iris: Do not reference legacy venus properties
Date: Thu, 28 Aug 2025 20:07:13 +0530 [thread overview]
Message-ID: <8db7d699-d3f3-48cb-27c9-fb3639aeec9d@quicinc.com> (raw)
In-Reply-To: <46f5d11d-8bed-4d01-9151-35a24cdacfa5@linaro.org>
On 8/28/2025 7:27 PM, Krzysztof Kozlowski wrote:
> On 28/08/2025 15:49, Vikash Garodia wrote:
>>>>
>>>> Whether removing will not break any ABI as initial binding enables the IRIS
>>>> related code to use video-firmware, now we are removing it.
>>>> I believe, removing binding always break ABI ? or is it depend on driver
>>>> code not using it ?
>>>
>>> There is no single user of this, out of tree (I briefly checked) and
>>> in-tree, so there is no ABI impact. I am changing the documentation of
>>> the ABI, but there is no actual ABI break because impact is 0.
>>>
>>
>> My understanding here is that the interface "video-firmware" is already defined
>> in the binding. There could be possible out-of-tree users of it, might not be
>
> There are no such.
>
>> possible for us to look into all of those out=of-tree users.
>
> We both know there are no such so you claiming "maybe not possible" is
> quite misleading. Qualcomm does not use it and that's the only possible
> case. We can verify it and I did verify this.
>
there are no such known to me either, maybe i would take this as a sufficiency
check to drop/deprecate an interface.
>> I support such cleanups, but also need to understand how this is not an ABI
>
> You are just making up fake obstacles.
>
>
>> break, just that there are no in-tree DTS user means no ABI break ?
>> Would appreciate if you could point to any guidelines if my understanding is not
>> correct, i am currently referring to [1]
>
> There are hundreds of discussions describing this and I am not going to
> do your homework.
>
> In none of other qcom media camss/iris/venus patches affecting ABI you
> raised that problem. Even remotely, so I cannot understand these
> questions here differently than just spreading some sort of FUD over
> this patch just to keep that broken video-firmware design for future users.
As i said earlier, we can find alternatives to video-firmware, its fine. I am
not bringing this discussion to support retaining video-firmware.
>
>>> I am really sorry but it seems you ask about basics of DT, so please
>>> first get into docs and other existing discussions.
>
> Again, read the docs and existing discussions. I am not going to do your
> homework.
The doc i pointed earlier does not capture any such case, hence was requesting
you to point any doc.
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2025-08-28 14:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-23 15:53 Krzysztof Kozlowski
2025-08-25 11:37 ` Mukesh Ojha
2025-08-25 12:02 ` Krzysztof Kozlowski
2025-08-25 12:36 ` Mukesh Ojha
2025-08-28 13:49 ` Vikash Garodia
2025-08-28 13:57 ` Krzysztof Kozlowski
2025-08-28 14:05 ` Krzysztof Kozlowski
2025-08-28 14:37 ` Vikash Garodia [this message]
2025-09-03 13:10 ` Konrad Dybcio
2025-08-26 23:50 ` Rob Herring (Arm)
2025-08-28 14:24 ` Bryan O'Donoghue
2025-08-28 14:42 ` Vikash Garodia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8db7d699-d3f3-48cb-27c9-fb3639aeec9d@quicinc.com \
--to=quic_vgarodia@quicinc.com \
--cc=abhinav.kumar@linux.dev \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mukesh.ojha@oss.qualcomm.com \
--cc=quic_dikshita@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®