From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E735C433DB for ; Fri, 26 Mar 2021 19:24:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0AD8661A02 for ; Fri, 26 Mar 2021 19:24:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230223AbhCZTYN (ORCPT ); Fri, 26 Mar 2021 15:24:13 -0400 Received: from mail-dm6nam11on2085.outbound.protection.outlook.com ([40.107.223.85]:13665 "EHLO NAM11-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230288AbhCZTXw (ORCPT ); Fri, 26 Mar 2021 15:23:52 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X6batEGqT8BnmH4CNHNEB0shIgfqza8MJjFTuBwFA1H4kugs8ksufPxF/tibPYOu45N4Inx1gXG6bbkCAZ8VxGxhrYGZryyAPZx0QYrAVPSLIeJIFuEX3F/DqIcDUmwpGNOcJfgu3OyRwns868Ye77s0+h8dDZnKP4rcmSU/bNZGv1xkWrRX7mTRu5qEajBotAp6+oRMIc50Ie7wCoLWPqW+JXyTN7CFjIrOoCPL6RnCkp57498CaJYaPS5Dar0iq9FkFkkRC+1l9PajleHZm30jWPiUV6C+ZZC2UhIhiQl7DSZ4j2wPTCiNdrv570mQOF1xmwHinM9t3fQPYGTwkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4Z7gTDBxKAA/ysLrJlHHC90il7HcRNqJv9K5j4n1nSA=; b=UMEU4Ff979eWXMzJXwDCw+jKGcsgOMST7ero4ktP0yLY+XmbDf7sOJixwqay+9H9lvlETQ1osuC275UoiZ7Lo5GyXV/QTB8xMjHmQO7nCv5Nmt3EDekSMt+GaCCYTzM8x6ljO89tlRCT4tC6fFNlne8cB1GvhqRDYDNdrttBxMBBF2LB7p8Wl1QNslbgUp3kr072u6cUrrqYvDKwMKW8zGSAsJcr7XjZ/q4tNYb8W1h3m7ZPMx8jLOA8ax2c9EcrjVfRpEuMkaG+/xzr4c7cSRGEkhQ/UuIKd7kVgs6lD4iX4PH7GHn/l6UaGG2OkBXFNAcKL/02Nj2H+RfFWPqHtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4Z7gTDBxKAA/ysLrJlHHC90il7HcRNqJv9K5j4n1nSA=; b=dpCBMKBxuAncmfBhAkMkEaRdd9N/n0RHoAnNcR2PHdg44OAKOXUch/n4dk4smW08BzEC4aWy/Iy4xn+16im93DSZ5IQgXZaTQ0uHGyreGVE3hoMhrXLnsm5QCp8mtYrJDs7INYg5NzOgwOtTDfVGxwiTOZSPG25P/vvfCJeGmT4= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=amd.com; Received: from BL0PR12MB4948.namprd12.prod.outlook.com (2603:10b6:208:1cc::20) by BL0PR12MB4899.namprd12.prod.outlook.com (2603:10b6:208:1cf::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.24; Fri, 26 Mar 2021 19:23:50 +0000 Received: from BL0PR12MB4948.namprd12.prod.outlook.com ([fe80::70f5:99ed:65a1:c033]) by BL0PR12MB4948.namprd12.prod.outlook.com ([fe80::70f5:99ed:65a1:c033%5]) with mapi id 15.20.3933.038; Fri, 26 Mar 2021 19:23:50 +0000 Subject: Re: [PATCH] drm/amdkfd: dqm fence memory corruption To: Qu Huang Cc: alexander.deucher@amd.com, christian.koenig@amd.com, airlied@linux.ie, daniel@ffwll.ch, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <1611750806-10730-1-git-send-email-jinsdb@126.com> <4de809ac-fdd7-b02a-c55f-3c79321cfb7f@amd.com> <14c4be41-28ab-3266-eaf3-b6b0342e18ba@126.com> From: Felix Kuehling Message-ID: <8db9bd61-141d-6764-b74f-6f64117cfd5e@amd.com> Date: Fri, 26 Mar 2021 15:23:47 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <14c4be41-28ab-3266-eaf3-b6b0342e18ba@126.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [142.116.84.209] X-ClientProxiedBy: YTOPR0101CA0024.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b00:15::37) To BL0PR12MB4948.namprd12.prod.outlook.com (2603:10b6:208:1cc::20) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.2.100] (142.116.84.209) by YTOPR0101CA0024.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b00:15::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.24 via Frontend Transport; Fri, 26 Mar 2021 19:23:49 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 4ee983a5-6ad8-4f29-345e-08d8f08caf39 X-MS-TrafficTypeDiagnostic: BL0PR12MB4899: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o7rA+VPmCwjlRgIC/ayZN4QR2HjO0xY+/XiOxH2RdgCMpxzAf90ws1sCWbrwaYDs24U+8W+KD+UpRgk48c1Rd9iPjJz2oSSzj0oOxbqiDmJ9sf+NQaKhPsON2y77HGalZtGduur4fjHzRQbeiEVFFKdeaAH8dCoO0IirtjA1/Vlkygw/o2jt4ZiUBkWYBptiLKjpZ5QosKi0gc+c4vuX6gNL+Yku+G10fWzsJm6hN001PkdZ1MALhKzaZ7EhDAU1ljlQJariaved9+dTBBUhQRQTPaZuYA4Y/pzkSAyiyR2Mj/3JDOkeBZ/7C/bsQTCDhlE0MTQX9amXSYfJfLZhWv8fOCSozw11VMT0ENr19uzg0o4aaefpVH7cz9ayEMjVQ0aD4L/MBVps7Xf3u8pPtmIjblP5HjYYiaQ0y205GgeB8LWA/14T+JzJ2CyQ6o92X5yjVOPuqldJdPPH4uoDaefT+wtR8JHG9u9Q9Bkc6aYzrQTxjB7/XNgGum7ULUuLEPAP3ryyQznYCbmTlekEtZmw9b26RqT7n4AVmGcn56OYPxaPTe6XGziCcmzPLmIHr2B7rnsae3t9FgtzLr6iZ5lOH1B5KPhuc/4ji8AAzqYjI/7HGD1/UZJuEzx8sG8JVUU8/Ivlbq39yTBiatauQL57XfQCl4s9T1bRAcZiry4pr9CI6drb/FM5kWROV4DGhcAe4xzdhejamAD0Fr7Ng7q0KDYuUEJUDAwHVXQZXnMc6OtEUVDjwzN4k44hwCRgqBnvaIAnu3SfpsiESH4FULUYTLbKYGYceOtK03eXMx7bsKBFxYDyVFtjLV85gzDQUnwr3kdd/n7l6DDY2S8oyg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB4948.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(396003)(376002)(136003)(366004)(39860400002)(966005)(38100700001)(31696002)(6486002)(16526019)(26005)(2616005)(44832011)(66946007)(4326008)(478600001)(186003)(66476007)(316002)(5660300002)(2906002)(53546011)(8936002)(16576012)(83380400001)(8676002)(86362001)(6916009)(66556008)(36756003)(31686004)(956004)(525324003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?SmQ2dTFWLzA0L3VCZ3V4YUdaSTBmQzZTVHBiKzdORHVJVlliWXh5ekgvL2pI?= =?utf-8?B?NDdmN1h4bm8wb21hak4xWi9FSWN0S0xVclorN0VzZjR1dGtwN2s2Zy81bHBS?= =?utf-8?B?bFFsQStJc3J1WkZkc3ZYaFA2akxqdHllL1k5S05DN3ZRSTRIM1RjUkpOV0VN?= =?utf-8?B?d1N0eFp6NU1INUxRTmEvbjB0WFgyMkdNZDJYdDhPYjM2UEoxS1kyUWxtcjhu?= =?utf-8?B?V1IwL09FY2Q0Zi9MV0hST1JNdlNPenh4SnRRWFZzQVJuc0tLQXYwVlRMYkJi?= =?utf-8?B?Y05VZ1Nyd3I2NEc3cm03M0xIY2N6YzNMdSswcW1LNERSNkpBVy8veU0vaDNh?= =?utf-8?B?T3NaRXRvUnFZR3JFNndwWHZVWHpqTHJaKy9yN2R0NS9KaWRtNEQ4bUc3dVd3?= =?utf-8?B?bVVSU3pRaHh6WXV4WVE1NmlmUTAzUXY0eEZxSTJSTFREbGY3b3BkL1doUDR5?= =?utf-8?B?ZVN4V1JlKzVBV3Q3emdYOVJNUW1xelUrd1ZqQjZvNWx0cEJrdCtlVGw4TXkz?= =?utf-8?B?VTlmUkRMZHBTQWEvbW50dlBjZkZML1hTVzNVUXZIcVVZOXNvU2lOeUFsbWxq?= =?utf-8?B?eHZEcE1YamRrcWo3Q05qd1FRQ2k4L0IySUhPc2kwcHh4ODBmb05DUmczaDVa?= =?utf-8?B?ZWhtRmFVM0RZZFp1dmxLTXVhRnlOaERkSytyRWFkc0VacUpDZTJyZmV6V2hZ?= =?utf-8?B?NlN6SFM5OXE0Y0Uya2YvbmJkTHZOOUpEdWtPR2ZxbmNQUkZ2eDEybkxHYndG?= =?utf-8?B?TUJid0o5bFRRS01oVEpPang4QlFWbER5TjdVUnA4WHdQUFFQRy81dEtRQVZG?= =?utf-8?B?Z3lPTUgzWWRnNHdNM2dSQk5qM2psL0RZUStHWk02Q0lrTEdVcDhjbEpsMWlp?= =?utf-8?B?eEt6ZWtURUoxRy9CalNhemZ0NjUwYkJ6NmsxSy94d3A2dFdQL2VoaSt3QlRh?= =?utf-8?B?NVYyY0pBOVUxak9CUEQyNUI3cWQzYWR3eENZVHg3Y0JRQjFiWEJGRDBwMW5a?= =?utf-8?B?c0k5TytyaEF1TVhwNmZZNGNNV21UbEx2NTQxSXdBbU1BNjdPUHI4YWRucG5v?= =?utf-8?B?SFFRQXBLMXdqVUVFTGEwczc3a2RsaGtvdWJrd202THY3enhEMmpaZ1QwMkV6?= =?utf-8?B?QWFMWUVVUVNiQkJwREJPK3dPby9TL1FuRmZqdXBDR3lKeDlUV1hRUFFSLzJE?= =?utf-8?B?cUNNRGJRWG8xQW5XUjZpTmR5SmhBWW9PY3czTmkySlJsRUNaOG40Nk5CcWpX?= =?utf-8?B?WUliQkFXNFVDajBRa1B4eU83d0pGS251UDdZbU1nYTJyMmJVUU1oemRYZmlk?= =?utf-8?B?OElIalg0a2d4eDNVbHhNdUhOMTRPT09ZZFh0MXp4NS9jdm9RMEdibkVlSmZ2?= =?utf-8?B?M1R6aWtDU0hQdUhzUjByK0RsSGhOMURzclgvQUJDMDhPdWtpUUx2QTZTUGx4?= =?utf-8?B?V1I0UGtjSEd1VkRVT2hmQmlNMThDTFhuK1dwcTVEQnpTWHc5bkJOajAvdXNC?= =?utf-8?B?UjRzc3F0RVBOTy9RMGJVMHVnMTJUQllXMkFXVUlkb2J3RWFYNWhWMHlGNjVt?= =?utf-8?B?eHJaTENSVE1CT3VlK2g1cEU2TjV3MVg3ekZHcmVwc05hdkpuTklWTU1jWGw3?= =?utf-8?B?aXlrSER5dkd5WGpoWkVsdFNKSWpSOFdmeDJQZjBBN0NxamkrYlFNd2ZacGRK?= =?utf-8?B?eTJRN1hDdERQLzgwLzhudGRwNlFpR3VYTWpwdEVVK0ZTNEx2YXQvWkJVUmRP?= =?utf-8?Q?mkKiBXK+Lh5eXKxj9UMJgeEcg702PMPnox8KU77?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ee983a5-6ad8-4f29-345e-08d8f08caf39 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB4948.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2021 19:23:50.0009 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3EbD5LVK5LXK6FkmlpdawW74HJ8yiKLh7dAMXHmqL10E8ealiRFo/i8Xx0ydk39nR4C7a9CQYtz4KrI4d0qYhQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4899 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2021-03-26 um 5:38 a.m. schrieb Qu Huang: > On 2021/1/28 5:50, Felix Kuehling wrote: >> Am 2021-01-27 um 7:33 a.m. schrieb Qu Huang: >>> Amdgpu driver uses 4-byte data type as DQM fence memory, >>> and transmits GPU address of fence memory to microcode >>> through query status PM4 message. However, query status >>> PM4 message definition and microcode processing are all >>> processed according to 8 bytes. Fence memory only allocates >>> 4 bytes of memory, but microcode does write 8 bytes of memory, >>> so there is a memory corruption. >> >> Thank you for pointing out that discrepancy. That's a good catch! >> >> I'd prefer to fix this properly by making dqm->fence_addr a u64 pointer. >> We should probably also fix up the query_status and >> amdkfd_fence_wait_timeout function interfaces to use a 64 bit fence >> values everywhere to be consistent. >> >> Regards, >>    Felix > Hi Felix, Thanks for your advice, please check v2 at > https://lore.kernel.org/patchwork/patch/1372584/ Thank you for the reminder. I somehow missed your v2 patch on the mailing list. I have reviewed and applied it to amd-staging-drm-next now. Regards,   Felix > Thanks, > Qu. >> >> >>> >>> Signed-off-by: Qu Huang >>> --- >>>   drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c >>> b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c >>> index e686ce2..8b38d0c 100644 >>> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c >>> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c >>> @@ -1161,7 +1161,7 @@ static int start_cpsch(struct >>> device_queue_manager *dqm) >>>       pr_debug("Allocating fence memory\n"); >>>         /* allocate fence memory on the gart */ >>> -    retval = kfd_gtt_sa_allocate(dqm->dev, sizeof(*dqm->fence_addr), >>> +    retval = kfd_gtt_sa_allocate(dqm->dev, sizeof(uint64_t), >>>                       &dqm->fence_mem); >>>         if (retval) >