From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7270926561D for ; Thu, 12 Feb 2026 09:04:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770887053; cv=none; b=g0ps/+NFCs4HM0GD0fJcCgFgN2RFp6DnF4fYJtEOEhuNrz8/2pN+IEQCKDbbRQbRoVdfyAtAhyVb9zpqsigi70KhOI29r8Ssl7xc8FeKoFTzxM6S0NHbNqBB7KJ4d12Hu3I/ZPFZejh6+G9nlrzYRgzorn9gDnrLwH0TluTYCYw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770887053; c=relaxed/simple; bh=wr+uvPGTgsFxiVpyo0p6xmUMYMJsgW+dOg1Iby7z5BE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lAArj1GbQcM2LRHWtSQaN4CoRvwUNgAcbvqVqXUKzY8u08pPn4emdOFtZ1llLy2Lo+SGUQHUdUOwUNPLy+ib9ZzgTkx7ie7VnLEQhjzBj5r2Zc9GdAOlexVWVNae6tZ2TfaibQ3JehTEFWYtuQMip+xFkaJfKWRvhGG8DrTHRXc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mJPSZBi2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=U6XpM0gf; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mJPSZBi2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="U6XpM0gf" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61C3Rreb271979 for ; Thu, 12 Feb 2026 09:04:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= B0kcqtvA3ePB8KKYwiDSDXXTXzG7b7vVz14UKRtxCZg=; b=mJPSZBi2SRs62zNN izVIZFF5+TI6cdweIs2nA87GX+4vA0ao53Z2kZn9BMy0cpm2xyYhe3T2FtlXl09E hx+19aqhJVvLalcbaWYlE61/aR2+lnAQjQ/HJHevzt/JxngmprftgwqKzntifrLG IwzOyR2Zvta2M0uBvs3JBBPkW7yhfb8vLqmQsLTd1/44uLT4EqUXSp7G/GuFBzY/ tsh1K8o0ASGZ3DWpVoCFK277j7J+pvwa8KMyPy6sShW31WPAw7Il3RZ2hrO5AV7d PHpvy39BOq4sbNmrTd4Jr/XGeB3u7w7Tr2iGWvfMEauVZHxDrJBl2l7g/pkn8xbS J6vsgQ== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c8y9bt9wk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Feb 2026 09:04:11 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-35641c14663so4607721a91.2 for ; Thu, 12 Feb 2026 01:04:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770887050; x=1771491850; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=B0kcqtvA3ePB8KKYwiDSDXXTXzG7b7vVz14UKRtxCZg=; b=U6XpM0gfvMoHQ3sBjZVA9pkwktu4gjPd2xQDRyMwQ4MXgTM2fM1qBtmCy7TqxuTcR1 xlKB/P2EKghKBH2qq0Q2qqoaDgU3jcUTW98qVK5t7Y1cglKROCBl8h3X5WAsIciuIOrk AD4Hi+OwyjGKNfuLszv8ViGVQhC6VK+huh3Dbs5TZPeEyjBuXjmtSM/zxmw4uDLcZHFQ mOqt+cdvIlHvGOUQ0AIUb+PBY/QWb7++h3CudFwoE83NmSF8s5Ajs+/lTI+diNsTAUQb clhLByU7zZQQFpu2Dx3yhZ6B88wjdWOfMGI7W8KyUUpfoBhgaDud823CXnaa0D38gsB5 UIeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770887050; x=1771491850; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B0kcqtvA3ePB8KKYwiDSDXXTXzG7b7vVz14UKRtxCZg=; b=WnzJ4pbR3GS0e9LACEY7th3OfWxLL9rYKy64Rr3HViMmdgHen8NF3P1JmdB0qfH2GP k1Fsxx6cJV5XSntBdJsiVzDGkfadg+cRfU8l2/mnRZyH81UDsZUINaFtiRb2BJYNCVD5 3b7PDt09xjqaWSidI3p+IdY8KoCyYwPhDGGN8nKHfiR7JqDVBACWch0QGLFyzZSq1ZEJ Zdl2xUtGo5jkKMCLbZllsMzCf7/1B81qf3Gz+zzoC8be8eB3+lGEvSV0wkEDXYUTJasD AdwWOJbNqYCPGQuRbINnMipBUIJmjOW+3UKakM+U7vQCRpbQMKxPAY0D0czwbQHCuWgF ft/g== X-Forwarded-Encrypted: i=1; AJvYcCWZXKijnBPACzZoNaIFuZFrlimrv4NUdcZWE+hElCI0PZ5KS8ZDG4e/dLDB8hONArrsQcAEQZlFyTxyDwQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzwvKcNWPs/CnyGQGQRqunzAowYUn0ue07x0dgiGuR6B2QqLAd8 283QztnVgukB66YXuokC1RX5hi+H0Ndtf7VtshC8cN7r5rseAz+EmvUV/twyLYtzMoAIIiDdlxp aSVwTFWy8XndYm8CH+XZnL0VOlXjb7ozAzlZzhZY8LijHwH7et5mm8y106J7PxWIRA4aN5v65He I= X-Gm-Gg: AZuq6aIK/5jBzLTc9wEoPnUAWwJHCu9OVHeIwawgGZCrjz1w50yrEut52K4eCTW57nF onIXTbLKSgnDLRGo0TBpCTFV65Sqi6YrsX6YENblVIrVxZ9Iib5gGQKX4lKU2ROc7siylHzHWzn d0YnkYPMYgR4MmDMyjdL8GpnN4SCgQwpSrWfEfCDrt2REhUUi0HZNxfnJtj12EPfu4kVtifZ0nW ruvt9UZLOsfmlcWSpAztW4uGNp6NzqPsY5A7vzrhx9tWVt5k+cpOWKfJEraC+6gAM1ouEtbM29S 1/xmUYjIgK7gDsJdeg7VvmX2LxoYGXk6/Vmteb2h/3IHRf7Z2falb8FhyoKLebjX8x0sojuRtFe NNbeX1ESmgcP4Jq1Cw4lCV3yO+J6fcUceyBwkO1whGvdtp7pVnhrdTuhDu9gq4rt5+Ke1LW0GgG InEpZSaj/OUwl1QyNF7w== X-Received: by 2002:a17:90b:49:b0:341:8bda:d0ae with SMTP id 98e67ed59e1d1-3568f3e103cmr2276263a91.20.1770887049924; Thu, 12 Feb 2026 01:04:09 -0800 (PST) X-Received: by 2002:a17:90b:49:b0:341:8bda:d0ae with SMTP id 98e67ed59e1d1-3568f3e103cmr2276226a91.20.1770887049311; Thu, 12 Feb 2026 01:04:09 -0800 (PST) Received: from [10.133.33.213] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c6e1967c884sm4457244a12.7.2026.02.12.01.04.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Feb 2026 01:04:08 -0800 (PST) Message-ID: <8dbc18a0-6a64-491b-84b0-ba220c9050ac@oss.qualcomm.com> Date: Thu, 12 Feb 2026 17:04:03 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] phy: qcom: edp: Add per-version LDO configuration callback To: Konrad Dybcio , Vinod Koul , Neil Armstrong , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260205-edp_phy-v1-0-231882bbf3f1@oss.qualcomm.com> <20260205-edp_phy-v1-2-231882bbf3f1@oss.qualcomm.com> <200b055b-7221-45b5-aea1-2462e07a3c1c@oss.qualcomm.com> Content-Language: en-US From: Yongxing Mou In-Reply-To: <200b055b-7221-45b5-aea1-2462e07a3c1c@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=BbPVE7t2 c=1 sm=1 tr=0 ts=698d978b cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=MeP4MrRKjM_wGNXPxAkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: aqBItcYY96VWVQmhcmiDASfRCcUKqzou X-Proofpoint-ORIG-GUID: aqBItcYY96VWVQmhcmiDASfRCcUKqzou X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEyMDA2NiBTYWx0ZWRfX6xbkZZKihEZN 3l+3NtPswl+uiR+9dXqIF0RisahOy8RQvsOUV2PCqpEi/NNj2JonmApxmGpA4detlfOlMJm7/QF vHLjFxlgi1XBrLIezB7aoBfgPZVyQ/RdMPDM6/BzVznTZqkHFG3RhSWx0F8yAZ7V6V3MtMkA8tf kJ+IOTnPdGp/oLsEXrGYRxHiN1+kD0NcPNwfVwsF+Vvqg9tWbAqZlv8jXQRtYgnfmZhz3BuKcTB fMDlp4zcRkkciEZk4B4+0aPcObzJ/hqB09ewYBCFDEqWp/9PyNx9v9oq+A6i6y4BnjOlOgCtAOq Ek9qyPpQg2v99nB0oqvbO/bEoMy0naFovb4Lt2yt8mY4pJNA6zSEbeEA5WDQHnCS0dtNjOYKkTF fnPHX1Dn7BSdw2lPka1niB8arvhvhAjY5RNIsgXKXZWimkTKWeKjdaQqi86FJj3QbGNwafHgADK TLJMOJuCL2noely+D4A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-12_02,2026-02-11_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 phishscore=0 spamscore=0 impostorscore=0 malwarescore=0 suspectscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602120066 On 2/6/2026 6:52 PM, Konrad Dybcio wrote: > On 2/5/26 10:20 AM, Yongxing Mou wrote: >> Introduce the com_ldo_config callback to support per‑PHY LDO >> configuration. >> >> Signed-off-by: Yongxing Mou >> --- > > [...] > >> +static int qcom_edp_ldo_config_v4(const struct qcom_edp *edp) >> +{ >> + const struct phy_configure_opts_dp *dp_opts = &edp->dp_opts; >> + u32 ldo_config; >> + >> + if (!edp->is_edp) >> + ldo_config = 0x0; >> + else if (dp_opts->link_rate <= 2700) >> + ldo_config = 0xC1; > > lowercase hex, please > >> + else >> + ldo_config = 0x81; >> + >> + writel(ldo_config, edp->tx0 + TXn_LDO_CONFIG); >> + writel(ldo_config, edp->tx1 + TXn_LDO_CONFIG); > > tx1 should be dp_ops->lanes ? 2 : ldo_config : 0x00, in all cases, > I believe > > Konrad Hi, here i want to confirm again.. In the HPG main link brinup sequence, it not say write TX0/TX1 ldo_config based on the lane count. Only when we switch the lane mode, the LDO config will be updated according to the lane count. so here do we really need this condition?