From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D7A83E6DD0 for ; Thu, 23 Apr 2026 12:59:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776949151; cv=none; b=K+kWKsIkVNd+9HzV7sXnl35jjl+sk2r65/HflxyC0TLYVOHiPd9+VI6cydK10jx4NNiPAJsFgNxxUKcT6oxRMWdcKx0qd4r+vllaN70dd/imoquZ4zFnWBk7jXnTMSbKjGAnbEP23t6dNPTkbXkUOKS8/63ssc7Bhq54p1QuHRo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776949151; c=relaxed/simple; bh=OsI1m7bmguFYLsOilvXfOIKS7Ehn5i/JY54eFqXkK7U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DchkYpUs/N5fhJhn3ohfvOPGmO5flxAeYlB1zBdKGRPlVwS8QzStioCd3QOXwCS3Kwa1MaGv/lOn8VJIebGe2dy89BRxiKCEWCf+OD51PhimHxP4ivwaNADE5WdC9WF4H3RGckdGuDNolJPJEjYlNwPrnlnCcJiO/QrRsMpLHHg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IZkaP6OV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MrAiu++4; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IZkaP6OV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MrAiu++4" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63N8u9cZ366400 for ; Thu, 23 Apr 2026 12:59:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bv9bbK3CKQV4FRe3nxG0ooKvJtI+iyyOSwnESk6M1pQ=; b=IZkaP6OVsVbNMI52 6Zu5pQTF4POab3jMfmKbS2z0fWqdwQktsDw8oPstJOp/TWMQsZFQaGaDDnn0Spvi TB9jCwBXMVsdbAQxY0XDfXkv2eRX/fNHF9j6zIUoXgILUqJFzGGailjlsRX6PirO Nk0piNxfu74byXz9mAgn4cii47l9IcMjlcjSF40X9vozX5AF9aAQcnEiVlovLSc0 PS6b7ExhK/3G61iwson7Bo3O4zQSnWnDfbKkJdHhfINgdchVmeGgOpBcgQ0zU17W +0a5j3vQFJ0JGFM3WSPKR5e6z9qxCYe8T1wl/f3nL9NwACpxPWQwGOXRrVK1no/3 AtqCUw== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dq35rbhx4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 12:59:09 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b2e6ee9444so73845705ad.1 for ; Thu, 23 Apr 2026 05:59:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776949148; x=1777553948; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bv9bbK3CKQV4FRe3nxG0ooKvJtI+iyyOSwnESk6M1pQ=; b=MrAiu++40049P9P/pxcZ3PBkeiZemGnyRkEv4NR0eA7JIhHUHF6pzBxHBqcFCECw+w q6ZKRZA/jlWr1XtKtti+9g2EyCTwOc7OsFu0/iN7s4KvpVBdK6LbKN3V4EvWSoyhszdK mTOy18KDwdYlwBtNpDujupYZQ+H/1335dxq4HlTwRVPStLLqBdFgp85QSwz6csZjTQkG d4aEkp2raPVActLgmtYDqDGPPaqmsAJAFU+h1ZD/7624bIldEbGFv//W/H5ym849JxYK q+beTIyr1xjg9Q2+jaoMpFpBbEUGsY2NHM/EFbTJfk7D5i00ezhvNpYK8pNDTwxlaTkM nqiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776949148; x=1777553948; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bv9bbK3CKQV4FRe3nxG0ooKvJtI+iyyOSwnESk6M1pQ=; b=DoNKbwJ/7uJP/PH76YIOz+LxDHVOaiRFl3zuk45udiHrMoNwxhdVZpXPrLsS1jwJlt twDvxE7DVG1A1fq8Q0BwCKzvmnQZPckfKLL6FK9YZzEN/8J2jVKyatZ/ezKqtAd2UqNL tf287IY+KcmctJqYa0N8x6EruMY6RtrMaXYmL4nvbr/UvvvQ0dw8raUyad6cQJbZ+djh 72FQCFwPxv1Iq8YUu1+3QVdMZ6/En5QqIg22GmTxNmqi5YpcTHi35UtuLQM9l22Wt44H jsoAxvlKoXGVNWM9vvXzk5Reg20XjYwI8dVU5KwHb51A7RsWXY6dMSyf0wFpFicqhnJg GWMQ== X-Forwarded-Encrypted: i=1; AFNElJ9vByUCrhhVHdt5XYs2awWThhnX3EJ69v9WY4n/2UxsSDNhzQr3FMFrncT6z5qXyqe+yu0wav5brBjsxMg=@vger.kernel.org X-Gm-Message-State: AOJu0YxK0O5VZYrkizpH/ASjfEmi5lnkTB+WVCzdOgxkH8MWBggvcKaB lWyhlLA7zzKpJQoGaHcgjpgCSyjYbYmywAwha96T2pGFqONRuZv2c9LxN1VK/b5WFPf1bLyjlZs ZymIvgU/tHR1cN1oIE30zwMnarz2EToo+HYu6NaYomf7YyUmHlvLpypmQ6Uog+eJD13I= X-Gm-Gg: AeBDietTJZmaGfaj6zBVKhNEtdYsdYZoKV8W+KavPSkkMQ2uc3nsiOxg7+anacFtTVR yT71HbHxSyLEgwAzIdj5K8agqvFMu4BdGclMrjP+rpd8ekhK2Twip2/MpkqQondrTVTdLSkgVgb 0fjh8vDglLdfWTl5Hb6qr1WDek6IQiwNevUkb2GsANcX3BGEANH8ue+5gCpjowvMdPTA92NEvO0 OhIYZc17+QM9lwgcndcQDy1i7SVfBpCoKRJGu9FWdv6vfcNSMPPQMwEL6hUvoSZyW0+QmgUGSaV eeQxQWOTllsVECrZ9D8CIzh1jht+I3kqyeIC33FsfRdTIcI94/dMM5VZ6UlFNNos1z+Mfh4bZ1w RKHecQyCLWDkNX8Fra7q7qAy7+Xnf9T4lUI5+WdxX2sSAsTFY69nyWzZUcMPNjAH2ObtjNMwrv4 IeWeEXglatrgxUbrYHtE6u X-Received: by 2002:a17:903:3d4c:b0:2ae:cd8c:bd04 with SMTP id d9443c01a7336-2b5f9dff810mr171174735ad.10.1776949147876; Thu, 23 Apr 2026 05:59:07 -0700 (PDT) X-Received: by 2002:a17:903:3d4c:b0:2ae:cd8c:bd04 with SMTP id d9443c01a7336-2b5f9dff810mr171174425ad.10.1776949147410; Thu, 23 Apr 2026 05:59:07 -0700 (PDT) Received: from [10.133.33.37] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab0cd18sm208610625ad.45.2026.04.23.05.59.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Apr 2026 05:59:07 -0700 (PDT) Message-ID: <8dc34d3e-65e8-429d-9f68-b4cbd0d4b789@oss.qualcomm.com> Date: Thu, 23 Apr 2026 20:59:01 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] scsi: ufs: core: Introduce function ufshcd_query_attr_qword() To: Bart Van Assche , avri.altman@wdc.com, beanhuo@micron.com, peter.wang@mediatek.com, martin.petersen@oracle.com, mani@kernel.org Cc: linux-scsi@vger.kernel.org, Alim Akhtar , "James E.J. Bottomley" , Keoseong Park , Daniel Lee , Ram Kumar Dwivedi , Huan Tang , Liu Song , Bean Huo , vamshi gajjela , "Rafael J. Wysocki" , Adrian Hunter , open list References: <20260419135229.1036926-1-can.guo@oss.qualcomm.com> <20260419135229.1036926-2-can.guo@oss.qualcomm.com> <316c8b28-9e93-4d14-b6d6-e8d593b8627c@acm.org> Content-Language: en-US From: Can Guo In-Reply-To: <316c8b28-9e93-4d14-b6d6-e8d593b8627c@acm.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDEyOCBTYWx0ZWRfXwc4y2WDWiko1 D0nQMxqXV6+oKmu2iXLJqoq+5J8Qx5JWi3zOfFFX7UiI/G2pZWMENqdI4NyyqW8XqCnYJJBPULw uKGhrEaCbLOZSKan+t9UfdPvQ9KduTks9lowlpFaJur8Ef8+KzBMr5tWFfGovYhq7VuJYAv/guz hSG26G+8xedyJ4ZtOvGYtk7caWwCuNnCQw8hYmjv33dvX1w/HC2oH+J45QT6tGQW5ma+Se+a+tL 7hBzbvOWhkyNvlNhfJfU3YuPWuw3VHNJUOngo+7xTN18jqdmkKuWFfd6kav2DnVv3JzxTzNiytD e1rxJq2bhblZzLLcTEHEP+8DI6L6MAiyf7Pv/MS6CmVQ9Ma7hL5xTgAX2+dQdmf5Ed8VaY16dr1 heSBn/FB5/JzIj6rk+fjyj8mGqdkManO4cRy9Hc30mBu2DrfWf+nvEI6RsxC3EKsHq3g8ouYRmD s6qRQO7EwdAmWYv4vsQ== X-Proofpoint-ORIG-GUID: Y5-bidtaOWa_eNHRoqPusDYr2_gAIfg- X-Proofpoint-GUID: Y5-bidtaOWa_eNHRoqPusDYr2_gAIfg- X-Authority-Analysis: v=2.4 cv=f5J4wuyM c=1 sm=1 tr=0 ts=69ea179d cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=V8bx_qqBVzzULFL9Z2sA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 phishscore=0 adultscore=0 malwarescore=0 spamscore=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230128 On 4/21/2026 12:58 AM, Bart Van Assche wrote: > On 4/19/26 6:52 AM, Can Guo wrote: >> +static inline bool ufshcd_is_qword_attrs(enum attr_idn idn) >> +{ >> +    return idn == QUERY_ATTR_IDN_TIMESTAMP || >> +           idn == QUERY_ATTR_IDN_DEV_LVL_EXCEPTION_ID; >> +} > > Please change "ufshcd_is_qword_attrs()" into "ufshcd_is_qword_attr()". Done. > >> +/** >> + * ufshcd_query_attr_qword - API function of sending query requests >> for quad-word attributes >> + * @hba: per-adapter instance >> + * @opcode: attribute opcode >> + * @idn: attribute idn to access >> + * @index: index field >> + * @sel: selector field >> + * @attr_val: the attribute value after the query request completes >> + * >> + * Return: 0 for success, non-zero in case of failure. >> + */ > > The word "API" is uncommon in the first line of kernel-doc headers. > Please remove it. Done. Thanks, Can Guo. > > Otherwise this patch looks good to me. > > Thanks, > > Bart.