From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB6243382C5 for ; Mon, 23 Mar 2026 06:36:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774247791; cv=none; b=L/OB4O6gOxkG9oqPxdCLBof6BOBmzDITOi23xpo7dklga188ohJaS4ONibeZ9CtrRZVqE/lXIZFZuqoJIIiN5lfQbEflrbbGVSAlGzEGr6PrOvb0wQWvRRF5KhkpoJkmcR4+24AKtcOkM7FIKbzUyUMR+pXabwASmo/jHgSMxPA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774247791; c=relaxed/simple; bh=SG55dzYNEevyi4u6lpN3KXChXwdHwXvdMoHw+IIIM/c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GfqKhdiaufMM4nS4mo71SLa0C2G3FG3WL4R9013HH1mUf/r3pkxrguOa+zJDw+Dnl+R7ACKSt+Uh0avBaYAv5ulTYyIaZtEkSdnsjkgCZasfRG3oJnEE5sLKMYAWV/pqKv/ZPJQMbR2Eddk1PGXK6Renrsg6zJ34FchahpGFWoQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=S7JyucPJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FpX0NPFg; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="S7JyucPJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FpX0NPFg" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62MKoP9q424220 for ; Mon, 23 Mar 2026 06:36:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= i9H6sI3queRR62Obn9oreIe69+sv8Bk0hdBxZVqX1kA=; b=S7JyucPJ7OvtzENo 6c+ZxkU8+BWC7ClUvpvadwVGLUYf/CphfDcU5qMDJztIg5FKsearzB1NB8+gp2gP ftXWyj5lG9ZXb+tAFh7UPJAVTS24HfCklSH5DAHreuY8H16yShSHwZGNsVZBseQh UebdX/X87BmRQZlo1xLT+uZFeTig97XSo0mMSzTkYcv4u59fKQfBAA9honcZWJjj R5QMAaNhkjyflg1FGzzO7VL4LLYx2NWWBTp9M5yD0qKulX8u8yGpF5JvseVhAM94 DC5owU8bR3WrXFwGB2q8ObNaVdk6YZGmc7zO3hT2maAOaXVPWqYh0LpaBu/0+ZMz 4T2vmw== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d1jwvm2h6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 06:36:27 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b0565d77a6so50566025ad.2 for ; Sun, 22 Mar 2026 23:36:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774247786; x=1774852586; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=i9H6sI3queRR62Obn9oreIe69+sv8Bk0hdBxZVqX1kA=; b=FpX0NPFgUHBklKB1YwVrorB6Ty50mUNCpbPrMjP7OPz2n6WIatbKS7mKFTbFltenIv H2GG2GXIeb5Lgi7XinqSm5oLg8N0HXlVzSgO97+iQTe4i4eEWZWZA6MGvaZHDSrHZRjb 0gSTwigDQBXVRx/hHTIfthoSI3NGDOn71gP5o5aTnChCTQ/7wex+8kVLw1yQOV14NFgc JbKlrVNXRNRt8ALoFR4tLPRpRePQyg89bCSOYYL29YHBsIm7RMu6u4Dn4WMY7g0CJgCq qX3mowPNlr6Xi/nx7wJdUabtgFwsPv1wD0/ATItFv8qruh1JLLdhfac0lu3orNl2XNtc 8Xxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774247786; x=1774852586; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i9H6sI3queRR62Obn9oreIe69+sv8Bk0hdBxZVqX1kA=; b=BiKu5IcKv6uLNvqWgJ+YbCvv/6TG1AkMOGAAUQ5oeBdgRJJwsAM0Tu6SI3hJZQyBmy 6r6R0f8bjNYJMjcTGj84/tJNqjb21cZXS4TBrF+cyEEIXIAS/0roRRNUkA7a153i057+ 6TJgvFDeytpR9Z4NhazPM8wvr/xHYtmyvdSa2xlQeZSGAECP461aOlWC/SJCevSsCvAk TYsSFsOCOPAptGK7PG2PZb948E6kpwdG5hZC7BCnodmiqsETn9vVcAncOn1eHYCLUmWF 0Wir2aQPcLh+IlZA5K5dEav8u8ba/Tq9y2jUhEdrgFMY8j8tumVPDMfEJ2S9Izjz4hX3 Vang== X-Forwarded-Encrypted: i=1; AJvYcCVv7eJuAPzFe3888axc0B0FmTNXB6rm8YUxKyaE77Yy8cM+sac23Hk39UftvDJYs3c2XQrrlu2HSx6bIRo=@vger.kernel.org X-Gm-Message-State: AOJu0Yxam77CxY5eDoH/8dli/OFsKvLc9NNS6rP4QrjyV0sGQi5YGP+S reyHQKNC4jpqkQrfiAN0beWAuaT77NJ0yqK+o8N3ugTK1RkvbQzkM8Mk6b2zSXpv566npnVAR7Z k0oz+8gTT0ih9tmZP6yTVkbT6DFgQnTpSzzRFP0UJpq/key5Y3jrkx4mJUGlPAB+4gK8= X-Gm-Gg: ATEYQzyHz41glNuaFZWsWEiw4sBnDx9Qo5VHG3jhOY9Rp/MB/fpHeNhrKwlLyiDyPOl zLHW85D68cvoHzSHVeZaweXGkTubuFbUbgIEFOGl1hcUyZLV2uho8Tjt7MyRfYsIzGFyJXYr6du uwkPPzN4qBbeMqN/9YaVN2MT4L7HxjzDRFqz7RHA4a7pLcFT5cHKcPwD51Tgy6HXaGLpKjNkFwV y+7/dHdWq+MIGyPeI9QEkjSeNG/xOp+1QGCvoCkOT7nKLPJu8FabUiFfIaMqGD5IMdhtGTT7Mk1 3a1K/Vhqc/Un/hNP4vrnyfJFW0vxZDBc4JAfL/pzV83xIm6ynkvHacFp40MtOjpMCahEwQbCKWd T5Wm9Z1nIMx4UieH1VbUJiz3X2jEaOY7lqc2mN21ksoXniziozURhJQ== X-Received: by 2002:a17:902:c405:b0:2b0:4f82:74ce with SMTP id d9443c01a7336-2b0827bf173mr109718915ad.46.1774247786512; Sun, 22 Mar 2026 23:36:26 -0700 (PDT) X-Received: by 2002:a17:902:c405:b0:2b0:4f82:74ce with SMTP id d9443c01a7336-2b0827bf173mr109718645ad.46.1774247786017; Sun, 22 Mar 2026 23:36:26 -0700 (PDT) Received: from [10.0.0.3] ([106.222.233.113]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b08366c4f1sm97059195ad.59.2026.03.22.23.36.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Mar 2026 23:36:25 -0700 (PDT) Message-ID: <8dc65781-9a0d-6c26-dae8-74bf6ec1854b@oss.qualcomm.com> Date: Mon, 23 Mar 2026 12:06:20 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v8 07/11] media: qcom: iris: drop hw_response_timeout_val from platform data Content-Language: en-US To: Dmitry Baryshkov , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260319-iris-platform-data-v8-0-55a9566ebf60@oss.qualcomm.com> <20260319-iris-platform-data-v8-7-55a9566ebf60@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: <20260319-iris-platform-data-v8-7-55a9566ebf60@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDA0OSBTYWx0ZWRfXyazlM21M1RJ+ hP2x3sydQBqq8nPJwEbrzYQC+VDwax6vpbQz8QBkc/wBoApleOMRAAIbKgn0y4EcR3TfsjlFHus A6imwSB4DrDX6NG7JxNYb/VH7ZOen5gxsMPt+wWCU52UECvUBh3c60Q9i8IWW0BrTlRJhe2JFU1 93ItdG7PIDwYjZ6giXVd5pDC51bfUKdIf5XQyNRITnk3928EVPq73/D6Z3tHVF7KBkpaITYERZM 5Wg7G+hcDk5z+DbtxuLuw0TQJo/gz7pqVRZyZuGYxHUnHhflaXCiob9eZsHNc75fB/rDByn3n72 sKNcu8VlikBnHJQvjENlVIZuYUzIx9BjO2mfGZghz7wX0xtPdIMlfdzHWpaZCDkiaO68+TG5Wd+ qUZ39CnsJ/DYvD/KFIZeX5ZPJviKQ/4mVvygE/Ph9DVq++fEVZJuBCrPkjGOiNsGFq/WQ5N8XH/ n50Px1i0ZGuXO93Vztg== X-Authority-Analysis: v=2.4 cv=bcdmkePB c=1 sm=1 tr=0 ts=69c0df6b cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=hbzS8gabZINpAvasuVNEhA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=ERqvkBjMsZt1UCBLgn8A:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-ORIG-GUID: 6UK99I1P4QEmOWhDTmiRAE5o3bwDtpuI X-Proofpoint-GUID: 6UK99I1P4QEmOWhDTmiRAE5o3bwDtpuI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_02,2026-03-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230049 On 3/19/2026 11:29 AM, Dmitry Baryshkov wrote: > The HW response time is a constant between platforms. Remove it from the > iris_platform_data structure and use it directly. > > Suggested-by: Vikash Garodia > Signed-off-by: Dmitry Baryshkov > --- > drivers/media/platform/qcom/iris/iris_core.c | 3 +-- > drivers/media/platform/qcom/iris/iris_platform_common.h | 1 - > drivers/media/platform/qcom/iris/iris_platform_gen1.c | 2 -- > drivers/media/platform/qcom/iris/iris_platform_gen2.c | 4 ---- > drivers/media/platform/qcom/iris/iris_utils.c | 5 +---- > 5 files changed, 2 insertions(+), 13 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_core.c b/drivers/media/platform/qcom/iris/iris_core.c > index 8406c48d635b..e6141012cd3d 100644 > --- a/drivers/media/platform/qcom/iris/iris_core.c > +++ b/drivers/media/platform/qcom/iris/iris_core.c > @@ -28,14 +28,13 @@ void iris_core_deinit(struct iris_core *core) > > static int iris_wait_for_system_response(struct iris_core *core) > { > - u32 hw_response_timeout_val = core->iris_platform_data->hw_response_timeout; > int ret; > > if (core->state == IRIS_CORE_ERROR) > return -EIO; > > ret = wait_for_completion_timeout(&core->core_init_done, > - msecs_to_jiffies(hw_response_timeout_val)); > + msecs_to_jiffies(HW_RESPONSE_TIMEOUT_VALUE)); > if (!ret) { > core->state = IRIS_CORE_ERROR; > return -ETIMEDOUT; > diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h > index d1daef2d874b..e8a219023aaa 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_common.h > +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h > @@ -232,7 +232,6 @@ struct iris_platform_data { > const struct tz_cp_config *tz_cp_config_data; > u32 tz_cp_config_data_size; > u32 core_arch; > - u32 hw_response_timeout; > u32 num_vpp_pipe; > bool no_aon; > u32 max_session_count; > diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen1.c b/drivers/media/platform/qcom/iris/iris_platform_gen1.c > index 9925a893b404..6ed4c4ae4056 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_gen1.c > +++ b/drivers/media/platform/qcom/iris/iris_platform_gen1.c > @@ -361,7 +361,6 @@ const struct iris_platform_data sm8250_data = { > .inst_fw_caps_enc_size = ARRAY_SIZE(inst_fw_cap_sm8250_enc), > .tz_cp_config_data = tz_cp_config_sm8250, > .tz_cp_config_data_size = ARRAY_SIZE(tz_cp_config_sm8250), > - .hw_response_timeout = HW_RESPONSE_TIMEOUT_VALUE, > .num_vpp_pipe = 4, > .max_session_count = 16, > .max_core_mbpf = NUM_MBS_8K, > @@ -410,7 +409,6 @@ const struct iris_platform_data sc7280_data = { > .inst_fw_caps_enc_size = ARRAY_SIZE(inst_fw_cap_sm8250_enc), > .tz_cp_config_data = tz_cp_config_sm8250, > .tz_cp_config_data_size = ARRAY_SIZE(tz_cp_config_sm8250), > - .hw_response_timeout = HW_RESPONSE_TIMEOUT_VALUE, > .num_vpp_pipe = 1, > .no_aon = true, > .max_session_count = 16, > diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/drivers/media/platform/qcom/iris/iris_platform_gen2.c > index 10a972f96cbe..abe523db45c2 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c > +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c > @@ -936,7 +936,6 @@ const struct iris_platform_data sm8550_data = { > .tz_cp_config_data = tz_cp_config_sm8550, > .tz_cp_config_data_size = ARRAY_SIZE(tz_cp_config_sm8550), > .core_arch = VIDEO_ARCH_LX, > - .hw_response_timeout = HW_RESPONSE_TIMEOUT_VALUE, > .num_vpp_pipe = 4, > .max_session_count = 16, > .max_core_mbpf = NUM_MBS_8K * 2, > @@ -1036,7 +1035,6 @@ const struct iris_platform_data sm8650_data = { > .tz_cp_config_data = tz_cp_config_sm8550, > .tz_cp_config_data_size = ARRAY_SIZE(tz_cp_config_sm8550), > .core_arch = VIDEO_ARCH_LX, > - .hw_response_timeout = HW_RESPONSE_TIMEOUT_VALUE, > .num_vpp_pipe = 4, > .max_session_count = 16, > .max_core_mbpf = NUM_MBS_8K * 2, > @@ -1127,7 +1125,6 @@ const struct iris_platform_data sm8750_data = { > .tz_cp_config_data = tz_cp_config_sm8550, > .tz_cp_config_data_size = ARRAY_SIZE(tz_cp_config_sm8550), > .core_arch = VIDEO_ARCH_LX, > - .hw_response_timeout = HW_RESPONSE_TIMEOUT_VALUE, > .num_vpp_pipe = 4, > .max_session_count = 16, > .max_core_mbpf = NUM_MBS_8K * 2, > @@ -1222,7 +1219,6 @@ const struct iris_platform_data qcs8300_data = { > .tz_cp_config_data = tz_cp_config_sm8550, > .tz_cp_config_data_size = ARRAY_SIZE(tz_cp_config_sm8550), > .core_arch = VIDEO_ARCH_LX, > - .hw_response_timeout = HW_RESPONSE_TIMEOUT_VALUE, > .num_vpp_pipe = 2, > .max_session_count = 16, > .max_core_mbpf = ((4096 * 2176) / 256) * 4, > diff --git a/drivers/media/platform/qcom/iris/iris_utils.c b/drivers/media/platform/qcom/iris/iris_utils.c > index cfc5b576ec56..29b07d88507e 100644 > --- a/drivers/media/platform/qcom/iris/iris_utils.c > +++ b/drivers/media/platform/qcom/iris/iris_utils.c > @@ -55,16 +55,13 @@ void iris_helper_buffers_done(struct iris_inst *inst, unsigned int type, > > int iris_wait_for_session_response(struct iris_inst *inst, bool is_flush) > { > - struct iris_core *core = inst->core; > - u32 hw_response_timeout_val; > struct completion *done; > int ret; > > - hw_response_timeout_val = core->iris_platform_data->hw_response_timeout; > done = is_flush ? &inst->flush_completion : &inst->completion; > > mutex_unlock(&inst->lock); > - ret = wait_for_completion_timeout(done, msecs_to_jiffies(hw_response_timeout_val)); > + ret = wait_for_completion_timeout(done, msecs_to_jiffies(HW_RESPONSE_TIMEOUT_VALUE)); > mutex_lock(&inst->lock); > if (!ret) { > iris_inst_change_state(inst, IRIS_INST_ERROR); > Reviewed-by: Dikshita Agarwal Thanks, Dikshita