From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 662932DB795 for ; Tue, 30 Jun 2026 15:06:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782831983; cv=none; b=dgkdfX6GqzCBDCymQ1MwUsLwfU9TtvwtMVD/7ryZ6B4SHu6/Kr6t6Kdrdn6X0H8Ry5Gpw5uLsZy4JXWgFOxRTyHW3N+Ko/oGQCvyxZOmL2qoWPi1IfJe/CftH03z8dy9vi7ow2arSbsaEnJIWU/nLABibM7l1d42OQ7Ug6/1aEM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782831983; c=relaxed/simple; bh=tBVYYckRP4d98f9cneFiFb4yQf/dFJHCosDHcvrcfUY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=X6VWUsi6xvOcULkhp5hvEOwdFvWHJXWtn+ZXtoWu7YaKzl71pS4YGTx4OuwrBjxtB1QQArGuvG0fZ6nGKAjjnIknsFRPAAILf381OBsvRp8MURTsivvA53Ze7dUz/gQWaNse+HbHflCZSJRs938XoydysZZl2Ovdjygk1Sq5LoA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=h42Jucuu; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=S9G4O/tU; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="h42Jucuu"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="S9G4O/tU" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UEDWMR2116493 for ; Tue, 30 Jun 2026 15:06:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= urrKHuOuZqzsOMcDEsGR2fyzmoC2DHEP0l8VP4d1anU=; b=h42Jucuubd17xgvs KQxP2WDCrL/z0x1wHr4prfhhtUeV0F+PhGqKWirWL9Z3eLFfZ/OooLFajA4+aOes 9TZ+pf0JpmVMyxJT3U9NKCBTI976wd0JsgmknnqpVrGRetIR6abIAa+IuI05oxsE VKiAybTDsGeo7drM0ab2RHXarOEbs32HXhdOnwrv9yrzyIos3vYmRN84F5vLEC1e jIm4Wgr7e/SReX+LxEXj+UBWPcKbEEMStej5QoVJrXly+iGN0EAd2qojdVnlbkOc CDE7iujmN1Nnb8HziKFx66IwFYK75GU26nczgHswp0aIjzNRX9yi6YjnLMqq2Go/ IYdXiw== Received: from mail-dy1-f199.google.com (mail-dy1-f199.google.com [74.125.82.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f3y9j46ke-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 15:06:21 +0000 (GMT) Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-30ed9113e03so279439eec.0 for ; Tue, 30 Jun 2026 08:06:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782831981; x=1783436781; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=urrKHuOuZqzsOMcDEsGR2fyzmoC2DHEP0l8VP4d1anU=; b=S9G4O/tUYknnxOrg4jIdN5DXh2mCu771dxxLiE6EWcGMS4W9JOrnHdeQ0ykX0YHobJ 8aE+mj2FMUzY7CPGmeU5I5hXSn5rdxXWPuRjyGdKr8rMNNhZVIUcuNcSye1c3xff2U48 KX/SNq6ydpLPsuEG+gxxK2pPYZu6+4uGgEP4pTZ/XLwSX+ZV7xgcj5cSXVli0kLNJzM2 JyGQ+/q/OJvCAQEBJsXaPJDDTi99jVYchcfQJ3eK0fkJ+J/RfjGst/RefsDvVTTz0h5K q3KLEmNdxssYLsQeXKyS39nB0dz1jart8bzlSpWat5OUNdEWiq4GvPHTRNGn0lzQ6SrF 7zSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782831981; x=1783436781; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=urrKHuOuZqzsOMcDEsGR2fyzmoC2DHEP0l8VP4d1anU=; b=OxvjK9fE4fGOlVvDsU6QsVKtg9w/lPMWlpU9Ebzv/xCGUH4yeF1lwAo2U4bmTLZm0G 4Ysv7dniaPs1D7hUMeuHCERjJKuxYroYla0hkTBUzyIa5CVcDy2wpKywX8E88KNNswiO P0ZcogHTFYEa+sHS+EaAwfI6s07XQEz1FgjB3gA48IyYnvYoS0RsD5mVJ4menCqZ7TIX qbgmqOjeMKBvGoS5P71r9vd0ixrTSxkVN95Gg2ebC5/fgmXK4Gw2AYomPELgjCOzQkWI /9SSPBSjGscbvF+UyO/mc5dUXMyohrHyAkHbCgfC31FbRzvkTdD1WuHndUZGOIApVrzl XR5A== X-Forwarded-Encrypted: i=1; AHgh+RpP451eGrp3ZYOKSggqTg3ES8ZO1yliA+ir0tFqfMwOjJZC2X0CEO2XOo22oz6Rz7wfqmUXlfCdYXXh/yM=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+eKtIVLgGGdklqsWTJm21/JDS+WCVeRYOiT+hlNPRbTDvP/7y EAgNkaF569EUQfr/yWGakI2iB/bYa3KbrIxsuj0KaagBnWO0Q1xVD2wl+5VxOibA9PjL2ulyhEG rsEBlN7MiwygpBFXTjl2mfIhZQA/+niJcVwpP6u0JYXEg/Bx//sniHWpaWGd4CxE5l8M= X-Gm-Gg: AfdE7cmWwMDl1kYZX/mU1JAv5tYRTPUH+4I3/u2ZhRnLCpEwb98YTcDoaorf6SUOaEh rdlBcHqgSI+Xa1Xu3dwAM2uVMg1M7b4ZQvQ2AbqQoJFzyAm54q5FibJPijVFlDgnsrZZwRom3D/ 45aBudKG5wTjzZcFsuknoBwcZAbG5PZ0T4R0I4vq4zo++/+WcE4ULHGhhxPA0Woc19zQBMKArQn IQzAIPTU3lTB4pxMFxPK5vk+ffnV8uHr+aP5+GPuRPTL6t+z6aqoUrKfncYKY007O0qkB09mGgu enVdazssuoXQ2Evw/ZBCt+lqLymjhEyCmSm9TDq+bxzqJIRLxQnHhni2kC4iMJO/SQrT6q4auiP 0tPejY5pu7aRD8LBB5hH9Pq0qG2lg5EnaOO7NhkMA6YU= X-Received: by 2002:a05:7301:2a27:b0:30c:ab96:7304 with SMTP id 5a478bee46e88-30eea0b83b6mr2029030eec.20.1782831980456; Tue, 30 Jun 2026 08:06:20 -0700 (PDT) X-Received: by 2002:a05:7301:2a27:b0:30c:ab96:7304 with SMTP id 5a478bee46e88-30eea0b83b6mr2028977eec.20.1782831979816; Tue, 30 Jun 2026 08:06:19 -0700 (PDT) Received: from [10.206.105.200] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30ee3205993sm9524988eec.24.2026.06.30.08.06.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 08:06:19 -0700 (PDT) Message-ID: <8dc9018c-5b2b-26e9-628f-04f9adcee1c5@oss.qualcomm.com> Date: Tue, 30 Jun 2026 20:36:13 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 1/2] media: qcom: iris: improve gop size support for gen1 encoder To: Wangao Wang , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: quic_qiweil@quicinc.com, Renjiang Han , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260624-dynamic_encode-v3-0-f2a2db0ac2af@oss.qualcomm.com> <20260624-dynamic_encode-v3-1-f2a2db0ac2af@oss.qualcomm.com> Content-Language: en-US From: Vishnu Reddy In-Reply-To: <20260624-dynamic_encode-v3-1-f2a2db0ac2af@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: OalidTLP9UP1C6XZMIJkC3eD_Yuk89hA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDE0MiBTYWx0ZWRfXyzKap9JMY2q6 RhkLpwg/rwVOhrMUxNurHh9vFpHu39df1ohr5yvcn548Xt/ZHIEyTKLRRlNAU53Z2Z5rawgUNVT gypVcuqgEAzVmpf6dVcArCPfdt6W84TI+/yFLyszENxJq6G9gFNfyViTWOiH+hEL5PolPQ8MWaG DRjJ9bhXaSup4LTXid8If/e9G6i6s7ZE8Rh5VzmwMFyzxIc57aNd5s1xZEje0ryO3zRiyLXAOf9 Y5KVEf7J0Jkwi2jPQNioaAKGFXgFsvLqu0Ip5+L/r/4rGciAUmlK8Kx140CMYf5fS/kAEj7PJwS BlIH3lDjhqdltmDSPK7R2Hp7FJ/9rErf7GhzcxTys+mQ8FkaHb36v2M3jLkCykgqJsnUvoVuj2P VFi4GjC5Pmed76gdCKUIPblRRA9Zk+uC4pms/mSo31lIxHwrIiZeqO3LGQ+FcAX7Q17lVqVPqOU 6KwZCiiXAFLPH6XrgJw== X-Proofpoint-GUID: OalidTLP9UP1C6XZMIJkC3eD_Yuk89hA X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDE0MiBTYWx0ZWRfXzQzL4hstTyPd 9BildtwyrYUKmWQodm+VJkA6Uyig8JEzrWnRtz1LPrzCzRntQEKiK7LqNs9DeyKQJYX1fN+ztY8 0cjKQ+uTQd1OpzA2pJYyz64a+d4HXzU= X-Authority-Analysis: v=2.4 cv=SINykuvH c=1 sm=1 tr=0 ts=6a43db6d cx=c_pps a=cFYjgdjTJScbgFmBucgdfQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=hUGi12Jgw1DI7xEWZf0A:9 a=QEXdDO2ut3YA:10 a=scEy_gLbYbu1JhEsrz4S:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_04,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 priorityscore=1501 spamscore=0 phishscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300142 On 6/24/2026 2:21 PM, Wangao Wang wrote: > The GOP_SIZE cap was missing an hfi_id, so it would not interact with the > firmware but could still save the parameter passed by the client. > INTRA_PERIOD was acting as GOP_SIZE here. The code was redundant, so the > two caps have been merged. > > Signed-off-by: Wangao Wang > --- > drivers/media/platform/qcom/iris/iris_ctrls.c | 2 +- > drivers/media/platform/qcom/iris/iris_hfi_gen1.c | 16 ++++------------ > drivers/media/platform/qcom/iris/iris_platform_common.h | 1 - > 3 files changed, 5 insertions(+), 14 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.c b/drivers/media/platform/qcom/iris/iris_ctrls.c > index 10e33b8a73f60759c4f1cb17b5c95897f0e1468f..391e1fc5f6e2ec8e9cf5ba4e0f76b2d1da3e2a35 100644 > --- a/drivers/media/platform/qcom/iris/iris_ctrls.c > +++ b/drivers/media/platform/qcom/iris/iris_ctrls.c > @@ -1293,7 +1293,7 @@ int iris_set_use_and_mark_ltr(struct iris_inst *inst, enum platform_inst_fw_cap_ > int iris_set_intra_period(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id) > { > const struct iris_hfi_session_ops *hfi_ops = inst->hfi_session_ops; > - u32 gop_size = inst->fw_caps[GOP_SIZE].value; > + u32 gop_size = inst->fw_caps[cap_id].value; > u32 b_frame = inst->fw_caps[B_FRAME].value; > u32 hfi_id = inst->fw_caps[cap_id].hfi_id; > struct hfi_intra_period intra_period; > diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen1.c b/drivers/media/platform/qcom/iris/iris_hfi_gen1.c > index ca1545d28b5310d8c45a905287dcb69f6184d9cc..eff9216bb50143c0d752051a6400605bbaf3803e 100644 > --- a/drivers/media/platform/qcom/iris/iris_hfi_gen1.c > +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen1.c > @@ -171,7 +171,9 @@ static const struct platform_inst_fw_cap inst_fw_cap_sm8250_enc[] = { > .max = (1 << 16) - 1, > .step_or_mask = 1, > .value = 30, > - .set = iris_set_u32 > + .hfi_id = HFI_PROPERTY_CONFIG_VENC_INTRA_PERIOD, > + .flags = CAP_FLAG_OUTPUT_PORT, > + .set = iris_set_intra_period, > }, > { > .cap_id = ENTROPY_MODE, > @@ -240,7 +242,7 @@ static const struct platform_inst_fw_cap inst_fw_cap_sm8250_enc[] = { > .step_or_mask = 1, > .value = 0, > .hfi_id = HFI_PROPERTY_PARAM_VENC_INTRA_REFRESH, > - .flags = CAP_FLAG_OUTPUT_PORT, > + .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_DYNAMIC_ALLOWED, > .set = iris_set_ir_period_gen1, > }, > { > @@ -281,16 +283,6 @@ static const struct platform_inst_fw_cap inst_fw_cap_sm8250_enc[] = { > .value = 0, > .flags = CAP_FLAG_OUTPUT_PORT, > }, > - { > - .cap_id = INTRA_PERIOD, > - .min = 0, > - .max = 1, > - .step_or_mask = 1, > - .value = 0, > - .hfi_id = HFI_PROPERTY_CONFIG_VENC_INTRA_PERIOD, > - .flags = CAP_FLAG_OUTPUT_PORT, > - .set = iris_set_intra_period, > - }, > { > .cap_id = LAYER_ENABLE, > .min = 0, > diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h > index c9256f2323dc4521f9eacaeffb0fc08a180de3ff..ff48333ad089894c3393e8ad45903c2603288eb9 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_common.h > +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h > @@ -165,7 +165,6 @@ enum platform_inst_fw_cap_type { > USE_LTR, > MARK_LTR, > B_FRAME, > - INTRA_PERIOD, > LAYER_ENABLE, > LAYER_TYPE_H264, > LAYER_TYPE_HEVC, Reviewed-by: Vishnu Reddy