mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Agner <stefan@agner.ch>
To: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
Cc: shawn.guo@freescale.com, linux@arm.linux.org.uk,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: vf-colibri: Add I2C support
Date: Wed, 05 Nov 2014 09:46:17 +0100	[thread overview]
Message-ID: <8dcb8f78771fe356b9648e74354003e9@agner.ch> (raw)
In-Reply-To: <d5e07584708523262df69f5a4dec10609f77baa3.1415099486.git.bhuvanchandra.dv@toradex.com>

Am 2014-11-04 12:22, schrieb Bhuvanchandra DV:
> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
> ---
>  arch/arm/boot/dts/vf-colibri-eval-v3.dtsi |    7 ++++++-
>  arch/arm/boot/dts/vf-colibri.dtsi         |   13 +++++++++++++
>  2 files changed, 19 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
> b/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
> index 80e8fbc..0251e6c 100644
> --- a/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
> +++ b/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
> @@ -33,6 +33,11 @@
>  	status = "okay";
>  };
>  
> +&i2c0 {
> +	clock-frequency = <400000>;
> +	status = "okay";
> +};
> +
>  &pwm0 {
>  	status = "okay";
>  };
> @@ -51,4 +56,4 @@
>  
>  &uart2 {
>  	status = "okay";
> -};
> \ No newline at end of file
> +};
> diff --git a/arch/arm/boot/dts/vf-colibri.dtsi
> b/arch/arm/boot/dts/vf-colibri.dtsi
> index ab40367..471eec0 100644
> --- a/arch/arm/boot/dts/vf-colibri.dtsi
> +++ b/arch/arm/boot/dts/vf-colibri.dtsi
> @@ -39,6 +39,12 @@
>  	pinctrl-0 = <&pinctrl_fec1>;
>  };
>  
> +&i2c0 {
> +	clock-frequency = <400000>;

There is no need to overwrite the clock frequency again on carrier board
level here.

But other than that.

Acked-by: Stefan Agner <stefan@agner.ch>

> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_i2c0>;
> +};
> +
>  &pwm0 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_pwm0>;
> @@ -102,6 +108,13 @@
>  			>;
>  		};
>  
> +		pinctrl_i2c0: i2c0grp {
> +			fsl,pins = <
> +				VF610_PAD_PTB14__I2C0_SCL		0x37ff
> +				VF610_PAD_PTB15__I2C0_SDA		0x37ff
> +			>;
> +		};
> +
>  		pinctrl_pwm0: pwm0grp {
>  			fsl,pins = <
>  				VF610_PAD_PTB0__FTM0_CH0		0x1182

  reply	other threads:[~2014-11-05  8:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04 11:22 [PATCH 0/2] Add I2C and enable M41T0M6 RTC Bhuvanchandra DV
2014-11-04 11:22 ` [PATCH 1/2] ARM: dts: vf-colibri: Add I2C support Bhuvanchandra DV
2014-11-05  8:46   ` Stefan Agner [this message]
2014-11-04 11:22 ` [PATCH 2/2] ARM: dts: vf-colibri-eval-v3.dts: Enable ST-M41T0M6 RTC Bhuvanchandra DV
2014-11-05  8:51   ` Stefan Agner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8dcb8f78771fe356b9648e74354003e9@agner.ch \
    --to=stefan@agner.ch \
    --cc=bhuvanchandra.dv@toradex.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=shawn.guo@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®