From: Joe Perches <joe@perches.com>
To: Dmitry Rokosov <ddrokosov@sberdevices.ru>,
krzysztof.kozlowski@linaro.org, robh@kernel.org,
apw@canonical.com, dwaipayanray1@gmail.com,
lukas.bulwahn@gmail.com
Cc: kernel@sberdevices.ru, linux-kernel@vger.kernel.org, rockosov@gmail.com
Subject: Re: [PATCH v1] checkpatch: add missing bindings license check
Date: Fri, 17 Mar 2023 15:28:16 -0700 [thread overview]
Message-ID: <8dcc23061db363d894a5c8219076cd41f99163c1.camel@perches.com> (raw)
In-Reply-To: <20230317201621.15518-1-ddrokosov@sberdevices.ru>
On Fri, 2023-03-17 at 23:16 +0300, Dmitry Rokosov wrote:
> All headers from 'include/dt-bindings/' must be verified by checkpatch
> together with Documentation bindings, because all of them are part of
> the whole DT bindings system.
>
> The requirement is dual licensed and matching string:
> 'GPL-2.0-only OR BSD-2-Clause'
>
> The issue was found during patch review:
> https://lore.kernel.org/all/20230313201259.19998-4-ddrokosov@sberdevices.ru/
>
> Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> ---
> scripts/checkpatch.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3709,7 +3709,8 @@ sub process {
> WARN("SPDX_LICENSE_TAG",
> "'$spdx_license' is not supported in LICENSES/...\n" . $herecurr);
> }
> - if ($realfile =~ m@^Documentation/devicetree/bindings/@ &&
> + if (($realfile =~ m@^Documentation/devicetree/bindings/@ ||
> + $realfile =~ m@^include/dt-bindings/@) &&
I prefer aligning to open parens
> not $spdx_license =~ /GPL-2\.0.*BSD-2-Clause/) {
And if it's really a strict bit about the required license,
why not make it match exactly?
$spdx_license !~ /GPL-2\.0(?:-only|-or-later|\+)? OR BSD-2-Clause/) {
> my $msg_level = \&WARN;
> $msg_level = \&CHK if ($file);
$ git grep -oh 'SPDX-License.*$' -- Documentation/devicetree/bindings/ include/dt-bindings/ | \
sort | uniq -c | sort -rn
1597 SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
611 SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
540 SPDX-License-Identifier: GPL-2.0
355 SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
285 SPDX-License-Identifier: GPL-2.0 */
179 SPDX-License-Identifier: GPL-2.0-only */
102 SPDX-License-Identifier: GPL-2.0-only
93 SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
56 SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
47 SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
36 SPDX-License-Identifier: GPL-2.0+ */
34 SPDX-License-Identifier: GPL-2.0-or-later */
33 SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
28 SPDX-License-Identifier: GPL-2.0+
21 SPDX-License-Identifier: (GPL-2.0+ OR MIT)
19 SPDX-License-Identifier: (GPL-2.0+ or MIT) */
17 SPDX-License-Identifier: (GPL-2.0 OR MIT) */
12 SPDX-License-Identifier: (GPL-2.0+ OR BSD-2-Clause)
11 SPDX-License-Identifier: (GPL-2.0+ OR MIT) */
9 SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */
8 SPDX-License-Identifier: GPL-2.0 OR MIT */
8 SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */
7 SPDX-License-Identifier: GPL-2.0-or-later OR BSD-2-Clause
7 SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
7 SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */
6 SPDX-License-Identifier: (GPL-2.0)
5 SPDX-License-Identifier: GPL-2.0+ OR MIT */
5 SPDX-License-Identifier: (GPL-2.0 OR MIT)
5 SPDX-License-Identifier: (GPL-2.0 or MIT) */
4 SPDX-License-Identifier: GPL-2.0-or-later
3 SPDX-License-Identifier: (GPL-2.0+ OR X11)
3 SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) */
3 SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */
3 SPDX-License-Identifier: GPL-2.0 or BSD-3-Clause */
3 SPDX-License-Identifier: (GPL-2.0+ OR BSD-2-Clause) */
3 SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) */
3 SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) */
2 SPDX-License-Identifier: (GPL-2.0+ or MIT)
2 SPDX-License-Identifier: GPL-2.0-or-later OR MIT */
2 SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
2 SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause */
2 SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)*/
1 SPDX-License-Identifier: (GPL-2.0-or-later OR MIT) */
1 SPDX-License-Identifier: (GPL-2.0-or-later or MIT) */
1 SPDX-License-Identifier: GPL-2.0-or-later or BSD-2-Clause */
1 SPDX-License-Identifier: (GPL-2.0-or-later)
1 SPDX-License-Identifier: GPL-2.0+ or BSD-3-Clause */
1 SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */
1 SPDX-License-Identifier: GPL-2.0-only or X11 */
1 SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
1 SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause */
1 SPDX-License-Identifier: (GPL-2.0-only)
1 SPDX-License-Identifier: BSD-2-Clause
next prev parent reply other threads:[~2023-03-17 22:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 20:16 Dmitry Rokosov
2023-03-17 22:28 ` Joe Perches [this message]
2023-03-20 8:31 ` Dmitry Rokosov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8dcc23061db363d894a5c8219076cd41f99163c1.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=ddrokosov@sberdevices.ru \
--cc=dwaipayanray1@gmail.com \
--cc=kernel@sberdevices.ru \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=robh@kernel.org \
--cc=rockosov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®