From: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
Robert Marko <robimarko@gmail.com>, <agross@kernel.org>,
<andersson@kernel.org>, <mturquette@baylibre.com>,
<sboyd@kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: qcom: gcc-ipq6018: add QUP6 I2C clock
Date: Thu, 19 Oct 2023 12:16:09 +0530 [thread overview]
Message-ID: <8dce62b2-562c-4e00-840b-68e1cc865972@quicinc.com> (raw)
In-Reply-To: <f27ff251-58b1-4fc5-8ad5-cd365b7eb976@linaro.org>
On 10/19/2023 1:59 AM, Konrad Dybcio wrote:
>
>
> On 10/15/23 18:20, Robert Marko wrote:
>> QUP6 I2C clock is listed in the dt bindings but it was never included in
>> the GCC driver.
>> So lets add support for it, its intentionally marked to never be
>> disabled
>> as its somehow affecting DVFS and if disabled it sometimes crashes the
>> board.
>>
>> Signed-off-by: Robert Marko <robimarko@gmail.com>
>> ---
> Bjorn, would you be able to get an idea of what could be sitting
> on that bus?
>
> Or maybe the IPQ folks could know?
>
Konrad / Robert,
Similar to IPQ9574, RPM needs this clock to communicate with PMIC over
I2C interface. Discussion happened here[1] is pretty much applicable to
IPQ6018 as well. Based on previous experience, we may need to document
the reason for CLK_IGNORE_UNUSED in driver as well. Nevertheless,
Reviewed-by: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
[1]
https://lore.kernel.org/linux-arm-msm/2852fc37-284f-6534-f163-45b37b153db1@quicinc.com/
> Konrad
next prev parent reply other threads:[~2023-10-19 6:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-15 16:20 Robert Marko
2023-10-18 20:29 ` Konrad Dybcio
2023-10-19 6:46 ` Kathiravan Thirumoorthy [this message]
2023-10-19 14:23 ` Robert Marko
2023-10-20 6:40 ` Kathiravan Thirumoorthy
2023-10-21 11:57 ` Robert Marko
2023-10-25 8:41 ` Kathiravan Thirumoorthy
2023-10-25 10:42 ` Robert Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8dce62b2-562c-4e00-840b-68e1cc865972@quicinc.com \
--to=quic_kathirav@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robimarko@gmail.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®