From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FROM_EXCESS_BASE64,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFEEBC04A6B for ; Mon, 6 May 2019 12:18:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8EA8D206BF for ; Mon, 6 May 2019 12:18:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ysoft.com header.i=@ysoft.com header.b="gdLvPXKH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726150AbfEFMSI (ORCPT ); Mon, 6 May 2019 08:18:08 -0400 Received: from uho.ysoft.cz ([81.19.3.130]:44284 "EHLO uho.ysoft.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725853AbfEFMSI (ORCPT ); Mon, 6 May 2019 08:18:08 -0400 Received: from [10.1.8.111] (unknown [10.1.8.111]) by uho.ysoft.cz (Postfix) with ESMTP id 31414A444E; Mon, 6 May 2019 14:18:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ysoft.com; s=20160406-ysoft-com; t=1557145084; bh=BG1iY/eflDP17+5L43NWdu8cKBZW9ASGCdoXdZ226OE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=gdLvPXKHSzo9OjUH6H9WEvCzDCqirgb69yaL1IT1G76e8mCDCrvZeRdlJV3x+xZ0Y PmU+iRXyaBe01dEpVOhiqHjG14O/WqSyf9oeCQx2oQh2D8cDVBMhqgin1MIGE1V88N ddmgi4Gj1Tb3SGzL7AbAMI7bAM3K6dlfFGPRv/h4= Subject: Re: [RFC PATCH 1/4] dt-bindings: input: Add support for the MPR121 without interrupt line To: Rob Herring Cc: Dmitry Torokhov , Mark Rutland , Shawn Guo , Sascha Hauer , Fabio Estevam , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team References: <1556267420-93219-1-git-send-email-michal.vokac@ysoft.com> <1556267420-93219-2-git-send-email-michal.vokac@ysoft.com> <20190502004849.GA8232@bogus> From: =?UTF-8?B?TWljaGFsIFZva8OhxI0=?= Message-ID: <8dd2efa1-0fc9-d99a-d015-323350e1abdc@ysoft.com> Date: Mon, 6 May 2019 14:18:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190502004849.GA8232@bogus> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02. 05. 19 2:48, Rob Herring wrote: > On Fri, Apr 26, 2019 at 10:30:17AM +0200, Michal Vokáč wrote: >> Normally, the MPR121 controller uses separate interrupt line to notify >> the I2C host that a key was touched/released. To support platforms that >> can not use the interrupt line, polling of the MPR121 registers can be >> used. > > Other than making the 'interrupts' property optional, that's a driver > change, not a DT change. IOW, we shouldn't need a whole new binding. > OK, I will update the existing binding instead. Thank you, Michal >> >> Signed-off-by: Michal Vokáč >> --- >> .../bindings/input/mpr121-touchkey-polled.txt | 26 ++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/input/mpr121-touchkey-polled.txt >> >> diff --git a/Documentation/devicetree/bindings/input/mpr121-touchkey-polled.txt b/Documentation/devicetree/bindings/input/mpr121-touchkey-polled.txt >> new file mode 100644 >> index 000000000000..6bb1d312614c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/input/mpr121-touchkey-polled.txt >> @@ -0,0 +1,26 @@ >> +* Freescale MPR121 Controller without interrupt line >> + >> +Required Properties: >> +- compatible: Should be "fsl,mpr121-touchkey-polled" >> +- reg: The I2C slave address of the device. >> +- vdd-supply: Phandle to the Vdd power supply. >> +- linux,keycodes: Specifies an array of numeric keycode values to >> + be used for reporting button presses. The array can >> + contain up to 12 entries. >> + >> +Optional Properties: >> +- autorepeat: Enable autorepeat feature. >> + >> +Example: >> + >> +#include "dt-bindings/input/input.h" >> + >> + touchkeys: keys@5a { >> + compatible = "fsl,mpr121-touchkey-polled"; >> + reg = <0x5a>; >> + autorepeat; >> + vdd-supply = <&ldo4_reg>; >> + linux,keycodes = , , , , >> + , , , >> + , , , ; >> + }; >> -- >> 2.1.4 >>