From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932754AbcIAKaB (ORCPT <rfc822;w@1wt.eu>);
        Thu, 1 Sep 2016 06:30:01 -0400
Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:53644
        "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932298AbcIAK37 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 1 Sep 2016 06:29:59 -0400
Subject: Re: [PATCH 1/6] pinctrl: dt-bindings: samsung: Update documentation
 with new macros
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        Tomasz Figa <tomasz.figa@gmail.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
        Kukjin Kim <kgene@kernel.org>
References: <1472721715-2833-1-git-send-email-k.kozlowski@samsung.com>
 <1472721715-2833-2-git-send-email-k.kozlowski@samsung.com>
From: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Message-ID: <8dda7bb7-fb99-3e13-be03-e21e3b18e501@osg.samsung.com>
Date: Thu, 1 Sep 2016 12:29:50 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <1472721715-2833-2-git-send-email-k.kozlowski@samsung.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Krzysztof,

On 09/01/2016 11:21 AM, Krzysztof Kozlowski wrote:
> Update examples in Samsung pinctrl dt-bindings with new macros coming
> from header file.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  .../bindings/pinctrl/samsung-pinctrl.txt           | 42 +++++++++++-----------
>  1 file changed, 21 insertions(+), 21 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
> index 6db16b90873a..828ef7fdd437 100644
> --- a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
> @@ -238,53 +238,53 @@ Example 1: A pin-controller node with pin groups.
>  
>  		uart0_data: uart0-data {
>  			samsung,pins = "gpa0-0", "gpa0-1";
> -			samsung,pin-function = <2>;
> -			samsung,pin-pud = <0>;
> -			samsung,pin-drv = <0>;
> +			samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +			samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +			samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>  		};

I wonder if besides updating the examples, the DT binding shouldn't also
mention include/dt-bindings/pinctrl/samsung.h and list the macros for each
possible pin configuration.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America