From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F29232F3621 for ; Sat, 13 Jun 2026 16:42:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781368935; cv=none; b=dcPg5IWeDLGRp2HNWvLULRo/xX14X0t1Bxmj8QoPekcsBYDZ5lEyLGbYBLbFiDDowjwst9KTGgnzOU3DD75Oj8oKob1VwU8S7uNhQaf2+kxKt5I5Rv/e896e9MQxMOrtOFwSoYZ3FyABYfgiCXd9NSxR+8o21ORqA9ZHnachV2Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781368935; c=relaxed/simple; bh=IhIQz5jSiL3XNOL1jTbo5CXGeRcji9WKa7mNaIAFqXk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tzL8y6PpgrLq3JAzLku+lNA3eximM8Wwqd6V1/FQUEENrTcA7KuDqd+ijM7BizP0H/pDWLXkrp1I2DvtZLN2Cd4FXMMEwgXgiJ1JBfm056mWs2pX+U3HveeEqokAXhpcWuCfE97yoOoD5d3SFGJSM2ngklH9SKsgXKngbXhkbDY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=U0Fd+nbn; arc=none smtp.client-ip=209.85.210.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="U0Fd+nbn" Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-7e6c047c6bfso1634376a34.3 for ; Sat, 13 Jun 2026 09:42:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1781368933; x=1781973733; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YClLX0yEzKDd8bl1cK6HeZnm+stLvAtsb923iZjql8k=; b=U0Fd+nbnCSmC5+faS7b43X/SuLhkZAldJ/LX/f23IU+F8qE2V3O5vP/O+8K96DOxzU Si0xITrDw9XU818gebvaxsqmhDC6RvAikv6YWpT9jxhfqQ3gCS6mQbJqUth85WPc/sqk j9Ed91t4NevmC70K2jlVghOS0O2vueuMyMe/zkPmiztwYIEGF6TIolLXfS1tvuzToNdU Y11aOQHQDziQUqYYxxZeLMcH3rpJfwhjRrHxj+Hf2sQ+kRLXHUyr7NeGdBNvpHnPE8bl 0PQW2JiY1qV9a7gY5Uq0PCjqe+FcWZHoY1uNQqw593T/8pqqN6os8Z4sg0r2gnHkDWRz uDVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781368933; x=1781973733; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YClLX0yEzKDd8bl1cK6HeZnm+stLvAtsb923iZjql8k=; b=PVVuGZ5kbVWEdnJKbH8h2B1UYqCubqZcuhqzFvmrzwkZMp2Bd0pMeaJ095LBnkyEiQ LT26NZfNO5pMwtCbqN9B4LLjF7ayWdjjYOM7quNtnEwwEsSKlLZmj2Y4txEtQ9DML8rE a47b+XvXl2goODKfDRecmKaWLPEiU/MxvkiXgwO491ZTQIouEd9rYD8H0xQWHwJpbefT vwPuKgLh/+V0D6jVCYPhyGrrk0lOtNZAxg6kX5rZwkZwYvV2ISonMnE9XiL1w2ys3WT6 Kx4IiAPLhpLxv754AsVpCRWuha0fKtt+lFFOw52sRiTdi+DhsCvj/EvTv5XcqvA/fM9X pkhg== X-Forwarded-Encrypted: i=1; AFNElJ8QW/sl1nONMRAxSplERTcCNSaHx4pijPFouUq+cYGwS1wXjurmdOD8bsl5wjLw0gIj0FtWtzahW6slAc8=@vger.kernel.org X-Gm-Message-State: AOJu0Yxn8kIOkFblr9Q6SKMSRDz/vfbvz6WfxE1ozAz0Hyq+TCC0jlyq h0xLUShXATsP1v1ChWaMXvhyIunudoX9yxYvqW3+5WcarcRSpM2Rytq2PuVPyb7khgj2Wzqhm9C uV3E8Qt8= X-Gm-Gg: Acq92OHkHIAvxF0BuZwOpn/DT/yi/pFfBwLYYKTXY8CbHm6a3MmtI1OxEPfn7YIUkhN cQWyVCmVcjFTAmnOarhEIkou/2G6USV8YdWyroLP4QWb8OVCxn6Dumt99gCRXf9k0mDjyWkSTca 5/khjyw/XYX0eJaD1Gyk/7JfCTyQuPkU+5IU4iViZiRf2vdicexni1TcGns85gorR1Z+YVOx7iO KxMkt+J+7MFuuqalXTc4QjWMKPKtrh2ouHfqDH53OCVT1k1vke6AhmjzOWyqHrmTwy7LCBoNcfY hFCZ55L9+qhA0uir+swrOQ2/rF8EUoPy5EwuN5dxjH0d50p6gL9mH/KnH5KBpZCoZLQYR4+6xUi 6i3lfzqOaoTgbL3HM8ifCPaMf5oIgiXVjhPCfuRTxmC7aaUWcpKtnlE0xi8JesjGbfUsdLoTRsI zx9+Wjfyb374ZnpttUWUb3XtX33rtoCDmC3hzfRARKm4DaEHgb2QLqYJbQP1qE2WXFmMn5X1ErO g== X-Received: by 2002:a05:6830:6e1f:b0:7e7:9493:dc3e with SMTP id 46e09a7af769-7e794a32092mr1230912a34.3.1781368932957; Sat, 13 Jun 2026 09:42:12 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:cb9a:87cc:1314:fef5? ([2600:8803:e7e4:500:cb9a:87cc:1314:fef5]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e78125d3e3sm4346652a34.0.2026.06.13.09.42.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Jun 2026 09:42:12 -0700 (PDT) Message-ID: <8ddb4c1e-d105-49be-a6e0-30c220af98c3@baylibre.com> Date: Sat, 13 Jun 2026 11:42:11 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] iio: adc: mt6323-auxadc: add mt6323 PMIC AUXADC driver To: Roman Vivchar , =?UTF-8?Q?Nuno_S=C3=A1?= Cc: Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Lee Jones , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Ben Grisdale References: <20260602-mt6323-adc-v1-0-68ec737508ee@protonmail.com> <20260602-mt6323-adc-v1-2-68ec737508ee@protonmail.com> <2df4cad5e29fbcb4c5c5f59ea0bf322c7a301bdc.camel@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 6/3/26 6:24 AM, Roman Vivchar wrote: > Hi Nuno, > > On Tuesday, June 2nd, 2026 at 7:42 PM, Nuno Sá wrote: > >> On Tue, 2026-06-02 at 15:46 +0300, Roman Vivchar via B4 Relay wrote: > > ... > >>> >>> +MEDIATEK MT6323 PMIC AUXADC DRIVER >>> +M: Roman Vivchar >>> +L: linux-iio@vger.kernel.org >>> +L: linux-mediatek@lists.infradead.org (moderated for non-subscribers) >>> +S: Maintained >>> +F: drivers/iio/adc/mt6323-auxadc.c >>> +F: include/dt-bindings/iio/adc/mediatek,mt6323-auxadc.h >> >> The above file was not added in this patch > > The header file is added in patch 1 (dt-bindings). Following Krzysztof's > feedback on the previous version, I squashed the MAINTAINERS into this patch. > Please let me know if I misunderstood anything. Usually, we want the MAINTAINERS entry in the same patch that the file was added. It is fine to include MAINTAINERS changes in the dt-bindings patch. >>> + case IIO_CHAN_INFO_RAW: >>> + scoped_guard(mutex, &auxadc->lock) { We can avoid extra indent by making this: case IIO_CHAN_INFO_RAW: { guard(mutex)(&auxadc->lock); ... return IIO_VAL_INT; } >>> + ret = mt6323_auxadc_prepare_channel(auxadc); >>> + if (ret) >>> + return ret; >>> + >>> + ret = mt6323_auxadc_request(auxadc, chan->channel); >>> + if (ret) >>> + return ret; >>> + >>> + /* Hardware limitation: the AUXADC needs a delay to become >>> ready. */ >>> + fsleep(300); >>> + >>> + ret = mt6323_auxadc_read(auxadc, chan, val); >>> + if (ret) >>> + return ret; >> >> Could be return mt6323_auxadc_read(...) > > The mt6323_auxadc_read returns 0, while IIO expects IIO_VAL_INT (defined as 1). > Should the mt6323_auxadc_read function return 1 for success? mt6323_auxadc_read() would need to return IIO_VAL_INT.