From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755499AbcFQM4o (ORCPT ); Fri, 17 Jun 2016 08:56:44 -0400 Received: from mx2.suse.de ([195.135.220.15]:35275 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753305AbcFQM4n (ORCPT ); Fri, 17 Jun 2016 08:56:43 -0400 Subject: Re: [PATCH v3 5/9] tools/vm/page_owner: increase temporary buffer size To: js1304@gmail.com, Andrew Morton References: <1466150259-27727-1-git-send-email-iamjoonsoo.kim@lge.com> <1466150259-27727-6-git-send-email-iamjoonsoo.kim@lge.com> Cc: mgorman@techsingularity.net, Minchan Kim , Alexander Potapenko , Hugh Dickins , Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sasha Levin , Joonsoo Kim From: Vlastimil Babka Message-ID: <8ddf2808-75ab-df5e-e2c1-b48ced7f60f5@suse.cz> Date: Fri, 17 Jun 2016 14:56:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1466150259-27727-6-git-send-email-iamjoonsoo.kim@lge.com> Content-Type: text/plain; charset=iso-8859-2; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/17/2016 09:57 AM, js1304@gmail.com wrote: > From: Joonsoo Kim > > Page owner will be changed to store more deep stacktrace so current > temporary buffer size isn't enough. Increase it. > > Link: http://lkml.kernel.org/r/1464230275-25791-5-git-send-email-iamjoonsoo.kim@lge.com > Signed-off-by: Joonsoo Kim > Cc: Vlastimil Babka Acked-by: Vlastimil Babka > Cc: Mel Gorman > Cc: Minchan Kim > Cc: Alexander Potapenko > Cc: Hugh Dickins > Cc: Michal Hocko > --- > tools/vm/page_owner_sort.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/tools/vm/page_owner_sort.c b/tools/vm/page_owner_sort.c > index 77147b4..f1c055f 100644 > --- a/tools/vm/page_owner_sort.c > +++ b/tools/vm/page_owner_sort.c > @@ -79,12 +79,12 @@ static void add_list(char *buf, int len) > } > } > > -#define BUF_SIZE 1024 > +#define BUF_SIZE (128 * 1024) > > int main(int argc, char **argv) > { > FILE *fin, *fout; > - char buf[BUF_SIZE]; > + char *buf; > int ret, i, count; > struct block_list *list2; > struct stat st; > @@ -107,6 +107,11 @@ int main(int argc, char **argv) > max_size = st.st_size / 100; /* hack ... */ > > list = malloc(max_size * sizeof(*list)); > + buf = malloc(BUF_SIZE); > + if (!list || !buf) { > + printf("Out of memory\n"); > + exit(1); > + } > > for ( ; ; ) { > ret = read_block(buf, BUF_SIZE, fin); >