From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAA9DC63777 for ; Tue, 24 Nov 2020 20:04:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 86A9120708 for ; Tue, 24 Nov 2020 20:04:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cosKrxFY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730079AbgKXUEK (ORCPT ); Tue, 24 Nov 2020 15:04:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727189AbgKXUEJ (ORCPT ); Tue, 24 Nov 2020 15:04:09 -0500 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05882C0613D6; Tue, 24 Nov 2020 12:04:09 -0800 (PST) Received: by mail-lf1-x142.google.com with SMTP id d17so30616200lfq.10; Tue, 24 Nov 2020 12:04:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yQgYdytsJTWx40vs8O0euMQoqQTcCtKDhAMPimfddKI=; b=cosKrxFY6w+hivTa43r0ylY+uV+RFy+HNc+RCmbsbCdxt7tppl30ly3THnjosC7Xxd OItFN1kWC5JZe1g3DJhuLCNZnvJdMLJ23sNp6M5GRo2+FWLp7i0GhYYt/KYbDxUeHy7f 2lkCFsvAqUu5ICKeVt0xr0qNgZI6UUBzcGEXC2MBuGpDnzPkgNyU8jl2QQ/4f4ubg57h vdnuE1FaCYTNpHAohUYfIWBKqzHbERV2b1GbZrfjN2x2Lbbj1JG3IghFWJXBAdSvHxPE pjzvBz6NvjCy5d9OLv0WD/UaSAd1lcXudLuUtXErMMP8HGubThVonaSy4Inc14JMHFHQ Zirw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yQgYdytsJTWx40vs8O0euMQoqQTcCtKDhAMPimfddKI=; b=iQbDt+gu4Wd/OIIbdKJZSeWp/xrmVzbKide7/zjL0aHuTBGq6JSHetRIBkEJegzrGG RtJChCzH+x/cdvTXyhc5CDrBeweCU7UsXcibLyxvUxb0UPsx/RT+jcktOQiBF/mbor31 KcHVKqrlSnbxfqp+fL+6TSBtTlTxN3AMh0jUmi5VNflrfTAGzNOii1vEefjEsRwHrP3p rSA457b8uhDBFqeHn0/SrsXmTlW5NIsHHmqere9O4Jad+reKWjJZS9QVUaLtQq91gutv VCVhsXFti/e24CpZjnNlicOiRMOgsgGu6FIHT0eAt8MnYLzSazE++yhdgkNNn8uP5dEg +/+Q== X-Gm-Message-State: AOAM532P47wo0NjfpCENW+MoHY5MUs/jX7pmAvX2NRw61mWHRnaK2np2 woCur6rnE7TUOp/uhSoQeLo= X-Google-Smtp-Source: ABdhPJwG7Ww3zbg4TMYvm6069UG3PkJtckTYIUaBtZFqTTdokEnajSpUitxGVVTZ9tOZILUi0mcbvA== X-Received: by 2002:a19:42cd:: with SMTP id p196mr2200173lfa.228.1606248247530; Tue, 24 Nov 2020 12:04:07 -0800 (PST) Received: from ?IPv6:2a00:1fa0:651:eeec:8461:5bd1:fea0:1c50? ([2a00:1fa0:651:eeec:8461:5bd1:fea0:1c50]) by smtp.gmail.com with ESMTPSA id y132sm1267lfc.8.2020.11.24.12.04.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Nov 2020 12:04:06 -0800 (PST) Subject: Re: [PATCH 4/5] memory: renesas-rpc-if: Avoid use of C++ style comments To: Lad Prabhakar , Sergei Shtylyov , Krzysztof Kozlowski , Philipp Zabel , Jiri Kosina , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Biju Das , Prabhakar References: <20201124112552.26377-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20201124112552.26377-5-prabhakar.mahadev-lad.rj@bp.renesas.com> From: Sergei Shtylyov Message-ID: <8ddf57ec-c1af-cc20-ecba-c8cd96e56d7a@gmail.com> Date: Tue, 24 Nov 2020 23:04:05 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201124112552.26377-5-prabhakar.mahadev-lad.rj@bp.renesas.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/24/20 2:25 PM, Lad Prabhakar wrote: > Replace C++ style comment with C style. Thanks, I've overlooked this, and the header files should use C style comment, not C++. > While at it also replace the tab with a space between struct and > struct name. No connection between these 2 changes, so there should be 2 patches, not 1. Also, I'd like to ask you that they're left intact (unless it causes problems for you). > Suggested-by: Pavel Machek > Signed-off-by: Lad Prabhakar [...] > diff --git a/include/memory/renesas-rpc-if.h b/include/memory/renesas-rpc-if.h > index b8c7cc63065f..30ea6bd969b4 100644 > --- a/include/memory/renesas-rpc-if.h > +++ b/include/memory/renesas-rpc-if.h > @@ -19,7 +19,7 @@ enum rpcif_data_dir { > RPCIF_DATA_OUT, > }; > > -struct rpcif_op { > +struct rpcif_op { > struct { > u8 buswidth; > u8 opcode; > @@ -57,7 +57,7 @@ struct rpcif_op { > } data; > }; > > -struct rpcif { > +struct rpcif { > struct device *dev; > void __iomem *dirmap; > struct regmap *regmap; > @@ -93,4 +93,4 @@ static inline void rpcif_disable_rpm(struct rpcif *rpc) > pm_runtime_put_sync(rpc->dev); > } > > -#endif // __RENESAS_RPC_IF_H > +#endif /* __RENESAS_RPC_IF_H */ MBR, Sergei