From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0A583D88EB for ; Tue, 26 May 2026 09:47:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779788835; cv=none; b=P5lLkuQOPljNzC+lLpBBvZWnkT5iGGdJ0WB07uEWX2/KJ2GIeYDF2eWVHiTBImRUfL4Vk260WQnU3DvdMB02BrwsUMqvmE/GVkln4Js1HiYk0AwfnOdtYIoKAVyiCq/+3DE8pcqt20K9hH/IfiZ+nXUqhj26TEhtIgWaJ7cbEeY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779788835; c=relaxed/simple; bh=8+nGGSKlUH2wqELDfgHiAT/VMPWJ2mHhPQF2ouWQF0w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kDosrStafxCl5+Qz0nlYKweKqxYXHYFAMb3Wz7uyHcFfCA4Xg84HpUEArrCCzX+kECzLmZUAlWaZWqucxkJ/L5SxC39cbxET8f7LZrHHJykShQ+iIda6u8187JRa9tuarysjP/wV5rR51Fgylhnouq8DsgoL5cZyElBzeSYX3wg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=EjQTkHLZ; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="EjQTkHLZ" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4896c22fcbaso88064455e9.0 for ; Tue, 26 May 2026 02:47:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1779788832; x=1780393632; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=R17d81rZFtdCmrvPdq6FOwdkUs8CSvLL3BM8+TQqKKA=; b=EjQTkHLZWZ8pVUg9gk59c/Y6msmKTq3bu4UiXtP0lNvzAnW1HzNIQOI+8h362r8uOz 65J1roOpeed/GO/dcNRKF4mcOqiVwLlqNNBvo5kKdzC6J9wILMHJ9BvPhY9ry3PrsA4i n4rqddafwx34au/rxzpyxQdfV+/h8Wumnpkqoei2H9VUro489toB9gas7h1XDJkUk8CH O+9MN48NZdDBK0b+NhQ0p8I8EarJxSJgpWwmOXqd9qDajMs394MTLqyIaOkGFsYIRRjm 3rP/59t6+CkpeqFn2g9Jsq3yp1J79p7PG+5nH+WBxj0dEoelXcyuvD+avrfoVM++dNME 5pWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779788832; x=1780393632; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R17d81rZFtdCmrvPdq6FOwdkUs8CSvLL3BM8+TQqKKA=; b=GkR+ZGQY30eR6xA1bFsLZ7zjLwmFGPsPvwot7jB56Tiq0sfLR1c+pUC91sBp+ecjOq TmcwB0Q08dBOLBnQcoaYNMUqdWYW6t9DS4EJ1ZnXjV7Zpf+oBpeewuoGEYY699N2NcXC gFXIVRmcNYgugosdAcYvt+ImqZWVM/6NB2Cx+qBcGQ660qtiFyyAMINcMXba3NDliKI9 0Rh5Yk5HkvM86S6R795Wf+B3CSmNsvxnyE4HfrkgkNIJyKrOwtjHuP5GeajtmVawyxm3 RP3cfFp+5Skr+zO3YwneRIBNwWASGCGl60oiqnYeE8Wek+7TTNjpUFwXLJ71xQFTUQmA xVgg== X-Forwarded-Encrypted: i=1; AFNElJ/YWsCOax4X6zbzsZfVKPaBbKy7T7svp+oziWZv8Yhfh+Arl/NjqRkFZxLnBDctxO56kEoryruB1LCMD0E=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2lDnj9TPs844iKXvhBARo5Sapd0HdHE2OQUQ2Bu7XsKbHbdle khHKtsGTQP9SF6/ftFlHd9t7RgghpmbU2/kYqzbHv0H0Wk5m0LFJ2n+ncyBIvMsnMtI= X-Gm-Gg: Acq92OGoj5oKwa3jeJRszcLLAuuK+YBb+3j3aGc4mINxGvzq6k63Brzu4Z0scFh95BR EhYV4LHeWDKGpIPg4JQiIpP768coDHgdJNPBk03PtgF//UjtHXpPNpO6lFY0+z75GeBJZH+lUKQ 0yJS6W+t/mVCMO4rfbIwBHB7Z0eZst5FBYsZ1QvSQ0miXyDatYr1oX6MbGVtg8vdVXMLTjeS3lV al783HlKCb/U33VhVnfy+Vq5LmYte60QaWsBy8WP4XUyaJOHsDO5Yq6dsv8TiwsjEQOLniPDMY/ 19PyX0AUvkWn47HJL/8T1IkjLAdpFr/asR6GmB2bYlRjeMDFLa4yiAuijOuTyjoUMIpWYPARRMl 1VGohOXUeAGEAQYDdnLUP04HBS0rsSTIipuz1YiHEwPfmhJ5yNaVoY5Ee8t71G0gksNbfH9J/y1 mEHSZ3/ZaoO3yfNEBsPoeU8pcIDLALcLcrkGlYxN2qC0M+Yb9ksbWOyckm1Dfkfx+Hofm8jvJR7 Hxu9xnDf2ctB0CzfJdgdM5wX9x08ZJnqrg6Z7nA6f//xdwBmVT7HpbKI4PgrIa2xQx2Jxvt3rU3 GoNX X-Received: by 2002:a05:600c:6209:b0:490:601f:d776 with SMTP id 5b1f17b1804b1-490601fd9admr168561055e9.3.1779788832071; Tue, 26 May 2026 02:47:12 -0700 (PDT) Received: from ?IPV6:2a00:1028:838d:271e:8e3b:4aff:fe4c:a100? (dynamic-2a00-1028-838d-271e-8e3b-4aff-fe4c-a100.ipv6.o2.cz. [2a00:1028:838d:271e:8e3b:4aff:fe4c:a100]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490454a0b9asm307921735e9.11.2026.05.26.02.47.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 May 2026 02:47:11 -0700 (PDT) Message-ID: <8de0e6ad-987a-4729-bbd0-8399968dbb48@suse.com> Date: Tue, 26 May 2026 11:47:09 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 06/14] module: Switch load_info::len to size_t To: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Nathan Chancellor , Nicolas Schier , Arnd Bergmann , Luis Chamberlain , Sami Tolvanen , Daniel Gomez , Paul Moore , James Morris , "Serge E. Hallyn" , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Nicolas Schier , Daniel Gomez , Aaron Tomlin , "Christophe Leroy (CS GROUP)" , Nicolas Bouchinet , Xiu Jianfeng , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , bpf@vger.kernel.org, =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= , Arnout Engelen , Mattia Rizzolo , kpcyrd , Christian Heusel , =?UTF-8?Q?C=C3=A2ju_Mihai-Drosi?= , Eric Biggers , Sebastian Andrzej Siewior , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-modules@vger.kernel.org, linux-security-module@vger.kernel.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-integrity@vger.kernel.org, debian-kernel@lists.debian.org References: <20260505-module-hashes-v5-0-e174a5a49fce@weissschuh.net> <20260505-module-hashes-v5-6-e174a5a49fce@weissschuh.net> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20260505-module-hashes-v5-6-e174a5a49fce@weissschuh.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 5/5/26 11:05 AM, Thomas Weißschuh wrote: > Switching the types will make some later changes cleaner. Since the updated version drops the patch "module: Deduplicate signature extraction", I believe this change is no longer necessary. > size_t is also the semantically correct type for this field. > > As both 'size_t' and 'unsigned long' are always the same size, this > should be risk-free. The module 'len' would now start in init_module() as 'unsigned long', then change in copy_module_from_user() to size_t, and then back to 'unsigned long' when calling copy_chunked_from_user(). The current code is more consistent and mostly uses 'unsigned long', matching the syscall interface. -- Thanks, Petr