From: Dave Hansen <dave.hansen@linux.intel.com>
To: Hector Martin 'marcan' <marcan@marcan.st>, linux-kernel@vger.kernel.org
Cc: x86@kernel.org
Subject: Re: [PATCH] [v2] x86/doc: add PTI description
Date: Thu, 4 Jan 2018 21:32:22 -0800 [thread overview]
Message-ID: <8de1ea34-7c15-f69f-2177-729e1398ed12@linux.intel.com> (raw)
In-Reply-To: <2a2f0da6-3059-3ae5-8e39-48046389ebc9@marcan.st>
On 01/04/2018 05:43 PM, Hector Martin 'marcan' wrote:
> On 2018-01-05 09:24, Dave Hansen wrote:
>> + Not specifying this option nothing is equivalent to
>> + pti=auto.
>
> -nothing
Sure, will fix.
>> +Page Table Isolation (pti, previously known as KAISER[1]) is a
>> +countermeasure against attacks on kernel address information such
>> +as the "Meltdown" approach[2].
>
> It's not really just address information, but any data. Maybe "attacks
> that leak kernel memory"?
It's not just kernel leaks either, though.
>> +To avoid leaking address information, we create an new, independent
>
> Same issue here. Also an -> a.
Will fix.
>> +copy of the page tables which are used only when running userspace
>
> are -> is. The copy is singular.
I've reworded the sentence to remove the ambiguity.
>> +applications. When the kernel is entered via syscalls, interrupts or
>> +exceptions, page tables are switched to the full "kernel" copy. When
>
> "the page tables".
No thanks. It's fine the way it is.
>> +crippled by setting the NX bit in the top level. This ensures
>> +that if a kernel->user CR3 switch is missed that userspace will
>> +crash immediately upon executing its first instruction.
>
> "that userspace" -> "then userspace"
next prev parent reply other threads:[~2018-01-05 5:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 0:24 Dave Hansen
2018-01-05 1:43 ` Hector Martin 'marcan'
2018-01-05 5:32 ` Dave Hansen [this message]
2018-01-05 2:45 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8de1ea34-7c15-f69f-2177-729e1398ed12@linux.intel.com \
--to=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®