From: David Ahern <dsahern@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
Yejune Deng <yejune.deng@gmail.com>,
davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org,
kuba@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel test robot <oliver.sang@intel.com>
Subject: Re: [PATCH] arp: Remove the arp_hh_ops structure
Date: Mon, 22 Feb 2021 09:07:13 -0700 [thread overview]
Message-ID: <8de8cee8-55d3-5748-d17e-08dba3cf778d@gmail.com> (raw)
In-Reply-To: <0143f961-7530-3ae9-27f2-f076ea951975@gmail.com>
On 2/22/21 1:37 AM, Eric Dumazet wrote:
>
>
> On 2/22/21 4:15 AM, Yejune Deng wrote:
>> The arp_hh_ops structure is similar to the arp_generic_ops structure.
>> but the latter is more general,so remove the arp_hh_ops structure.
>>
>> Fix when took out the neigh->ops assignment:
>> 8.973653] #PF: supervisor read access in kernel mode
>> [ 8.975027] #PF: error_code(0x0000) - not-present page
>> [ 8.976310] PGD 0 P4D 0
>> [ 8.977036] Oops: 0000 [#1] SMP PTI
>> [ 8.977973] CPU: 1 PID: 210 Comm: sd-resolve Not tainted 5.11.0-rc7-02046-g4591591ab715 #1
>> [ 8.979998] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
>> [ 8.981996] RIP: 0010:neigh_probe (kbuild/src/consumer/net/core/neighbour.c:1009)
>>
>
> I have a hard time understanding this patch submission.
>
> This seems a mix of a net-next and net material ?
It is net-next at best.
>
>
>
>> Reported-by: kernel test robot <oliver.sang@intel.com>
>
> If this is a bug fix, we want a Fixes: tag
>
> This will really help us. Please don't let us guess what is going on.
>
This patch is a v2. v1 was clearly wrong and not tested; I responded as
such 12 hours before the robot test.
next prev parent reply other threads:[~2021-02-22 16:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 3:15 Yejune Deng
2021-02-22 8:37 ` Eric Dumazet
2021-02-22 16:07 ` David Ahern [this message]
2021-02-23 7:00 ` Yejune Deng
-- strict thread matches above, loose matches on Subject: below --
2021-02-20 4:32 Yejune Deng
2021-02-21 1:54 ` David Ahern
2021-02-21 2:20 ` Yejune Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8de8cee8-55d3-5748-d17e-08dba3cf778d@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver.sang@intel.com \
--cc=yejune.deng@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®