mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: linux-arm-msm@vger.kernel.org,
	Ekansh Gupta <quic_ekangupt@quicinc.com>,
	gregkh@linuxfoundation.org, quic_bkumar@quicinc.com,
	linux-kernel@vger.kernel.org, quic_chennak@quicinc.com,
	dri-devel@lists.freedesktop.org, arnd@arndb.de
Subject: Re: [PATCH v1 0/2] Add missing fixes in fastrpc_get_args
Date: Mon, 30 Dec 2024 20:32:30 +0000	[thread overview]
Message-ID: <8dee006c-cc1a-4274-8691-2d58372bc022@linaro.org> (raw)
In-Reply-To: <qd32erndjbtspx4im5u2ge2vgdc4qwwvxhkoaefxwzkue5x7kc@ghk5fdkma6vm>



On 30/12/2024 18:22, Dmitry Baryshkov wrote:
> On Mon, Dec 30, 2024 at 04:15:42PM +0000, Srinivas Kandagatla wrote:
>>
>> On Wed, 18 Dec 2024 15:54:27 +0530, Ekansh Gupta wrote:
>>> This patch series adds the listed bug fixes that have been missing
>>> in upstream fastRPC driver:
>>> - Page address for registered buffer(with fd) is not calculated
>>>    properly.
>>> - Page size calculation for non-registered buffer(copy buffer) is
>>>    incorrect.
>>>
>>> [...]
>>
>> Applied, thanks!
> 
> May I ask, why they are being accepted with the obvious checkpatch
> warnings?

If you are referring to this warning.
WARNING: Invalid email format for stable: 'stable <stable@kernel.org>', 
prefer 'stable@kernel.org'

I tend to fix such small warnings before applying. These are fixed now.

> 
> What kind of process is being followed, as those patches had review
> comments to be implemented in the next iteration.

I apply these patches if it looks good to me. This also helps with 
getting it tested from wider audience via linux-next.

I do run TFLite workloads before it ends up in char-misc, but not for 
every patch.

sorry If I missed any blocker comments, but your comments were more on 
the cover letter content and asking about the work loads which triggers 
these bugs.

Are these patches breaking any of your test-cases?


--srini


  reply	other threads:[~2024-12-30 20:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-18 10:24 Ekansh Gupta
2024-12-18 10:24 ` [PATCH v1 1/2] misc: fastrpc: Fix registered buffer page address Ekansh Gupta
2024-12-18 11:12   ` Dmitry Baryshkov
2025-01-09  5:39     ` Ekansh Gupta
2025-01-09 12:25       ` Dmitry Baryshkov
2024-12-18 10:24 ` [PATCH v1 2/2] misc: fastrpc: Fix copy buffer page size Ekansh Gupta
2024-12-18 11:14   ` Dmitry Baryshkov
2024-12-18 11:11 ` [PATCH v1 0/2] Add missing fixes in fastrpc_get_args Dmitry Baryshkov
2024-12-30 16:15 ` Srinivas Kandagatla
2024-12-30 18:22   ` Dmitry Baryshkov
2024-12-30 20:32     ` Srinivas Kandagatla [this message]
2024-12-30 23:51       ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8dee006c-cc1a-4274-8691-2d58372bc022@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=arnd@arndb.de \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_bkumar@quicinc.com \
    --cc=quic_chennak@quicinc.com \
    --cc=quic_ekangupt@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®