From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 565B3C433E0 for ; Tue, 5 Jan 2021 11:09:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A791229C7 for ; Tue, 5 Jan 2021 11:09:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729005AbhAELJq (ORCPT ); Tue, 5 Jan 2021 06:09:46 -0500 Received: from foss.arm.com ([217.140.110.172]:52806 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727764AbhAELJp (ORCPT ); Tue, 5 Jan 2021 06:09:45 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1EB131FB; Tue, 5 Jan 2021 03:09:00 -0800 (PST) Received: from [10.163.89.46] (unknown [10.163.89.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A4C113F70D; Tue, 5 Jan 2021 03:08:55 -0800 (PST) Subject: Re: [PATCH] arm64/smp: Remove unused variable irq in arch_show_interrupts() To: Catalin Marinas , Keqian Zhu Cc: Mark Rutland , kvm@vger.kernel.org, Suzuki K Poulose , Marc Zyngier , Joerg Roedel , linux-kernel@vger.kernel.org, James Morse , Julien Thierry , wanghaibin.wang@huawei.com, Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Robin Murphy References: <20210105092221.15144-1-zhukeqian1@huawei.com> <20210105100847.GB11802@gaia> From: Anshuman Khandual Message-ID: <8deed54d-d184-69b8-fce9-d87128a7d880@arm.com> Date: Tue, 5 Jan 2021 16:39:15 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210105100847.GB11802@gaia> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/5/21 3:38 PM, Catalin Marinas wrote: > On Tue, Jan 05, 2021 at 05:22:21PM +0800, Keqian Zhu wrote: >> The local variable irq is added in commit a26388152531 ("arm64: >> Remove custom IRQ stat accounting"), but forget to remove in >> commit 5089bc51f81f ("arm64/smp: Use irq_desc_kstat_cpu() in >> arch_show_interrupts()"). Just remove it. >> >> Signed-off-by: Keqian Zhu > > I already queued a similar fix in arm64 for-next/fixes (it should appear > in linux-next at some point) I too sent this fix yesterday as well :) as it was preventing a clean build on v5.11-rc2. Missed to check this on arm64 for-next/fixes though I did check on linux-next.