From: Dan Murphy <dmurphy@ti.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
<linux-leds@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>, <dachaac@gmail.com>,
<robh+dt@kernel.org>
Subject: Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver
Date: Thu, 17 Jan 2019 07:27:00 -0600 [thread overview]
Message-ID: <8def5414-9170-7034-34f9-70e6c71f8161@ti.com> (raw)
In-Reply-To: <20190117100651.GB17930@amd>
Hello
On 1/17/19 4:06 AM, Pavel Machek wrote:
> Hi!
>
>>>>> You know what? First, submit driver with similar functionality to
>>>>> existing RGB drivers, using same interface existing drivers are
>>>>> using. When that is accepted, we can talk about extending
>>>>> kernel<->user interfaces.
>>>>>
>>>>
>>>> I could do that but then there is no way for users to have any other color but "white" with this driver.
>>>> That defeats the purpose of the device itself.
>>>
>>> No, that is not what I meant.
>>>
>>> We do have RGB drivers in tree, they just present three separate LEDs
>>> -- red, green and blue. I ask you to do the same for initial
>>> submission.
>>>
>>
>> For clarification you are asking me to register a LED class per
>> output pin?
>
> Yes.
>
OK I can do that but I would like to get Jacek to align with this as he
suggested creating the code as I submitted based on the review of the
devices data sheet.
LED class registration per LED module or for the single Banked output.
>> As explained before the Master brightness register has absolute control over the output current
>> to the LED outputs regardless of the color control setting.
>>
>
> Yes, just set master brightness to 255 and you can ignore it.
OK Sounds fine. Will just need to do an init that sets the color
register to 0 and brightness to 0 so we don't have a flash.
>
>>> You'll still be able to set brightness independently on the
>>> red/green/blue LEDs...
>>>
>>
>> But which one would control the overall brightness of the cluster?
>
> You would not have that control in initial version of the patch.
>
See above on alignment
Dan
> Pavel
>
--
------------------
Dan Murphy
next prev parent reply other threads:[~2019-01-17 13:27 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 21:17 [PATCH v2 1/2] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Dan Murphy
2019-01-14 21:17 ` [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver Dan Murphy
2019-01-15 21:47 ` Jacek Anaszewski
2019-01-15 22:22 ` Pavel Machek
2019-01-16 0:20 ` Dan Murphy
2019-01-16 10:55 ` Pavel Machek
2019-01-16 18:41 ` Dan Murphy
2019-01-16 22:04 ` Pavel Machek
2019-01-16 23:33 ` Dan Murphy
2019-01-17 10:06 ` Pavel Machek
2019-01-17 13:27 ` Dan Murphy [this message]
2019-01-17 21:10 ` Jacek Anaszewski
2019-01-18 0:02 ` RGB LED class " Pavel Machek
2019-01-18 15:57 ` Dan Murphy
2019-01-28 23:03 ` Pavel Machek
2019-01-18 22:13 ` Jacek Anaszewski
2019-01-19 21:36 ` Pavel Machek
2019-01-20 15:30 ` Jacek Anaszewski
2019-01-21 19:38 ` Jacek Anaszewski
2019-01-28 23:04 ` Pavel Machek
2019-01-18 13:45 ` Dan Murphy
2019-01-18 13:58 ` Dan Murphy
2019-01-20 6:42 ` Vesa Jääskeläinen
2019-01-22 21:39 ` Jacek Anaszewski
2019-01-22 22:44 ` Dan Murphy
2019-01-23 21:52 ` Jacek Anaszewski
2019-01-24 21:00 ` Dan Murphy
2019-01-24 21:55 ` Jacek Anaszewski
2019-01-29 13:56 ` Dan Murphy
2019-01-29 20:19 ` Jacek Anaszewski
2019-01-29 20:26 ` Dan Murphy
2019-01-29 21:45 ` Pavel Machek
2019-01-29 21:46 ` Dan Murphy
2019-01-29 21:53 ` Jacek Anaszewski
2019-01-20 15:32 ` Jacek Anaszewski
2019-01-17 21:08 ` Jacek Anaszewski
2019-01-19 19:11 ` Vesa Jääskeläinen
2019-01-19 21:46 ` Pavel Machek
2019-01-19 22:44 ` Vesa Jääskeläinen
2019-01-20 6:51 ` Vesa Jääskeläinen
2019-01-21 13:27 ` Dan Murphy
2019-01-21 15:12 ` Vesa Jääskeläinen
2019-01-24 20:32 ` Dan Murphy
2019-01-24 21:14 ` Jacek Anaszewski
2019-01-15 21:42 ` [PATCH v2 1/2] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8def5414-9170-7034-34f9-70e6c71f8161@ti.com \
--to=dmurphy@ti.com \
--cc=dachaac@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®