mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: "Vítor Hugo Silva" <vitorhg20080@gmail.com>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
	Diogo Ivo <diogo.ivo@siemens.com>,
	linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: intel_oc_wdt: Add INTC109C ACPI ID
Date: Sun, 15 Nov 2026 14:39:40 -0800	[thread overview]
Message-ID: <8df779d7-eaa9-44c4-a0d8-e9187fd8819e@roeck-us.net> (raw)
In-Reply-To: <20261115205408.99849-1-vitorhg20080@gmail.com>

On Sun, Nov 15, 2026 at 08:54:08PM +0000, Vítor Hugo Silva wrote:
> The Lenovo laptops with an Intel Core 7 240H (Raptor Lake)
> exposes its OC watchdog as 'INTC109C', leaving the device
> unbound, because this ID is not present from the driver's
> ACPI intel_oc_wdt_match table.
> 
> The firmware selects INTC109C or the already supported
> INTC1099 from the same CWDT object's _HID method,
> depending on the processor signature. Both paths share a
> four-byte I/O resource at PMBS + 0x54.
> 
> Add INTC109C to the match table to use the existing implementation.
> 
> I have tested as a module on Fedora kernel 7.3.3-300.fc45.x86_64.
> I did verify device binding, timeout configuration, start,
> keepalive, explicit stop and magic close. Register reads
> confirmed the enable and timeout fields. Expiry-triggered
> reset was not tested.
> 
> AI assistance was used for development of the test harness
> and 'peer-review' the patch.
> 
> Signed-off-by: Vítor Hugo Silva <vitorhg20080@gmail.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/watchdog/intel_oc_wdt.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> 
> base-commit: 97d73c8251226cf27cc6656b4c542869bb8c69fa
> 
> diff --git a/drivers/watchdog/intel_oc_wdt.c b/drivers/watchdog/intel_oc_wdt.c
> index 0b012aeb1..a78fe1e5f 100644
> --- a/drivers/watchdog/intel_oc_wdt.c
> +++ b/drivers/watchdog/intel_oc_wdt.c
> @@ -215,6 +215,7 @@ static int intel_oc_wdt_probe(struct platform_device *pdev)
>  static const struct acpi_device_id intel_oc_wdt_match[] = {
>  	{ "INT3F0D" },
>  	{ "INTC1099" },
> +	{ "INTC109C" },
>  	{ },
>  };
>  MODULE_DEVICE_TABLE(acpi, intel_oc_wdt_match);

      parent reply	other threads:[~2026-11-15 22:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 20:54 Vítor Hugo Silva
2026-11-15 21:29 ` Guenter Roeck
2026-11-15 21:57   ` Vítor Silva
2026-11-15 22:39 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8df779d7-eaa9-44c4-a0d8-e9187fd8819e@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=diogo.ivo@siemens.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=vitorhg20080@gmail.com \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®