From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E94DC433E1 for ; Fri, 5 Jun 2020 19:54:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F34B2074B for ; Fri, 5 Jun 2020 19:54:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="mrOw4zf3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728112AbgFETyQ (ORCPT ); Fri, 5 Jun 2020 15:54:16 -0400 Received: from linux.microsoft.com ([13.77.154.182]:33226 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727868AbgFETyP (ORCPT ); Fri, 5 Jun 2020 15:54:15 -0400 Received: from [192.168.0.104] (c-73-42-176-67.hsd1.wa.comcast.net [73.42.176.67]) by linux.microsoft.com (Postfix) with ESMTPSA id 260C920B7185; Fri, 5 Jun 2020 12:54:15 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 260C920B7185 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1591386855; bh=7adZ1mV+sRKq6BSSwQpcHcTCgE1BM6KiH2V0doIwFc4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=mrOw4zf3U55HlWNfq/Tro6txy/iOGRWHIPHjdxZcMZwzpm9BC5SSd2MolZkSq0ZQw 9CDGF7hqAQTZVPv+KcZcupYnLmkdS+FbDJtAA4YkKrD67TDa8/P83Z28MotpFy5Bw7 MTlYxOKpjP0ClhKxh1gCkzrZ/CCh6Zxdqz/CpUVc= Subject: Re: [PATCH] IMA: Add log statements for failure conditions To: Paul Moore , Mimi Zohar Cc: linux-integrity@vger.kernel.org, tusharsu@linux.microsoft.com, linux-kernel@vger.kernel.org, linux-audit@redhat.com References: <20200604163243.2575-1-nramas@linux.microsoft.com> <1591382782.5816.36.camel@linux.ibm.com> From: Lakshmi Ramasubramanian Message-ID: <8dfb3fa6-5c1f-d644-7d21-72a9448c52cc@linux.microsoft.com> Date: Fri, 5 Jun 2020 12:54:14 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/5/20 12:37 PM, Paul Moore wrote: > If it's audit related, it's generally best to CC the linux-audit list, > not just me (fixed). > > It's not clear to me what this pr_err() is trying to indicate other > than *something* failed. Can someone provide some more background on > this message? process_buffer_measurement() is currently used to measure "kexec command line", "keys", and "blacklist-hash". If there was any error in the measurement, this pr_err() will indicate which of the above measurement failed and the related error code. Please let me know if you need more info on this one. Since a pr_xyz() call was already present, I just wanted to change the log level to keep the code change to the minimum. But if audit log is the right approach for this case, I'll update. thanks, -lakshmi