mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Huacai Chen <chenhuacai@kernel.org>,
	Josh Poimboeuf <jpoimboe@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	loongarch@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] objtool/LoongArch: Fix unreachable instruction warnings about head.S
Date: Tue, 26 Aug 2025 20:27:13 +0800	[thread overview]
Message-ID: <8dfe8bde-0095-d6c3-b9ca-cce2bf720ac2@loongson.cn> (raw)
In-Reply-To: <20250826082057.GE3245006@noisy.programming.kicks-ass.net>

On 2025/8/26 下午4:20, Peter Zijlstra wrote:
> On Tue, Aug 26, 2025 at 02:46:31PM +0800, Tiezhu Yang wrote:
>> When compiling with LLVM and CONFIG_LTO_CLANG is set, there exist the
>> following objtool warnings after silencing all of the other warnings:

...

>> Just give a proper unwind hint to silence the above warnings. By the way,
>> the previous instructions of kernel_entry+0xf4 and smpboot_entry+0x68 are
>> the 'bl' instructions, the call destination symbols are start_kernel() and
>> start_secondary() which are noreturn functions, then the 'bl' instructions
>> are marked as dead end in annotate_call_site(), so actually ASM_BUG() can
>> be removed due to unnecessary, otherwise there are following warnings:

...

>> Link: https://lore.kernel.org/lkml/20250814083651.GR4067720@noisy.programming.kicks-ass.net/
>> Suggested-by: Peter Zijlstra <peterz@infradead.org>
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>> ---
>>   arch/loongarch/kernel/head.S | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> At this point you should also be able to remove that Makefile thing,
> right?

Yes, you are right, will do it in the next version if this patch
makes sense.

Thanks,
Tiezhu


  reply	other threads:[~2025-08-26 12:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-26  6:46 [RFC PATCH 0/2] Fix objtool warnings if LTO is enabled for LoongArch (Part 2) Tiezhu Yang
2025-08-26  6:46 ` [RFC PATCH 1/2] objtool/LoongArch: Fix fall through warning about efi_boot_kernel() Tiezhu Yang
2025-08-26  8:32   ` Huacai Chen
2025-08-26 12:33     ` Tiezhu Yang
2025-08-26 13:03       ` Huacai Chen
2025-08-26 23:39         ` Josh Poimboeuf
2025-08-28  2:01           ` Tiezhu Yang
2025-08-26  6:46 ` [RFC PATCH 2/2] objtool/LoongArch: Fix unreachable instruction warnings about head.S Tiezhu Yang
2025-08-26  8:20   ` Peter Zijlstra
2025-08-26 12:27     ` Tiezhu Yang [this message]
2025-08-26  8:26   ` Huacai Chen
2025-08-26 12:30     ` Tiezhu Yang
2025-08-26 23:43       ` Josh Poimboeuf
2025-08-28  2:01         ` Tiezhu Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8dfe8bde-0095-d6c3-b9ca-cce2bf720ac2@loongson.cn \
    --to=yangtiezhu@loongson.cn \
    --cc=chenhuacai@kernel.org \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loongarch@lists.linux.dev \
    --cc=nathan@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®