From: "Leonardo Brás" <leobras@redhat.com>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Palmer Dabbelt <palmer@rivosinc.com>,
Will Deacon <will@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Boqun Feng <boqun.feng@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>, Guo Ren <guoren@kernel.org>,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [RFC PATCH 1/1] riscv/atomic.h: Deduplicate arch_atomic.*
Date: Thu, 03 Aug 2023 03:13:58 -0300 [thread overview]
Message-ID: <8e0623921f52113735d32f184f26e888e4e4e463.camel@redhat.com> (raw)
In-Reply-To: <CAJ6HWG7kvWtZHTBMiFAQriUn84E8SYuGmtAGmW8YVwqUyoUYgQ@mail.gmail.com>
On Wed, 2023-08-02 at 17:00 -0300, Leonardo Bras Soares Passos wrote:
> On Thu, May 25, 2023 at 7:07 AM Guo Ren <guoren@kernel.org> wrote:
> >
> > On Thu, May 25, 2023 at 5:31 PM Leonardo Bras Soares Passos
> > <leobras@redhat.com> wrote:
> > >
> > > Friendly ping?
> > >
> > > On Wed, Apr 19, 2023 at 3:25 AM Leonardo Bras <leobras@redhat.com> wrote:
> > > >
> > > > Some functions use mostly the same asm for 32-bit and 64-bit versions.
> > > >
> > > > Make a macro that is generic enough and avoid code duplication.
> > > >
> > > > Signed-off-by: Leonardo Bras <leobras@redhat.com>
> > > > ---
> > > > arch/riscv/include/asm/atomic.h | 164 +++++++++++++++-----------------
> > > > 1 file changed, 76 insertions(+), 88 deletions(-)
> > > >
> > > > diff --git a/arch/riscv/include/asm/atomic.h b/arch/riscv/include/asm/atomic.h
> > > > index 0dfe9d857a762..85eb2edbc8219 100644
> > > > --- a/arch/riscv/include/asm/atomic.h
> > > > +++ b/arch/riscv/include/asm/atomic.h
> > > > @@ -196,22 +196,28 @@ ATOMIC_OPS(xor, xor, i)
> > > > #undef ATOMIC_FETCH_OP
> > > > #undef ATOMIC_OP_RETURN
> > > >
> > > > +#define _arch_atomic_fetch_add_unless(_prev, _rc, counter, _a, _u, sfx) \
> > > > +({ \
> > > > + __asm__ __volatile__ ( \
> > > > + "0: lr." sfx " %[p], %[c]\n" \
> > > > + " beq %[p], %[u], 1f\n" \
> > > > + " add %[rc], %[p], %[a]\n" \
> > > > + " sc." sfx ".rl %[rc], %[rc], %[c]\n" \
> > > > + " bnez %[rc], 0b\n" \
> > > > + " fence rw, rw\n" \
> > > > + "1:\n" \
> > > > + : [p]"=&r" (_prev), [rc]"=&r" (_rc), [c]"+A" (counter) \
> > > > + : [a]"r" (_a), [u]"r" (_u) \
> > > > + : "memory"); \
> > > > +})
> > > > +
> > > > /* This is required to provide a full barrier on success. */
> > > > static __always_inline int arch_atomic_fetch_add_unless(atomic_t *v, int a, int u)
> > > > {
> > > > int prev, rc;
> > > >
> > > > - __asm__ __volatile__ (
> > > > - "0: lr.w %[p], %[c]\n"
> > > > - " beq %[p], %[u], 1f\n"
> > > > - " add %[rc], %[p], %[a]\n"
> > > > - " sc.w.rl %[rc], %[rc], %[c]\n"
> > > > - " bnez %[rc], 0b\n"
> > > > - " fence rw, rw\n"
> > > > - "1:\n"
> > > > - : [p]"=&r" (prev), [rc]"=&r" (rc), [c]"+A" (v->counter)
> > > > - : [a]"r" (a), [u]"r" (u)
> > > > - : "memory");
> > > > + _arch_atomic_fetch_add_unless(prev, rc, v->counter, a, u, "w");
> > > > +
> > > > return prev;
> > > > }
> > > > #define arch_atomic_fetch_add_unless arch_atomic_fetch_add_unless
> > > > @@ -222,17 +228,8 @@ static __always_inline s64 arch_atomic64_fetch_add_unless(atomic64_t *v, s64 a,
> > > > s64 prev;
> > > > long rc;
> > > >
> > > > - __asm__ __volatile__ (
> > > > - "0: lr.d %[p], %[c]\n"
> > > > - " beq %[p], %[u], 1f\n"
> > > > - " add %[rc], %[p], %[a]\n"
> > > > - " sc.d.rl %[rc], %[rc], %[c]\n"
> > > > - " bnez %[rc], 0b\n"
> > > > - " fence rw, rw\n"
> > > > - "1:\n"
> > > > - : [p]"=&r" (prev), [rc]"=&r" (rc), [c]"+A" (v->counter)
> > > > - : [a]"r" (a), [u]"r" (u)
> > > > - : "memory");
> > > > + _arch_atomic_fetch_add_unless(prev, rc, v->counter, a, u, "d");
> > > > +
> > > > return prev;
> > > > }
> > > > #define arch_atomic64_fetch_add_unless arch_atomic64_fetch_add_unless
> > > > @@ -310,61 +307,79 @@ ATOMIC_OPS()
> > > > #undef ATOMIC_OPS
> > > > #undef ATOMIC_OP
> > > >
> > > > +#define _arch_atomic_inc_unless_negative(_prev, _rc, counter, sfx) \
> > > > +({ \
> > > > + __asm__ __volatile__ ( \
> > > > + "0: lr." sfx " %[p], %[c]\n" \
> > > > + " bltz %[p], 1f\n" \
> > > > + " addi %[rc], %[p], 1\n" \
> > > > + " sc." sfx ".rl %[rc], %[rc], %[c]\n" \
> > > > + " bnez %[rc], 0b\n" \
> > > > + " fence rw, rw\n" \
> > > > + "1:\n" \
> > > > + : [p]"=&r" (_prev), [rc]"=&r" (_rc), [c]"+A" (counter) \
> > > > + : \
> > > > + : "memory"); \
> > > > +})
> > > > +
> > > > static __always_inline bool arch_atomic_inc_unless_negative(atomic_t *v)
> > > > {
> > > > int prev, rc;
> > > >
> > > > - __asm__ __volatile__ (
> > > > - "0: lr.w %[p], %[c]\n"
> > > > - " bltz %[p], 1f\n"
> > > > - " addi %[rc], %[p], 1\n"
> > > > - " sc.w.rl %[rc], %[rc], %[c]\n"
> > > > - " bnez %[rc], 0b\n"
> > > > - " fence rw, rw\n"
> > > > - "1:\n"
> > > > - : [p]"=&r" (prev), [rc]"=&r" (rc), [c]"+A" (v->counter)
> > > > - :
> > > > - : "memory");
> > > > + _arch_atomic_inc_unless_negative(prev, rc, v->counter, "w");
> > > > +
> > > > return !(prev < 0);
> > > > }
> > > >
> > > > #define arch_atomic_inc_unless_negative arch_atomic_inc_unless_negative
> > > >
> > > > +#define _arch_atomic_dec_unless_positive(_prev, _rc, counter, sfx) \
> > > > +({ \
> > > > + __asm__ __volatile__ ( \
> > > > + "0: lr." sfx " %[p], %[c]\n" \
> > > > + " bgtz %[p], 1f\n" \
> > > > + " addi %[rc], %[p], -1\n" \
> > > > + " sc." sfx ".rl %[rc], %[rc], %[c]\n" \
> > > > + " bnez %[rc], 0b\n" \
> > > > + " fence rw, rw\n" \
> > > > + "1:\n" \
> > > > + : [p]"=&r" (_prev), [rc]"=&r" (_rc), [c]"+A" (counter) \
> > > > + : \
> > > > + : "memory"); \
> > > > +})
> > > > +
> > > > static __always_inline bool arch_atomic_dec_unless_positive(atomic_t *v)
> > > > {
> > > > int prev, rc;
> > > >
> > > > - __asm__ __volatile__ (
> > > > - "0: lr.w %[p], %[c]\n"
> > > > - " bgtz %[p], 1f\n"
> > > > - " addi %[rc], %[p], -1\n"
> > > > - " sc.w.rl %[rc], %[rc], %[c]\n"
> > > > - " bnez %[rc], 0b\n"
> > > > - " fence rw, rw\n"
> > > > - "1:\n"
> > > > - : [p]"=&r" (prev), [rc]"=&r" (rc), [c]"+A" (v->counter)
> > > > - :
> > > > - : "memory");
> > > > + _arch_atomic_dec_unless_positive(prev, rc, v->counter, "w");
> > > > +
> > > > return !(prev > 0);
> > > > }
> > > >
> > > > #define arch_atomic_dec_unless_positive arch_atomic_dec_unless_positive
> > > >
> > > > +#define _arch_atomic_dec_if_positive(_prev, _rc, counter, sfx) \
> > > > +({ \
> > > > + __asm__ __volatile__ ( \
> > > > + "0: lr." sfx " %[p], %[c]\n" \
> > > > + " addi %[rc], %[p], -1\n" \
> > > > + " bltz %[rc], 1f\n" \
> > > > + " sc." sfx ".rl %[rc], %[rc], %[c]\n" \
> > > > + " bnez %[rc], 0b\n" \
> > > > + " fence rw, rw\n" \
> > > > + "1:\n" \
> > > > + : [p]"=&r" (_prev), [rc]"=&r" (_rc), [c]"+A" (counter) \
> > > > + : \
> > > > + : "memory"); \
> > > > +})
> > > > +
> > > > static __always_inline int arch_atomic_dec_if_positive(atomic_t *v)
> > > > {
> > > > int prev, rc;
> > > >
> > > > - __asm__ __volatile__ (
> > > > - "0: lr.w %[p], %[c]\n"
> > > > - " addi %[rc], %[p], -1\n"
> > > > - " bltz %[rc], 1f\n"
> > > > - " sc.w.rl %[rc], %[rc], %[c]\n"
> > > > - " bnez %[rc], 0b\n"
> > > > - " fence rw, rw\n"
> > > > - "1:\n"
> > > > - : [p]"=&r" (prev), [rc]"=&r" (rc), [c]"+A" (v->counter)
> > > > - :
> > > > - : "memory");
> > > > + _arch_atomic_dec_if_positive(prev, rc, v->counter, "w");
> > > > +
> > > > return prev - 1;
> > > > }
> > > >
> > > > @@ -376,17 +391,8 @@ static __always_inline bool arch_atomic64_inc_unless_negative(atomic64_t *v)
> > > > s64 prev;
> > > > long rc;
> > > >
> > > > - __asm__ __volatile__ (
> > > > - "0: lr.d %[p], %[c]\n"
> > > > - " bltz %[p], 1f\n"
> > > > - " addi %[rc], %[p], 1\n"
> > > > - " sc.d.rl %[rc], %[rc], %[c]\n"
> > > > - " bnez %[rc], 0b\n"
> > > > - " fence rw, rw\n"
> > > > - "1:\n"
> > > > - : [p]"=&r" (prev), [rc]"=&r" (rc), [c]"+A" (v->counter)
> > > > - :
> > > > - : "memory");
> > > > + _arch_atomic_inc_unless_negative(prev, rc, v->counter, "d");
> > > > +
> > > > return !(prev < 0);
> > > > }
> > > >
> > > > @@ -397,17 +403,8 @@ static __always_inline bool arch_atomic64_dec_unless_positive(atomic64_t *v)
> > > > s64 prev;
> > > > long rc;
> > > >
> > > > - __asm__ __volatile__ (
> > > > - "0: lr.d %[p], %[c]\n"
> > > > - " bgtz %[p], 1f\n"
> > > > - " addi %[rc], %[p], -1\n"
> > > > - " sc.d.rl %[rc], %[rc], %[c]\n"
> > > > - " bnez %[rc], 0b\n"
> > > > - " fence rw, rw\n"
> > > > - "1:\n"
> > > > - : [p]"=&r" (prev), [rc]"=&r" (rc), [c]"+A" (v->counter)
> > > > - :
> > > > - : "memory");
> > > > + _arch_atomic_dec_unless_positive(prev, rc, v->counter, "d");
> > > > +
> > > > return !(prev > 0);
> > > > }
> > > >
> > > > @@ -418,17 +415,8 @@ static __always_inline s64 arch_atomic64_dec_if_positive(atomic64_t *v)
> > > > s64 prev;
> > > > long rc;
> > > >
> > > > - __asm__ __volatile__ (
> > > > - "0: lr.d %[p], %[c]\n"
> > > > - " addi %[rc], %[p], -1\n"
> > > > - " bltz %[rc], 1f\n"
> > > > - " sc.d.rl %[rc], %[rc], %[c]\n"
> > > > - " bnez %[rc], 0b\n"
> > > > - " fence rw, rw\n"
> > > > - "1:\n"
> > > > - : [p]"=&r" (prev), [rc]"=&r" (rc), [c]"+A" (v->counter)
> > > > - :
> > > > - : "memory");
> > > > + _arch_atomic_dec_if_positive(prev, rc, v->counter, "d");
> > > > +
> > > > return prev - 1;
> > > > }
> > > >
> > > > --
> > > > 2.40.0
> > > >
> > >
> > A safe cleanup, no problem found.
> >
> > Reviewed-by: Guo Ren <guoren@kernel.org>
> >
> >
>
> Hello Palmer,
>
> Any improvements you suggest for this patch?
>
> Best regards,
> Leonardo Bras
Superseded by v2:
https://patchwork.kernel.org/project/linux-riscv/list/?series=772422&state=%2A&archive=both
Leo
prev parent reply other threads:[~2023-08-03 6:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 6:25 Leonardo Bras
2023-05-25 9:31 ` Leonardo Bras Soares Passos
2023-05-25 10:06 ` Guo Ren
2023-07-04 2:08 ` Leonardo Brás
2023-08-02 20:00 ` Leonardo Bras Soares Passos
2023-08-02 20:19 ` Leonardo Bras Soares Passos
2023-08-03 6:13 ` Leonardo Brás [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e0623921f52113735d32f184f26e888e4e4e463.camel@redhat.com \
--to=leobras@redhat.com \
--cc=aou@eecs.berkeley.edu \
--cc=boqun.feng@gmail.com \
--cc=guoren@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®